[Bug 148930] New: digikam-0.9.2 does not compile with lcms-1.17

[ingmar vanhassel-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         
           Summary: digikam-0.9.2 does not compile with lcms-1.17
           Product: digikam
           Version: unspecified
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: ingmar.vanhassel gmail com


Version:           0.9.2 (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages
Compiler:          gnu-gcc 4.2.0
OS:                Linux

Digikam fails to compile with a version of lcms > 1.16.

snippet from the Changelog for lcms-1.17:

 New in ver 1.17
 ===============

Changes in API
----------------------

WIN64 support
_vsnprintf wrap
BOOL replaced by LCMSBOOL
cmsSetLanguage parameters changed to match ICC spec
removed support for extended gamut descriptor (was never fully implemented)
cmsFLAGS_NODEFAULTRESOURCEDEF moved to 0x01000000
_cmsMalloc wrapper for malloc
_cmsFree wrapper for free
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[ingmar vanhassel-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         




------- Additional Comments From ingmar.vanhassel gmail com  2007-08-17 15:22 -------
Created an attachment (id=21421)
 --> (http://bugs.kde.org/attachment.cgi?id=21421&action=view)
digikam-0.9.2 build log

Attaching build log, showing compiler output.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         
rdieter math unl edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter math unl edu
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         
anaselli linux it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anaselli linux it
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         




------- Additional Comments From anaselli linux it  2007-08-22 00:22 -------
Created an attachment (id=21446)
 --> (http://bugs.kde.org/attachment.cgi?id=21446&action=view)
patch to solve the problem

this simple patch fixes the problem and keeps the compatibility with old 1.16
version. That could be helpful to keep old version testers, and to give
packager the availability to backport fixings.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Color Management



------- Additional Comments From caulier.gilles gmail com  2007-08-22 08:00 -------
Thanks for the patch Angello. I will test today...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         




------- Additional Comments From caulier.gilles gmail com  2007-08-22 08:12 -------
SVN commit 703177 by cgilles:

digiKam from trunk (KDE4): patch from Angelo Naselli about to compile digiKam with lcms 1.17. Tested under Mandriva 2008.0 (cooker)
CCBUGS: 148930


 M  +4 -0      lcmsprf.h  


--- trunk/extragear/graphics/digikam/libs/lprof/lcmsprf.h #703176:703177
 @ -68,6 +68,10  @
 
     } MATN,FAR* LPMATN;
 
+// See B.K.O #148930: compile with lcms v.1.17
+#if (LCMS_VERSION > 116)
+typedef LCMSBOOL BOOL;
+#endif
 
 LPMATN      cdecl MATNalloc(int Rows, int Cols);
 void        cdecl MATNfree (LPMATN mat);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148930         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2007-08-22 09:03 -------
SVN commit 703199 by cgilles:

digiKam from KDE3 branch : patch from Angelo Naselli about to compile digiKam with lcms 1.17. Tested under Mandriva 2007.1 and 2008.0 (cooker)
BUG: 148930


 M  +4 -0      lcmsprf.h  


--- branches/extragear/kde3/graphics/digikam/libs/lprof/lcmsprf.h #703198:703199
 @ -69,6 +69,10  @
 
     } MATN,FAR* LPMATN;
 
+// See B.K.O #148930: compile with lcms v.1.17
+#if (LCMS_VERSION > 116)
+typedef LCMSBOOL BOOL;
+#endif
 
 LPMATN      cdecl MATNalloc(int Rows, int Cols);
 void        cdecl MATNfree (LPMATN mat);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel