[Bug 148621] New: Image rotation not working properly

[Martin Reitbauer]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         
           Summary: Image rotation not working properly
           Product: digikam
           Version: 0.9.1
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: m.reitbauer gmx net


Version:           0.9.1 (using KDE 3.5.6, Kubuntu (feisty) 4:3.5.6-0ubuntu14)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.20-16-generic

When I'm in the image browser, and I right-click a thumbnail/image and select "Rotate", the rotation values are not as expected.

"Rotate 90" rotates 180 degrees
"Rotate 180" doesn't do anything at all
"Rotate 270" rotates 180 degrees

The strange part is that after I've performed two operations (getting wrong results), from the third time on everything works as it should, for that specific file. But the first two attempts always fail. I've tried only with jpegs.

I'm not sure whether this is digikam proper or digikam image plugins, but i think it's the former. When I open a file in the digikam image editor, everything works fine in terms of rotating things.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From arnd.baecker web de  2007-08-21 21:09 -------
Could you please try 0.9.2 and report back.
If I remember correctly, some images rotation issues
were fixed with that release
(see http://www.digikam.org/?q=download/binary/).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Reitbauer]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From m.reitbauer gmx net  2007-08-22 21:47 -------
thank you, arnd. it's working fine in 0.9.2; i guess you can close the ticket.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From arnd.baecker web de  2007-08-22 23:52 -------
Thanks a lot for the feedback! Closing this bug as fixed.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From w.posche gmx net  2007-08-27 21:07 -------
I am using the newest digikam version of the openSUSE backports repository (0.9.2-29.1) and I still have a similar problem. Rotating left or right always rotates the images 180°. When I do it a second time, though, it rotates 90° or 270° as it is supposed to.

So this bug doesn't seem to be resolved.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From caulier.gilles gmail com  2007-08-27 21:14 -------
Jens,

Rotation is handle using Exif informations. Try to use the last stable release of Exiv2 library on your computer.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From gsking1 gmail com  2007-09-01 01:13 -------
I am having the same problem.  Using 0.9.3-svn(yesterday) and libs from svn also.  exiv2 is 0.14.

If I rotate 'right' it goes 180 degrees.  If I rotate 'left' it rotates 90 degress counterclockwise as expected (but usually only on the second click). After a few clicks on the photo, rotation then behaves as expected.

This may have something to do with the original orientation since it is different for portrait and landscape.

If rotate normal landscape orientation to right:  rotates 90 clockwise (as expected)
If rotate portrait/vertical orientation to right: rotates 180 degrees.
If rotate portrait/vertical orientation to left: rotates 90 degrees counterclockwise as expected, but have to click twice.

It seems to happen only on pictures from my Canon SD450.  I have done limited testing of other cameras (Canon S45 and Canon Rebel XT plus various other files) and they seem okay.

Some examples from the SD450 camera can be found here..
http://bacon.no-ip.info/digikam/

Geoff
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From gsking1 gmail com  2007-09-01 02:28 -------
As a followup -
It does happen with photos from other cameras (my 2 other Canons).
This problem appears limited to pictures with initial portrait/vertical orientation.

Also tried exiv2 0.15 and still same problem.

A .diff of the output from 2 files is also on the website which might provide some insight. The one labeled rotated was rotated a few times and put back to the initial layout.

Hope this helps.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From marcel.wiesweg gmx de  2007-09-01 12:35 -------
Created an attachment (id=21520)
 --> (http://bugs.kde.org/attachment.cgi?id=21520&action=view)
Removing some code that might break rotation

I remember I had some similar problems a long time ago, and I have found this
changes here in my KDE3 svn version. Please try if it fixes your problem. I
cannot remember the details of the problem anymore.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From marcel.wiesweg gmx de  2007-09-01 12:35 -------
Forgot to mention, the directory to apply this patch is kipi-plugins/jpeglossless
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Geoff King-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         




------- Additional Comments From gsking1 gmail com  2007-09-01 21:31 -------
Your patch solved the problem. It is working as expected now. Thanks.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |



------- Additional Comments From arnd.baecker web de  2007-09-01 21:56 -------
Thanks for the feedback - I re-open this bug until the
patch is commited (and backported to KDE4).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |jpeglossless
            Product|digikam                     |kipiplugins
            Version|0.9.1                       |unspecified
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=148621         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From marcel.wiesweg gmx de  2007-09-02 15:26 -------
SVN commit 707626 by mwiesweg:

If the image had already an exif rotation flag set, this code part would cause
this taken into account twice, add the JPEG specific code does its own
sophisticated checking with matrix multiplication.

BUG: 148621


 M  +8 -0      actionthread.cpp  


--- branches/extragear/kde3/libs/kipi-plugins/jpeglossless/actionthread.cpp #707625:707626
 @ -77,6 +77,13  @
     {
         KIPI::ImageInfo info = m_interface->info( *it );
 
+        /*
+        Removing this code:
+         - for JPEGs, jpegtransform is using the Exiv2Iface and matrix multiplication
+           to compute the mathematically correct rotation (taking flip operations into account,
+           the code below only angles). Metadata tag is reset.
+         - For ImageMagick, no metadata is taken into account, and no metadata is changed!
+           Angle from host application still applies.
         // Don't use the host angle in case of auto-rotation (Rot0)
         if (val != Rot0)
         {
 @ -105,6 +112,7  @
             else
                 val = Rot0;
         }
+        */
 
         Task *t      = new Task;
         t->filePath  = QDeepCopy<QString>((*it).path()); //deep copy
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel