[Bug 147439] New: It is too easy to delete a search

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] New: It is too easy to delete a search

Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         
           Summary: It is too easy to delete a search
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: Searches
        AssignedTo: digikam-devel kde org
        ReportedBy: arnd.baecker web de


Version:            (using KDE KDE 3.5.5)
Installed from:    Compiled From Sources
OS:                Linux

Deleting a user-defined search is too easy.
Because there is no undo this
destroys a complicated advanced search unrecoverably.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         




------- Additional Comments From arnd.baecker web de  2007-07-02 01:07 -------
Created an attachment (id=21011)
 --> (http://bugs.kde.org/attachment.cgi?id=21011&action=view)
introduce warningYesNo before deleting
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Arnd Baecker
In reply to this post by Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         




------- Additional Comments From arnd.baecker web de  2007-08-30 15:38 -------
Gilles, what about this patch, may I apply it
(just checked that it still compiles and works)?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Gilles Caulier-4
In reply to this post by Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         




------- Additional Comments From caulier.gilles gmail com  2007-08-30 15:42 -------
Arnd,

Fine for me. Let's go

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Arnd Baecker
In reply to this post by Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From arnd.baecker web de  2007-08-30 15:50 -------
SVN commit 706464 by abaecker:

Add Yes/No Warning when deleting a search to avoid accidental removal of complex searches.
BUG: 147439


 M  +13 -0     searchfolderview.cpp  


--- branches/extragear/kde3/graphics/digikam/digikam/searchfolderview.cpp #706463:706464
 @ -35,6 +35,7  @
 #include <kglobal.h>
 #include <kiconloader.h>
 #include <kdeversion.h>
+#include <kmessagebox.h>
 
 #if KDE_IS_VERSION(3,2,0)
 #include <kinputdialog.h>
 @ -270,6 +271,18  @
     if (!album)
         return;
 
+    // Make sure that a complicated search is not deleted accidentally
+    int result =KMessageBox::warningYesNo( this, i18n("Are you sure you want to "
+                                                      "delete the selected search "
+                                                      "\"%1\"?")
+                                           .arg(album->title()),
+                                       i18n("Delete Search?"),
+                                       i18n("Delete"),
+                                       KStdGuiItem::cancel() );
+
+    if (result != KMessageBox::Yes)
+        return;
+
     AlbumManager::instance()->deleteSAlbum(album);
 }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Gilles Caulier-4
In reply to this post by Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From caulier.gilles gmail com  2007-08-30 15:53 -------
Arnd,

Warning. This patch much be backported to KDE4 implementation. Do not close it yet (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 147439] It is too easy to delete a search

Gilles Caulier-4
In reply to this post by Arnd Baecker
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=147439         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2007-08-30 16:00 -------
backported to KDE4 with commit #706466

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel