digiKam › digikam-devel

[Bug 120736] New: many imageplugins going busy for ever when not using rubber to change a value

Classic

List

10 messages Options

Options

Wennael Lemonnier

[Bug 120736] New: many imageplugins going busy for ever when not using rubber to change a value

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736
Summary: many imageplugins going busy for ever when not using
rubber to change a value
Product: digikam
Version: 0.8.1
Platform: unspecified
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
AssignedTo: digikam-devel kde org
ReportedBy: no_spam_please p0w org

Version: 0.8.1 (using KDE 3.4.0, compiled sources)
Compiler: gcc version 3.2.3
OS: Linux (i686) release 2.6.13.3

This bug can be reproduced in many imagePlugins of the Digikam Image Editor.

Open an image in the digiKam Image Editor and choose a 'Fix' effect, like Unsharp Mask.
change a value by typing into the input box the new value, don't use the rubber.
then, click the OK button without hitting the enter key.
the progress bar will stay at 95% and after closing the plugin dialog, the cursor still remain in busy state, until I close digiKam.

This bug has been reproduced by some people on the FreeNode IRC channel...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Werner Erselina

[Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From werner erselina nl 2006-01-24 23:01 -------
I can confirm this bug as it is described by Wennael Lemonnier. I am using kde 3.5 and digikam 0.81.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From caulier.gilles free fr 2006-01-25 08:05 -------
SVN commit 502187 by cgilles:

digikam from trunk : do not render preview effect if final rendering is already in progress in image.
CCBUG: 120736

M +3 -1 digikam/libs/dialogs/ctrlpaneldlg.cpp
M +3 -1 digikam/libs/dialogs/imageguidedlg.cpp
M +3 -1 digikamimageplugins/common/dialogs/ctrlpaneldialog.cpp
M +3 -1 digikamimageplugins/common/dialogs/imageguidedialog.cpp

--- trunk/extragear/graphics/digikam/libs/dialogs/ctrlpaneldlg.cpp #502186:502187
@ -280,7 +280,9 @
void CtrlPanelDlg::slotEffect()
{
// Computation already in process.
- if (d->currentRenderingMode == CtrlPanelDlgPriv::PreviewRendering) return;
+ if (d->currentRenderingMode == CtrlPanelDlgPriv::PreviewRendering ||
+ d->currentRenderingMode == CtrlPanelDlgPriv::FinalRendering)
+ return;

d->currentRenderingMode = CtrlPanelDlgPriv::PreviewRendering;

--- trunk/extragear/graphics/digikam/libs/dialogs/imageguidedlg.cpp #502186:502187
@ -364,7 +364,9 @
void ImageGuideDlg::slotEffect()
{
// Computation already in process.
- if (d->currentRenderingMode == ImageGuideDlgPriv::PreviewRendering) return;
+ if (d->currentRenderingMode == ImageGuideDlgPriv::PreviewRendering ||
+ d->currentRenderingMode == ImageGuideDlgPriv::FinalRendering)
+ return;

d->currentRenderingMode = ImageGuideDlgPriv::PreviewRendering;

--- trunk/extragear/graphics/digikamimageplugins/common/dialogs/ctrlpaneldialog.cpp #502186:502187
@ -235,7 +235,9 @
void CtrlPanelDialog::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;

m_currentRenderingMode = PreviewRendering;

--- trunk/extragear/graphics/digikamimageplugins/common/dialogs/imageguidedialog.cpp #502186:502187
@ -313,7 +313,9 @
void ImageGuideDialog::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;

m_currentRenderingMode = PreviewRendering;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From caulier.gilles free fr 2006-01-25 08:05 -------
SVN commit 502188 by cgilles:

digikam from stable : do not render preview effect if final rendering is already in progress in image.
CCBUG: 120736

M +3 -1 imageeffect_blur.cpp
M +4 -2 imageeffect_sharpen.cpp

--- branches/stable/extragear/graphics/digikam/imageplugins/imageeffect_blur.cpp #502187:502188
@ -191,7 +191,9 @
void ImageEffect_Blur::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;

m_currentRenderingMode = PreviewRendering;

--- branches/stable/extragear/graphics/digikam/imageplugins/imageeffect_sharpen.cpp #502187:502188
@ -191,8 +191,10 @
void ImageEffect_Sharpen::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
-
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;
+
m_currentRenderingMode = PreviewRendering;

m_imagePreviewWidget->setEnable(false);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From caulier.gilles free fr 2006-01-25 08:06 -------
SVN commit 502189 by cgilles:

digikam from stable : do not render preview effect if final rendering is already in progress in image.
CCBUG: 120736

M +4 -2 ctrlpaneldialog.cpp
M +4 -2 imageguidedialog.cpp

--- branches/stable/extragear/graphics/digikamimageplugins/common/dialogs/ctrlpaneldialog.cpp #502188:502189
@ -240,8 +240,10 @
void CtrlPanelDialog::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
-
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;
+
m_currentRenderingMode = PreviewRendering;

m_imagePreviewWidget->setEnable(false);
--- branches/stable/extragear/graphics/digikamimageplugins/common/dialogs/imageguidedialog.cpp #502188:502189
@ -313,8 +313,10 @
void ImageGuideDialog::slotEffect()
{
// Computation already in process.
- if (m_currentRenderingMode == PreviewRendering) return;
-
+ if (m_currentRenderingMode == PreviewRendering ||
+ m_currentRenderingMode == FinalRendering)
+ return;
+
m_currentRenderingMode = PreviewRendering;

enableButton(Ok, false);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736
caulier.gilles free fr changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED

------- Additional Comments From caulier.gilles free fr 2006-01-25 08:08 -------
Accordinly with you from IRC channel, all work fine now.
I close this file now. Thanks you for this report !

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from ach@mpe.mpg.de

[Digikam-devel] [Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736
ach mpe mpg de changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ach mpe mpg de
Status|RESOLVED |UNCONFIRMED
Resolution|FIXED |
Version|0.8.1 |unspecified

------- Additional Comments From ach mpe mpg de 2006-04-20 01:20 -------
I can't confirm this with todays stable svn (0.8.2-beta1 rc tarball):

o start IE
o select unshark mask
o set radius to 25 (via keyboard, only typed '2' so 5.0 -> 25.0)
o click on okay (with the mouse)

==> progress went up to 100% but mouse cursor was still
the busy cursor. Closing dialog, closing IE did not help,
busy cursor used until digikam was closed.

Achim
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Digikam-devel] [Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From caulier.gilles free fr 2006-04-20 10:00 -------
This problem is relevant of common dialog implementation from DigikamImagePlugins, not digiKam itself. Please update DigikamImagePlugins and try again.

Nota : in 0.9.0, all dialogs are common and available only in digiKam core. This way limit code dupplication.

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from ach@mpe.mpg.de

[Digikam-devel] [Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736

------- Additional Comments From ach mpe mpg de 2006-04-25 00:56 -------
Oh, I tested with digikamimageplugins 0.8.0 not 0.8.1.
0.8.1 fixes it.

Sorry for the confusion
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from ach@mpe.mpg.de

[Digikam-devel] [Bug 120736] many imageplugins going busy for ever when not using rubber to change a value

In reply to this post by Wennael Lemonnier

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=120736
ach mpe mpg de changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED

------- Additional Comments From ach mpe mpg de 2006-04-25 00:57 -------
*** Bug has been marked as fixed ***.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel