------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 Summary: digikam requires at least libpng >= 1.2.7 Product: digikam Version: unspecified Platform: Compiled Sources OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general AssignedTo: digikam-devel kde org ReportedBy: alfons.hoogervorst gmail com Version: CVS (using KDE Devel) Installed from: Compiled sources Compiler: gcc 3.3.1 compiled from sources OS: Linux Hiya, Latest digiKam from svn didn't build on my system, with libpng 1.2.5. Since recently digiKam uses png_set_add_alpha(), which was introduced in libpng 1.2.7 (cursory glance at the png changelog). The attached patch fixes it in a straight forward way by telling the compiler to use a newer libpng. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 ------- Additional Comments From alfons.hoogervorst gmail com 2005-11-28 19:58 ------- Created an attachment (id=13666) --> (http://bugs.kde.org/attachment.cgi?id=13666&action=view) Require a png version that has png_set_add_alpha _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 ------- Additional Comments From caulier.gilles free fr 2005-11-28 22:51 ------- SVN commit 483962 by cgilles: patch from alfons hoogervorst: digikam 0.9.0 requires at least libpng >= 1.2.7 CCBUG: 117225 M +10 -0 configure.in.bot M +15 -0 configure.in.in --- trunk/extragear/graphics/digikam/configure.in.bot #483961:483962 @ -72,6 +72,16 @ echo "-- libtiff found.................. YES" fi +if test "x$have_png" != "xyes"; then + echo "-- libpng found................... NO" + echo "" + echo "digiKam needs libpng. You need to install the correct version (>= 1.2.7)." + echo "" + all_tests=bad +else + echo "-- libpng found................... YES" +fi + if test "x$have_lcms" != "xyes"; then echo "-- lcms found..................... NO" echo "" --- trunk/extragear/graphics/digikam/configure.in.in #483961:483962 @ -251,6 +251,21 @ fi #------------------------------------------------------------------ +# Check for libpng with png_set_add_alpha() function +#------------------------------------------------------------------ + +have_png=no +KDE_CHECK_LIB(png, png_set_add_alpha, + have_png=yes, + AC_MSG_WARN([digiKam requires libpng >= 1.2.7]), + -lpng -lz -lm) + +if test "x$have_png" != "xyes"; then + AC_WARN([digiKam requires libpng >= 1.2.7; digiKam will not be compiled.]) + DO_NOT_COMPILE="digikam digikamimageplugins $DO_NOT_COMPILE" +fi + +#------------------------------------------------------------------ # Check for lcms (backported from krita) #------------------------------------------------------------------ _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 caulier.gilles free fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From caulier.gilles free fr 2005-11-28 22:58 ------- Thanks for this patch Alfons. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 rdieter math unl edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter math unl edu ------- Additional Comments From rdieter math unl edu 2005-11-29 17:32 ------- Would it be possible to make the alpha support, ie, the calls to png_set_add_alpha() that require libpng >= 1.2.7, optional? Else, you'll be locking out a lot of users (of older distributions). _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 ------- Additional Comments From caulier.gilles free fr 2005-11-29 18:24 ------- perhaps if i have more time because i'm very busy with digiKam core actually. If anyone can provide a patch... Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 ------- Additional Comments From rdieter math unl edu 2005-11-29 18:30 ------- Wouldn't it be as easy as replacing every png_set_add_alpha() with something like: #if (PNG_LIBPNG_VER_MAJOR >= 1 ) && (PNG_LIBPNG_VER_MINOR >= 2) && (PNG_LIBPNG_VER_RELEASE >= 7) png_set_add_alpha() #endif #define PNG_LIBPNG_VER_MAJOR 1 #define PNG_LIBPNG_VER_MINOR 2 #define PNG_LIBPNG_VER_RELEASE 8 _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Alfons Hoogervorst
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=117225 ------- Additional Comments From caulier.gilles free fr 2005-11-29 18:34 ------- Well, it's easy to make patch (:=))) I'm busy on other digiKam part... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |