Another possible factorization in libkdcraw...

[Gilles Caulier-4]

Andi,

Look like with KDE4, we have duplicates implementations :

from digiKam core : http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/squeezedcombobox.cpp?revision=727772&view=markup

from kipi-plugins core : http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/common/libkipiplugins/squeezedcombobox.cpp?revision=816159&view=markup

It's the same implementation. only namespace changes.

The best candidate to host this common widget is libkdcraw. Also, we can use it in libkdcraw instead QComboBox/KComboBox. Of course, all place in digiKam/kipi-plugins which use squeezedcombobox must be adapted to use KDCraw namespace and header.

But we must don't use this widget at other place, because regression tests need to be done, and it can take a while.

To resume, the widget is the same than q QComboxo excepted that it squezze long combo text to prevent huge layout in gui.

Best

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

So right now we should move it to libkdcraw and replace all sqeezeboxes
defined in digikam and kipi-plugins? ... ok.
I can do that.
If this is done, I will also use it for libkdcraw. The rest could be discussed
later when we think that the widget is needed in more places.

Andi


On Tuesday 21 October 2008 10:00:48 Gilles Caulier wrote:

> Andi,
>
> Look like with KDE4, we have duplicates implementations :
>
> from digiKam core :
> http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/
>squeezedcombobox.cpp?revision=727772&view=markup
>
> from kipi-plugins core :
> http://websvn.kde.org/trunk/extragear/graphics/kipi-plugins/common/libkipip
>lugins/squeezedcombobox.cpp?revision=816159&view=markup
>
> It's the same implementation. only namespace changes.
>
> The best candidate to host this common widget is libkdcraw. Also, we can
> use it in libkdcraw instead QComboBox/KComboBox. Of course, all place in
> digiKam/kipi-plugins which use squeezedcombobox must be adapted to use
> KDCraw namespace and header.
>
> But we must don't use this widget at other place, because regression tests
> need to be done, and it can take a while.
>
> To resume, the widget is the same than q QComboxo excepted that it squezze
> long combo text to prevent huge layout in gui.
>
> Best
>
> Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/10/21 Andi Clemens <[hidden email]>

So right now we should move it to libkdcraw and replace all sqeezeboxes
defined in digikam and kipi-plugins? ... ok.

yes.
 

I can do that.
If this is done, I will also use it for libkdcraw. The rest could be discussed
later when we think that the widget is needed in more places.

yes.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Ok I moved the squeezedbox to libkdcraw and modified digikam and kipi-plugins.
But there is some problem now: When quitting digiKam (or another host
application), KIPI::SideShow will crash. I'm not sure why so maybe you or
some other KIPI developer can have a look at this?

Andi


On Tuesday 21 October 2008 12:46:39 Gilles Caulier wrote:

> 2008/10/21 Andi Clemens <[hidden email]>
>
> > So right now we should move it to libkdcraw and replace all sqeezeboxes
> > defined in digikam and kipi-plugins? ... ok.
>
> yes.
>
> > I can do that.
> > If this is done, I will also use it for libkdcraw. The rest could be
> > discussed
> > later when we think that the widget is needed in more places.
>
> yes.
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

martedì 21 ottobre 2008 alle 10:00, Gilles Caulier ha scritto:
> The best candidate to host this common widget is libkdcraw. Also, we can use
> it in libkdcraw instead QComboBox/KComboBox.

Are you going to break abi again?

I can understand we're in beta and not in stable one, but you've already asked for
some backports to distros, if it happens again i believe some (mandriva 2009.0 for instance)
can't compile the final and that would be a bad thing since digikam is not very usable
as beta3...

My 2 € cents,
        Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/10/21, Angelo Naselli <[hidden email]>:

martedì 21 ottobre 2008 alle 10:00, Gilles Caulier ha scritto:

> The best candidate to host this common widget is libkdcraw. Also, we can use
> it in libkdcraw instead QComboBox/KComboBox.


Are you going to break abi again?

I can understand we're in beta and not in stable one, but you've already asked for
some backports to distros, if it happens again i believe some (mandriva 2009.0 for instance)
can't compile the final and that would be a bad thing since digikam is not very usable
as beta3...

Code fixed is in trunk. there is no BC compatibility broken. this version will be released with KDE 4.2

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

martedì 21 ottobre 2008 alle 14:33, Andi Clemens ha scritto:
> Ok I moved the squeezedbox to libkdcraw and modified digikam and kipi-plugins.
> But there is some problem now: When quitting digiKam (or another host
> application), KIPI::SideShow will crash. I'm not sure why so maybe you or
> some other KIPI developer can have a look at this?

Maybe just move to kde-imaging the discussion ;)

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Uhh I guess I was too fast now...
Right we break ABI with this. Well we can revert it and save the patches for
later commits.

Andi


On Tuesday 21 October 2008 14:35:01 Angelo Naselli wrote:

> martedì 21 ottobre 2008 alle 10:00, Gilles Caulier ha scritto:
> > The best candidate to host this common widget is libkdcraw. Also, we can
> > use it in libkdcraw instead QComboBox/KComboBox.
>
> Are you going to break abi again?
>
> I can understand we're in beta and not in stable one, but you've already
> asked for some backports to distros, if it happens again i believe some
> (mandriva 2009.0 for instance) can't compile the final and that would be a
> bad thing since digikam is not very usable as beta3...
>
> My 2 € cents,
> Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/10/21, Andi Clemens <[hidden email]>:

Ok I moved the squeezedbox to libkdcraw and modified digikam and kipi-plugins.
But there is some problem now: When quitting digiKam (or another host
application), KIPI::SideShow will crash. I'm not sure why so maybe you or
some other KIPI developer can have a look at this?

Any suitable backtrace ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Oh right, I always forget that libkdcraw and others are in KDE now.

Andi

On Tuesday 21 October 2008 14:37:54 Gilles Caulier wrote:

> 2008/10/21, Angelo Naselli <[hidden email]>:
> > martedì 21 ottobre 2008 alle 10:00, Gilles Caulier ha scritto:
> > > The best candidate to host this common widget is libkdcraw. Also, we
> > > can
> >
> > use
> >
> > > it in libkdcraw instead QComboBox/KComboBox.
> >
> > Are you going to break abi again?
> >
> > I can understand we're in beta and not in stable one, but you've already
> > asked for
> > some backports to distros, if it happens again i believe some (mandriva
> > 2009.0 for instance)
> > can't compile the final and that would be a bad thing since digikam is
> > not very usable
> > as beta3...
>
> Code fixed is in trunk. there is no BC compatibility broken. this version
> will be released with KDE 4.2
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

It seems to crash while deleting the sharedData in SlideShow's destructor:

#0  0xa9593733 in ~Plugin_SlideShow (this=0xdb53bb0)
at /home/andi/Programmieren/workspace/digikam_KDE4/kipi-plugins/slideshow/plugin_slideshow.cpp:111
#1  0xb7ea4e5d in QObjectPrivate::deleteChildren ()
from /usr/lib/libQtCore.so.4
#2  0xb7eace4c in QObject::~QObject () from /usr/lib/libQtCore.so.4
#3  0xb6cdd885 in ~Interface (this=0xdb0eb08)
at /home/andi/Programmieren/workspace/libs_KDE4/libs/libkipi/libkipi/interface.cpp:134
#4  0x0818390c in ~KipiInterface (this=0xdb0eb08)
at /home/andi/Programmieren/workspace/digikam_KDE4/digikam/utilities/kipiiface/kipiinterface.cpp:73
#5  0xb7ea4e5d in QObjectPrivate::deleteChildren ()
from /usr/lib/libQtCore.so.4
#6  0xb60d8a0f in QWidget::~QWidget () from /usr/lib/libQtGui.so.4
#7  0xb63dd7e2 in QMainWindow::~QMainWindow () from /usr/lib/libQtGui.so.4
#8  0xb7a48dba in KMainWindow::~KMainWindow () from /usr/lib/libkdeui.so.5
#9  0xb7a8b288 in KXmlGuiWindow::~KXmlGuiWindow () from /usr/lib/libkdeui.so.5
#10 0x08260f1e in ~DigikamApp (this=0x9e61720)
at /home/andi/Programmieren/workspace/digikam_KDE4/digikam/digikam/digikamapp.cpp:270
#11 0xb7ea4b1c in qDeleteInEventHandler () from /usr/lib/libQtCore.so.4
#12 0xb7ea652b in QObject::event () from /usr/lib/libQtCore.so.4
#13 0xb60da5f7 in QWidget::event () from /usr/lib/libQtGui.so.4
#14 0xb63ddf4f in QMainWindow::event () from /usr/lib/libQtGui.so.4
#15 0xb7a48238 in KMainWindow::event () from /usr/lib/libkdeui.so.5
#16 0xb7a8c1dd in KXmlGuiWindow::event () from /usr/lib/libkdeui.so.5
#17 0xb6087eac in QApplicationPrivate::notify_helper ()
from /usr/lib/libQtGui.so.4
#18 0xb608e4fa in QApplication::notify () from /usr/lib/libQtGui.so.4
#19 0xb7975e9e in KApplication::notify () from /usr/lib/libkdeui.so.5
#20 0xb7e97f60 in QCoreApplication::notifyInternal ()
from /usr/lib/libQtCore.so.4
#21 0xb7e988e0 in QCoreApplicationPrivate::sendPostedEvents ()
from /usr/lib/libQtCore.so.4
#22 0xb7e98a7e in QCoreApplication::sendPostedEvents ()
from /usr/lib/libQtCore.so.4
#23 0xb7ebf090 in ?? () from /usr/lib/libQtCore.so.4
#24 0x00000000 in ?? ()

Andi

On Tuesday 21 October 2008 14:39:13 Gilles Caulier wrote:

> 2008/10/21, Andi Clemens <[hidden email]>:
> > Ok I moved the squeezedbox to libkdcraw and modified digikam and
> > kipi-plugins.
> > But there is some problem now: When quitting digiKam (or another host
> > application), KIPI::SideShow will crash. I'm not sure why so maybe you or
> > some other KIPI developer can have a look at this?
>
> Any suitable backtrace ?
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

martedì 21 ottobre 2008 alle 14:37, Gilles Caulier ha scritto:
> Code fixed is in trunk. there is no BC compatibility broken. this version
> will be released with KDE 4.2
>
> Gilles

Yes but you are going to use that in digikam beta5 or whatelse will be.
And that means no one can backport beta5 into kde 4.1.x stable that is inside
most distros.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/10/21, Andi Clemens <[hidden email]>:

Oh right, I always forget that libkdcraw and others are in KDE now.

no. there is no problem to play with trunk code. We only take a care with KDE 4.1 branch about binary compatibility

Like digiKam and kipi-plugins depand of kdegraphics/libs from trunk, it's not a problem for the moment... else, we can stop to develop now...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

I remember a similar crash in the pass. it's relevant of SlideShow Code. Angelo ?

Gilles

2008/10/21, Andi Clemens <[hidden email]>:

It seems to crash while deleting the sharedData in SlideShow's destructor:

#0  0xa9593733 in ~Plugin_SlideShow (this=0xdb53bb0)
at /home/andi/Programmieren/workspace/digikam_KDE4/kipi-plugins/slideshow/plugin_slideshow.cpp:111
#1  0xb7ea4e5d in QObjectPrivate::deleteChildren ()
from /usr/lib/libQtCore.so.4
#2  0xb7eace4c in QObject::~QObject () from /usr/lib/libQtCore.so.4
#3  0xb6cdd885 in ~Interface (this=0xdb0eb08)
at /home/andi/Programmieren/workspace/libs_KDE4/libs/libkipi/libkipi/interface.cpp:134
#4  0x0818390c in ~KipiInterface (this=0xdb0eb08)
at /home/andi/Programmieren/workspace/digikam_KDE4/digikam/utilities/kipiiface/kipiinterface.cpp:73
#5  0xb7ea4e5d in QObjectPrivate::deleteChildren ()
from /usr/lib/libQtCore.so.4
#6  0xb60d8a0f in QWidget::~QWidget () from /usr/lib/libQtGui.so.4
#7  0xb63dd7e2 in QMainWindow::~QMainWindow () from /usr/lib/libQtGui.so.4
#8  0xb7a48dba in KMainWindow::~KMainWindow () from /usr/lib/libkdeui.so.5
#9  0xb7a8b288 in KXmlGuiWindow::~KXmlGuiWindow () from /usr/lib/libkdeui.so.5
#10 0x08260f1e in ~DigikamApp (this=0x9e61720)
at /home/andi/Programmieren/workspace/digikam_KDE4/digikam/digikam/digikamapp.cpp:270
#11 0xb7ea4b1c in qDeleteInEventHandler () from /usr/lib/libQtCore.so.4
#12 0xb7ea652b in QObject::event () from /usr/lib/libQtCore.so.4
#13 0xb60da5f7 in QWidget::event () from /usr/lib/libQtGui.so.4
#14 0xb63ddf4f in QMainWindow::event () from /usr/lib/libQtGui.so.4
#15 0xb7a48238 in KMainWindow::event () from /usr/lib/libkdeui.so.5
#16 0xb7a8c1dd in KXmlGuiWindow::event () from /usr/lib/libkdeui.so.5
#17 0xb6087eac in QApplicationPrivate::notify_helper ()
from /usr/lib/libQtGui.so.4
#18 0xb608e4fa in QApplication::notify () from /usr/lib/libQtGui.so.4
#19 0xb7975e9e in KApplication::notify () from /usr/lib/libkdeui.so.5
#20 0xb7e97f60 in QCoreApplication::notifyInternal ()
from /usr/lib/libQtCore.so.4
#21 0xb7e988e0 in QCoreApplicationPrivate::sendPostedEvents ()
from /usr/lib/libQtCore.so.4
#22 0xb7e98a7e in QCoreApplication::sendPostedEvents ()
from /usr/lib/libQtCore.so.4
#23 0xb7ebf090 in ?? () from /usr/lib/libQtCore.so.4
#24 0x00000000 in ?? ()


Andi


On Tuesday 21 October 2008 14:39:13 Gilles Caulier wrote:
> 2008/10/21, Andi Clemens <[hidden email]>:
> > Ok I moved the squeezedbox to libkdcraw and modified digikam and
> > kipi-plugins.
> > But there is some problem now: When quitting digiKam (or another host
> > application), KIPI::SideShow will crash. I'm not sure why so maybe you or
> > some other KIPI developer can have a look at this?
>
> Any suitable backtrace ?
>
> Gilles


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

martedì 21 ottobre 2008 alle 14:56, Gilles Caulier ha scritto:

> 2008/10/21, Andi Clemens <[hidden email]>:
> >
> > Oh right, I always forget that libkdcraw and others are in KDE now.
>
>
> no. there is no problem to play with trunk code. We only take a care with
> KDE 4.1 branch about binary compatibility
>
> Like digiKam and kipi-plugins depand of kdegraphics/libs from trunk, it's
> not a problem for the moment... else, we can stop to develop now...
>
> Gilles
>

No problem with trunk of course. But why don't pospon this issue alter?
I mean that code could be added into libkdcraw, but compiled into
kipi-plugins and digikam in old way until 0.10.0 is out, same for kipi-plugins.

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel