wavelet denoising

[Johannes Wienke-3]

Hi,

just a short question: is there a wavelet denoising filter in the image
editor?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Hi Johannes

There is no Wavelets denoising in editor as a dedicated tool, but look
in RAW Import tool : libkdcraw/libraw provide one to pre-process RAW
files during demosaicing...

I know that we have aen entry in Bugzilla about to add a Wavelets denoise tool.

Gilles

2009/11/18, Johannes Wienke <[hidden email]>:

> Hi,
>
>  just a short question: is there a wavelet denoising filter in the image
> editor?
>
>  Johannes
>
>
> _______________________________________________
>  Digikam-devel mailing list
>  [hidden email]
>  https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Johannes,

If you is interrested to backport this wavelets filter from libraw to
a new tool for editor through a new DImg method, take a look here :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libraw/internal/dcraw_common.cpp#2994

Another pointer is Krita wavelets denoise tool :

http://lxr.kde.org/source/koffice/krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp#65

Gilles

2009/11/18 Gilles Caulier <[hidden email]>:

> Hi Johannes
>
> There is no Wavelets denoising in editor as a dedicated tool, but look
> in RAW Import tool : libkdcraw/libraw provide one to pre-process RAW
> files during demosaicing...
>
> I know that we have aen entry in Bugzilla about to add a Wavelets denoise tool.
>
> Gilles
>
> 2009/11/18, Johannes Wienke <[hidden email]>:
>> Hi,
>>
>>  just a short question: is there a wavelet denoising filter in the image
>> editor?
>>
>>  Johannes
>>
>>
>> _______________________________________________
>>  Digikam-devel mailing list
>>  [hidden email]
>>  https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-2]

Hi Gilles,

Am 18.11.2009 16:26 schrieb Gilles Caulier:
> If you is interrested to backport this wavelets filter from libraw to
> a new tool for editor through a new DImg method, take a look here :
>
> http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libraw/internal/dcraw_common.cpp#2994
>
> Another pointer is Krita wavelets denoise tool :
>
> http://lxr.kde.org/source/koffice/krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp#65

I don't think I have the time to do this while also porting to model view.

Just as a remark to the links you gave: both of the filter there don't
support what I really liked about the GIMP (I didn't wanna say that ;) )
plugin I tested. There you have different thresholds for each color
channel, supporting various color representations etc. That is really
handy for different noise and image types.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/11/18 Johannes Wienke <[hidden email]>:

> Hi Gilles,
>
> Am 18.11.2009 16:26 schrieb Gilles Caulier:
>>
>> If you is interrested to backport this wavelets filter from libraw to
>> a new tool for editor through a new DImg method, take a look here :
>>
>>
>> http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libraw/internal/dcraw_common.cpp#2994
>>
>> Another pointer is Krita wavelets denoise tool :
>>
>>
>> http://lxr.kde.org/source/koffice/krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp#65
>
> I don't think I have the time to do this while also porting to model view.
>
> Just as a remark to the links you gave: both of the filter there don't
> support what I really liked about the GIMP (I didn't wanna say that ;) )
> plugin I tested. There you have different thresholds for each color channel,
> supporting various color representations etc. That is really handy for
> different noise and image types.
>

Can you give me some screenshots and links about this gimp tool ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Hi,

Am 18.11.2009 22:07 schrieb Gilles Caulier:
>> Just as a remark to the links you gave: both of the filter there don't
>> support what I really liked about the GIMP (I didn't wanna say that ;) )
>> plugin I tested. There you have different thresholds for each color channel,
>> supporting various color representations etc. That is really handy for
>> different noise and image types.
>>
>
> Can you give me some screenshots and links about this gimp tool ?

http://registry.gimp.org/node/4235

There are also Screenshots.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/11/18 Johannes Wienke <[hidden email]>:

> Hi,
>
> Am 18.11.2009 22:07 schrieb Gilles Caulier:
>>>
>>> Just as a remark to the links you gave: both of the filter there don't
>>> support what I really liked about the GIMP (I didn't wanna say that ;) )
>>> plugin I tested. There you have different thresholds for each color
>>> channel,
>>> supporting various color representations etc. That is really handy for
>>> different noise and image types.
>>>
>>
>> Can you give me some screenshots and links about this gimp tool ?
>
> http://registry.gimp.org/node/4235
>
> There are also Screenshots.
>
> Johannes
>

Just checking this code : it's very easy to use : wavelet denoise
algorithm use floating point format to play with image data. Code can
be used as well with Dimg.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Johannes,

I cannot resist to do it. It's really easy to make a tool with this
code... (:=)))

Also, it give nice result and is more easy to use than current digiKam
NR tool...

Gilles

2009/11/18 Gilles Caulier <[hidden email]>:

> 2009/11/18 Johannes Wienke <[hidden email]>:
>> Hi,
>>
>> Am 18.11.2009 22:07 schrieb Gilles Caulier:
>>>>
>>>> Just as a remark to the links you gave: both of the filter there don't
>>>> support what I really liked about the GIMP (I didn't wanna say that ;) )
>>>> plugin I tested. There you have different thresholds for each color
>>>> channel,
>>>> supporting various color representations etc. That is really handy for
>>>> different noise and image types.
>>>>
>>>
>>> Can you give me some screenshots and links about this gimp tool ?
>>
>> http://registry.gimp.org/node/4235
>>
>> There are also Screenshots.
>>
>> Johannes
>>
>
> Just checking this code : it's very easy to use : wavelet denoise
> algorithm use floating point format to play with image data. Code can
> be used as well with Dimg.
>
> Gilles
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Am 19.11.2009 10:05 schrieb Gilles Caulier:
> I cannot resist to do it. It's really easy to make a tool with this
> code... (:=)))

Great.

> Also, it give nice result and is more easy to use than current digiKam
> NR tool...

To be honest, I really don't understand all the options of the current
denoising tool.

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Algorithm compile now on my computer. GUI need to be done...

Gilles

2009/11/19 Johannes Wienke <[hidden email]>:

> Am 19.11.2009 10:05 schrieb Gilles Caulier:
>>
>> I cannot resist to do it. It's really easy to make a tool with this
>> code... (:=)))
>
> Great.
>
>> Also, it give nice result and is more easy to use than current digiKam
>> NR tool...
>
> To be honest, I really don't understand all the options of the current
> denoising tool.
>
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Johannes,

code is there :

http://websvn.kde.org/branches/work/~cgilles/noisereduction/

All compile fine. no crash. But it's doesn't work very well yet... We
need to hack

Gilles

2009/11/19 Gilles Caulier <[hidden email]>:

> Algorithm compile now on my computer. GUI need to be done...
>
> Gilles
>
> 2009/11/19 Johannes Wienke <[hidden email]>:
>> Am 19.11.2009 10:05 schrieb Gilles Caulier:
>>>
>>> I cannot resist to do it. It's really easy to make a tool with this
>>> code... (:=)))
>>
>> Great.
>>
>>> Also, it give nice result and is more easy to use than current digiKam
>>> NR tool...
>>
>> To be honest, I really don't understand all the options of the current
>> denoising tool.
>>
>> Johannes
>>
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Johanness !

Plugin is done. All compile and run fine with 8 OR 16 bits color depth images.

http://websvn.kde.org/branches/work/~cgilles/noisereduction/

I want a beer !

http://farm3.static.flickr.com/2541/4120824786_c606d3bac7_b.jpg
http://farm3.static.flickr.com/2635/4120068613_73d223d6a3_b.jpg

Please, test report and comment.

Question : we replace old denoise tool, or we add this one to old one
as option, like it's do with sharpen tool which merge 3 tools to one
(simple sharp, unsharp mask, refocus)

Gilles

2009/11/20 Gilles Caulier <[hidden email]>:

> Johannes,
>
> code is there :
>
> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>
> All compile fine. no crash. But it's doesn't work very well yet... We
> need to hack
>
> Gilles
>
> 2009/11/19 Gilles Caulier <[hidden email]>:
>> Algorithm compile now on my computer. GUI need to be done...
>>
>> Gilles
>>
>> 2009/11/19 Johannes Wienke <[hidden email]>:
>>> Am 19.11.2009 10:05 schrieb Gilles Caulier:
>>>>
>>>> I cannot resist to do it. It's really easy to make a tool with this
>>>> code... (:=)))
>>>
>>> Great.
>>>
>>>> Also, it give nice result and is more easy to use than current digiKam
>>>> NR tool...
>>>
>>> To be honest, I really don't understand all the options of the current
>>> denoising tool.
>>>
>>> Johannes
>>>
>>>
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> [hidden email]
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>
>>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[sean darcy]

Ok. Grabbed it. Built it. That worked.

So what parameters work? What is a ggod start?

sean

Gilles Caulier wrote:

> Johanness !
>
> Plugin is done. All compile and run fine with 8 OR 16 bits color depth images.
>
> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>
> I want a beer !
>
> http://farm3.static.flickr.com/2541/4120824786_c606d3bac7_b.jpg
> http://farm3.static.flickr.com/2635/4120068613_73d223d6a3_b.jpg
>
> Please, test report and comment.
>
> Question : we replace old denoise tool, or we add this one to old one
> as option, like it's do with sharpen tool which merge 3 tools to one
> (simple sharp, unsharp mask, refocus)
>
> Gilles
>
> 2009/11/20 Gilles Caulier <[hidden email]>:
>> Johannes,
>>
>> code is there :
>>
>> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>>
>> All compile fine. no crash. But it's doesn't work very well yet... We
>> need to hack
>>
>> Gilles
>>
>> 2009/11/19 Gilles Caulier <[hidden email]>:
>>> Algorithm compile now on my computer. GUI need to be done...
>>>
>>> Gilles
>>>
>>> 2009/11/19 Johannes Wienke <[hidden email]>:
>>>> Am 19.11.2009 10:05 schrieb Gilles Caulier:
>>>>> I cannot resist to do it. It's really easy to make a tool with this
>>>>> code... (:=)))
>>>> Great.
>>>>
>>>>> Also, it give nice result and is more easy to use than current digiKam
>>>>> NR tool...
>>>> To be honest, I really don't understand all the options of the current
>>>> denoising tool.
>>>>
>>>> Johannes
>>>>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Use SHIFT+F1 over settings to get help.

Gilles

2009/11/21 sean darcy <[hidden email]>:

> Ok. Grabbed it. Built it. That worked.
>
> So what parameters work? What is a ggod start?
>
> sean
>
> Gilles Caulier wrote:
>> Johanness !
>>
>> Plugin is done. All compile and run fine with 8 OR 16 bits color depth images.
>>
>> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>>
>> I want a beer !
>>
>> http://farm3.static.flickr.com/2541/4120824786_c606d3bac7_b.jpg
>> http://farm3.static.flickr.com/2635/4120068613_73d223d6a3_b.jpg
>>
>> Please, test report and comment.
>>
>> Question : we replace old denoise tool, or we add this one to old one
>> as option, like it's do with sharpen tool which merge 3 tools to one
>> (simple sharp, unsharp mask, refocus)
>>
>> Gilles
>>
>> 2009/11/20 Gilles Caulier <[hidden email]>:
>>> Johannes,
>>>
>>> code is there :
>>>
>>> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>>>
>>> All compile fine. no crash. But it's doesn't work very well yet... We
>>> need to hack
>>>
>>> Gilles
>>>
>>> 2009/11/19 Gilles Caulier <[hidden email]>:
>>>> Algorithm compile now on my computer. GUI need to be done...
>>>>
>>>> Gilles
>>>>
>>>> 2009/11/19 Johannes Wienke <[hidden email]>:
>>>>> Am 19.11.2009 10:05 schrieb Gilles Caulier:
>>>>>> I cannot resist to do it. It's really easy to make a tool with this
>>>>>> code... (:=)))
>>>>> Great.
>>>>>
>>>>>> Also, it give nice result and is more easy to use than current digiKam
>>>>>> NR tool...
>>>>> To be honest, I really don't understand all the options of the current
>>>>> denoising tool.
>>>>>
>>>>> Johannes
>>>>>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Hi Gilles,

now I had time to look at the new plugin.

Am 20.11.2009 23:05 schrieb Gilles Caulier:
> Plugin is done. All compile and run fine with 8 OR 16 bits color depth images.
>
> http://websvn.kde.org/branches/work/~cgilles/noisereduction/

Thanks for porting, looks good on a first sight.

> I want a beer !

A German one? ;)

> Please, test report and comment.

How much work would it be to provide the more sophisticated options of
the original code? Especially deciding how much denoising on each
channel should be done was something that I really liked about the gimp
version and that's not possible right now in your port.

If you want to prevent users from having too many options right after
starting the tool, we could think about using to tabs for the options: a
simple mode like it is now and an advanced mode, where you can specify
the settings for all the color channels.

One more minor thing I noticed: Right now there is a slider for
softness, but what it actually does is the opposite. If you move the
slider to the right the image is sharpened, not softened.

> Question : we replace old denoise tool, or we add this one to old one
> as option, like it's do with sharpen tool which merge 3 tools to one
> (simple sharp, unsharp mask, refocus)

Hm, I wouldn't miss the old tool too much. ;)

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Johannes,

All is done in svn, and ready to use. Enjoy...

Gilles

2009/11/21 Johannes Wienke <[hidden email]>:

> Hi Gilles,
>
> now I had time to look at the new plugin.
>
> Am 20.11.2009 23:05 schrieb Gilles Caulier:
>>
>> Plugin is done. All compile and run fine with 8 OR 16 bits color depth
>> images.
>>
>> http://websvn.kde.org/branches/work/~cgilles/noisereduction/
>
> Thanks for porting, looks good on a first sight.
>
>> I want a beer !
>
> A German one? ;)
>
>> Please, test report and comment.
>
> How much work would it be to provide the more sophisticated options of the
> original code? Especially deciding how much denoising on each channel should
> be done was something that I really liked about the gimp version and that's
> not possible right now in your port.
>
> If you want to prevent users from having too many options right after
> starting the tool, we could think about using to tabs for the options: a
> simple mode like it is now and an advanced mode, where you can specify the
> settings for all the color channels.
>
> One more minor thing I noticed: Right now there is a slider for softness,
> but what it actually does is the opposite. If you move the slider to the
> right the image is sharpened, not softened.
>
>> Question : we replace old denoise tool, or we add this one to old one
>> as option, like it's do with sharpen tool which merge 3 tools to one
>> (simple sharp, unsharp mask, refocus)
>
> Hm, I wouldn't miss the old tool too much. ;)
>
> Johannes
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Hi,

Am 25.11.2009 10:50 schrieb Gilles Caulier:
> All is done in svn, and ready to use. Enjoy...

Nice, but I think I found a bug concerning the preview. :\ In advanced
mode the settings are sometimes not applied to the preview. There is
some calculation but the generated image doesn't change. I don't
understand when and how this happens...

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel