specific KDE Version test in editorwindow.cpp

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

specific KDE Version test in editorwindow.cpp

Arnd Baecker
Hi,

in void EditorWindow::loadImagePlugins()
there is a very specific:
  #if KDE_IS_VERSION(4,1,68)
which makes use of
  QString categoryStr = plugin->actionCategory();

Does anyone know what the reason for this special case is
(and whether it is really necessary?)?

And if yes, shouldn't then the include at the beginning be
encapsulated as well, i.e.:
#if KDE_IS_VERSION(4,1,68)
   #include <kactioncategory.h>
#endif
?
(Background info: I neither have KDE 4.1.68, nor kactioncategory.h,
so the compile failed for me; commenting `#include <kactioncategory.h>`
out got me a bit further ...;-) )

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: specific KDE Version test in editorwindow.cpp

Bugzilla from andi.clemens@gmx.net
I added this to have grouping of actions in the shortcut editor. You are
right, the include must be enclosed as well, I forgot that.
Will add this now!

Andi Clemens
-----------------
www.digikam.org

On Saturday 12 December 2009 18:25:28 Arnd Baecker wrote:

> Hi,
>
> in void EditorWindow::loadImagePlugins()
> there is a very specific:
>   #if KDE_IS_VERSION(4,1,68)
> which makes use of
>   QString categoryStr = plugin->actionCategory();
>
> Does anyone know what the reason for this special case is
> (and whether it is really necessary?)?
>
> And if yes, shouldn't then the include at the beginning be
> encapsulated as well, i.e.:
> #if KDE_IS_VERSION(4,1,68)
>    #include <kactioncategory.h>
> #endif
> ?
> (Background info: I neither have KDE 4.1.68, nor kactioncategory.h,
> so the compile failed for me; commenting `#include <kactioncategory.h>`
> out got me a bit further ...;-) )
>
> Best, Arnd
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: specific KDE Version test in editorwindow.cpp

Bugzilla from andi.clemens@gmx.net
BTW Arnd,
this macro doesn't mean : "Use exactly this version", it means "check if KDE
has at least this version", because in this version the categories have been
added.

I have fixed trunk now...

Andi Clemens
-----------------
www.digikam.org

On Saturday 12 December 2009 19:54:50 Andi Clemens wrote:

> I added this to have grouping of actions in the shortcut editor. You are
> right, the include must be enclosed as well, I forgot that.
> Will add this now!
>
> Andi Clemens
> -----------------
> www.digikam.org
>
> On Saturday 12 December 2009 18:25:28 Arnd Baecker wrote:
> > Hi,
> >
> > in void EditorWindow::loadImagePlugins()
> > there is a very specific:
> >   #if KDE_IS_VERSION(4,1,68)
> > which makes use of
> >   QString categoryStr = plugin->actionCategory();
> >
> > Does anyone know what the reason for this special case is
> > (and whether it is really necessary?)?
> >
> > And if yes, shouldn't then the include at the beginning be
> > encapsulated as well, i.e.:
> > #if KDE_IS_VERSION(4,1,68)
> >    #include <kactioncategory.h>
> > #endif
> > ?
> > (Background info: I neither have KDE 4.1.68, nor kactioncategory.h,
> > so the compile failed for me; commenting `#include <kactioncategory.h>`
> > out got me a bit further ...;-) )
> >
> > Best, Arnd
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel