sidebar width

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

sidebar width

Johannes Wienke-3
Hi,

can anyone else confirm that the width of the editor sidebar is not
restored anymore?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Marcel Wiesweg

>
> can anyone else confirm that the width of the editor sidebar is not
> restored anymore?

No problem visible here, after some attempts.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Johannes Wienke-3
Am 06.02.2010 15:16 schrieb Marcel Wiesweg:
>
>>
>> can anyone else confirm that the width of the editor sidebar is not
>> restored anymore?
>
> No problem visible here, after some attempts.

Hm, ok, strange. I think this is since I switched the application
language from German to English. Maybe some translated value...

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Gilles Caulier-4
2010/2/6 Johannes Wienke <[hidden email]>:

> Am 06.02.2010 15:16 schrieb Marcel Wiesweg:
>>
>>>
>>> can anyone else confirm that the width of the editor sidebar is not
>>> restored anymore?
>>
>> No problem visible here, after some attempts.
>
> Hm, ok, strange. I think this is since I switched the application
> language from German to English. Maybe some translated value...

Same side effect in when i switch from English to French

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Johannes Wienke-3
Am 06.02.2010 17:33 schrieb Gilles Caulier:

> 2010/2/6 Johannes Wienke <[hidden email]>:
>> Am 06.02.2010 15:16 schrieb Marcel Wiesweg:
>>>
>>>>
>>>> can anyone else confirm that the width of the editor sidebar is not
>>>> restored anymore?
>>>
>>> No problem visible here, after some attempts.
>>
>> Hm, ok, strange. I think this is since I switched the application
>> language from German to English. Maybe some translated value...
>
> Same side effect in when i switch from English to French
I tried to find this bug but didn't succeed.  What is the code in
EditorWindow starting at 960 supposed to do? Is this strange comparison
with the magic number still needed?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Marcel Wiesweg

> I tried to find this bug but didn't succeed.  What is the code in
> EditorWindow starting at 960 supposed to do? Is this strange comparison
> with the magic number still needed?

Looks like config upgrade. It's written by Pieter Edelman who did some work
with dock windows.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Johannes Wienke-3
In reply to this post by Gilles Caulier-4
Am 06.02.2010 17:33 schrieb Gilles Caulier:

> 2010/2/6 Johannes Wienke <[hidden email]>:
>> Am 06.02.2010 15:16 schrieb Marcel Wiesweg:
>>>
>>>>
>>>> can anyone else confirm that the width of the editor sidebar is not
>>>> restored anymore?
>>>
>>> No problem visible here, after some attempts.
>>
>> Hm, ok, strange. I think this is since I switched the application
>> language from German to English. Maybe some translated value...
>
> Same side effect in when i switch from English to French
Ok, I think I found the problem or misunderstanding:
The width that was chosen when an editor tool is active, is not used for
restoring the sidebar width. Instead it's the width of a tab that exists
without an editor tool. Eg:
1. open a non-raw file in the editor
2. open the image properties tab and make the sidebar as fill half the
screen
3. close the properties tab
4. open an editor tool (it opens with the size chosen in step 2 - what I
expect)
5. in the tool mode make the sidebar smaller again
6. close the tool
7. try opening the properties tab again

First of all you have to click the tab icon two times (most likely not
desired). Second, the sidebar is restored with the size specified in
step 2, not the last one. This also happens if you replace step 7 with
opening another editor tool.

Is this the desired behaviour? I was really surprised by this and it
took weeks for me to understand the system. ;)

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Marcel Wiesweg

> Ok, I think I found the problem or misunderstanding:
> The width that was chosen when an editor tool is active, is not used for
> restoring the sidebar width. Instead it's the width of a tab that exists
> without an editor tool. Eg:
> 1. open a non-raw file in the editor
> 2. open the image properties tab and make the sidebar as fill half the
> screen
> 3. close the properties tab
> 4. open an editor tool (it opens with the size chosen in step 2 - what I
> expect)
> 5. in the tool mode make the sidebar smaller again
> 6. close the tool
> 7. try opening the properties tab again
>
> First of all you have to click the tab icon two times (most likely not
> desired). Second, the sidebar is restored with the size specified in
> step 2, not the last one. This also happens if you replace step 7 with
> opening another editor tool.
>
> Is this the desired behaviour? I was really surprised by this and it
> took weeks for me to understand the system. ;)

Yes. Typically you will have set your sidebar to a convenient size for work.
Image plugins tend to need more vertical space than standard sidebars. So when
a plugin's sidebar is added, the current setting is stored, when the tab is
removed, it is restored.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Johannes Wienke-3
Am 11.04.2010 20:49 schrieb Marcel Wiesweg:

>
>> Ok, I think I found the problem or misunderstanding:
>> The width that was chosen when an editor tool is active, is not used for
>> restoring the sidebar width. Instead it's the width of a tab that exists
>> without an editor tool. Eg:
>> 1. open a non-raw file in the editor
>> 2. open the image properties tab and make the sidebar as fill half the
>> screen
>> 3. close the properties tab
>> 4. open an editor tool (it opens with the size chosen in step 2 - what I
>> expect)
>> 5. in the tool mode make the sidebar smaller again
>> 6. close the tool
>> 7. try opening the properties tab again
>>
>> First of all you have to click the tab icon two times (most likely not
>> desired). Second, the sidebar is restored with the size specified in
>> step 2, not the last one. This also happens if you replace step 7 with
>> opening another editor tool.
>>
>> Is this the desired behaviour? I was really surprised by this and it
>> took weeks for me to understand the system. ;)
>
> Yes. Typically you will have set your sidebar to a convenient size for work.
> Image plugins tend to need more vertical space than standard sidebars. So when
> a plugin's sidebar is added, the current setting is stored, when the tab is
> removed, it is restored.
But I have no chance to set a typical size for editor tools now. They
always open with the (small) size for the normal sidebar and every time
I use them I first have to resize them. Otherwise I see eg. a vertical
scroll bar in the raw import.

What about adding a restored size setting for all tools or even on a
tool basis as each tool needs another size?

Johannes


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (270 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sidebar width

Marcel Wiesweg

>
> But I have no chance to set a typical size for editor tools now. They
> always open with the (small) size for the normal sidebar and every time
> I use them I first have to resize them. Otherwise I see eg. a vertical
> scroll bar in the raw import.
>
> What about adding a restored size setting for all tools or even on a
> tool basis as each tool needs another size?

Yes, the system can be improved ;-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel