[showfoto] [Bug 343013] New: on working with raw images marked square isn't crop accurate

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

            Bug ID: 343013
           Summary: on working with raw images marked square isn't crop
                    accurate
           Product: showfoto
           Version: 4.4.0
          Platform: openSUSE RPMs
               URL: http://grossing.org/temp/showfoto.mp4
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

When working with an image in raw format e.g. .cr2 or .arw the marked square
isn't cut accurate at the marking lines.


Reproducible: Always

Steps to Reproduce:
1. start showfoto
2. load an .cr2 e.g. http://grossing.org/temp/IMG_8249.CR2
3. mark an area
4. Press Ctrl-x or use Transform -> crop

Actual Results:  
There is something near the marked square cropped, but not exact the marked
area, see linked movie

Expected Results:  
crop at the marked square

Tested with versions 4.4.0 and 4.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor
                 CC|                            |[hidden email]
            Product|showfoto                    |digikam
            Summary|on working with raw images  |CANVAS : on working with
                   |marked square isn't crop    |raw images marked square
                   |accurate                    |isn't crop accurate

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Problably fixed with last 4.6.0 release by Maik Qualmann...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Florian,

RAW or JPEG as no difference with crop tool. Can you try with a JPEG file to
see if it's reproducible ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #3 from Florian Gross <[hidden email]> ---
I'll try. At the moment i couldn't reproduce the problem wheater with JPEG nor
RAW

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Yes, here is a problem with the (CR2?) RAW images. The first cut after the load
is wrong. After undo everything is ok. I think the attribute "originalSize", in
this RAW Image not set correctly when loading.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #5 from Maik Qualmann <[hidden email]> ---
After an initial review, I see the bug in libkdcraw. When a RAW image in
portrait mode (even with my Nikon NEF) the width and height of the image is
reversed in the libkdcraw container. An old Fujifilm RAW has a completely wrong
size. I think we will be installing a workaround for now.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Maik,

The RAW image size is not get from libkdcraw, but from libkexiv2, if i
remember.

libkdcraw (libraw in fact in background) is used only for RAW files not
supported by Exiv2.

It's possible that a confusion is done by Exiv2 with TIFF/EP based RAW files.
There are a lots of tags dedicated to manage image size.

Florian, did you use RawImport tool in editor, or you load RAW file directly as
with JPEG ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #7 from Florian Gross <[hidden email]> ---
(In reply to Gilles Caulier from comment #6)

> Florian, did you use RawImport tool in editor, or you load RAW file directly
> as with JPEG ?

I copied the RAW files via card reader from a sd card. No import functions were
used

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #8 from Gilles Caulier <[hidden email]> ---
I talk about RAW Import tool from _Image Editor_. Look in Setup dialog...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #9 from Florian Gross <[hidden email]> ---
(In reply to Gilles Caulier from comment #8)
> I talk about RAW Import tool from _Image Editor_. Look in Setup dialog...

Oh sorry. I translate from the german dialog: fast and easy as 8bit. I hope
this helps, otherwise i have to look for some pictures with the english dialog

flo

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #10 from Gilles Caulier <[hidden email]> ---
So, you don't use Import Tool.

Try to check if Import tool made a difference here

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #11 from Florian Gross <[hidden email]> ---
The first try: http://grossing.org/temp/IMG_8249_imp1.jpg
the second try: http://grossing.org/temp/IMG_8249_imp2.jpg

cropped area is much deferred in comparison to the marked area

flo

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Florian Gross]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #12 from Florian Gross <[hidden email]> ---
the marked areas right end is the right end of the red stripe

flo

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #13 from Maik Qualmann <[hidden email]> ---
Created attachment 90522
  --> https://bugs.kde.org/attachment.cgi?id=90522&action=edit
originalsize.patch

This patch fixes the problem with the RAW files when loading. And I have the IF
statements removed from my patch, are not required.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CANVAS : on working with    |CANVAS : on working with
                   |raw images marked square    |raw images marked square
                   |isn't crop accurate         |isn't crop accurate [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/76657579a2101a0c721544d
                   |                            |a238a24ec4a195e92
   Version Fixed In|                            |4.7.0

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Git commit 76657579a2101a0c721544da238a24ec4a195e92 by Gilles Caulier.
Committed on 22/01/2015 at 10:15.
Pushed by cgilles into branch 'master'.

Apply patch #90522 from MAik Qualmann to fix stored original RAW image size
loaded in Image Editor
FIXED-IN: 4.7.0

M  +2    -1    NEWS
M  +1    -0    utilities/imageeditor/core/editorcore.cpp
M  +2    -10   utilities/imageeditor/core/editorcore_p.h

http://commits.kde.org/digikam/76657579a2101a0c721544da238a24ec4a195e92

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=343013

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Git commit 3b2a9baaf5afd64a8ac1c45bb9491450df643f11 by Gilles Caulier.
Committed on 22/01/2015 at 10:24.
Pushed by cgilles into branch 'frameworks'.

backport patch #76657579a2101a0c721544da238a24ec4a195e92 from git/master to
frameworks branch

M  +1    -16   utilities/imageeditor/core/editorcore.cpp
M  +3    -11   utilities/imageeditor/core/editorcore_p.h

http://commits.kde.org/digikam/3b2a9baaf5afd64a8ac1c45bb9491450df643f11

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=343013

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ImageEditor                 |ImageEditor-Canvas

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel