regarding my assigned bug

[Saurabh Patel]

Hello,
    I was able to test the patch: http://git.reviewboard.kde.org/r/108382/ assigned to me.It worked fine.Also it focuses on tree view in right sidebar as you already mentioned Gilles.Also in menubar Tag in digikam there is no shortcut option seen.In other words it's a cached keyboard shortcut not visible to users.I also had a question Markus:I had 2 previous tags panda and panda kung fu, until 4th word panda kung fu was the first option then when it reached 5th word panda became the first option and then after 5th word panda kung fu became first option.Shouldn't first option be panda until 5th word if it is sorted and then panda kung fu.

Yes it's better than previously available option in which whole word had to be typed and is a good feature which every user would like and this feature should be added.Also shortcut made visible is different topic and could be implemnted differently but this sort of auto-completion feature is must.

Also,tell what should I try to do with this patch.

Thanks
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kusi]

Hello Saurabh

 

Thanks for testing the patch!

 

I assume you mean "character" instead of "word". And I assume you assigned first "Panda", then "Panda Kung Fu" previously. So "Panda Kung Fu" is the most recent item in the list, therefore "Panda Kung Fu" appears first (case A, see code). It only changes to "Panda" after we get an exact match of an item with the entered text (case C), and after the 6th charachter it becomes again "Panda Kung Fu", because this is the first item in the most-recent-list and we don't have an exact match between usertext and items anymore. So the behavior is as intended.

 

The shortcut is made visible to the user via the keyboard shortcut menu ("assign tag"). I agree we could make it more visible to the user (ideas: via status bar like its done in Gimp, or via tip-of-the-day, any other ideas?). But I don't think is's a good idea to expose the shortcut via mouse context menu: the idea for this shortcut is NOT to use the mouse.

 

The one feature which is nowhere explained to the user: when you press the enter key TWICE after assigning a tag (while the tageditbox is focussed), the main iconview is again focussed, and the next image is selected. Any ideas how to make that feature obvious to the user?

 

best, Markus

 

 

On Tuesday 05 March 2013 22.44:51 Saurabh Patel wrote:

Hello,
    I was able to test the patch: http://git.reviewboard.kde.org/r/108382/ assigned to me.It worked fine.Also it focuses on tree view in right sidebar as you already mentioned Gilles.Also in menubar Tag in digikam there is no shortcut option seen.In other words it's a cached keyboard shortcut not visible to users.I also had a question Markus:I had 2 previous tags panda and panda kung fu, until 4th word panda kung fu was the first option then when it reached 5th word panda became the first option and then after 5th word panda kung fu became first option.Shouldn't first option be panda until 5th word if it is sorted and then panda kung fu.

Yes it's better than previously available option in which whole word had to be typed and is a good feature which every user would like and this feature should be added.Also shortcut made visible is different topic and could be implemnted differently but this sort of auto-completion feature is must.

Also,tell what should I try to do with this patch.

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Saurabh Patel]

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.
    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.
    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

Thnx

On Wed, Mar 6, 2013 at 3:41 AM, Markus Leuthold <[hidden email]> wrote:

Hello Saurabh

 

Thanks for testing the patch!

 

I assume you mean "character" instead of "word". And I assume you assigned first "Panda", then "Panda Kung Fu" previously. So "Panda Kung Fu" is the most recent item in the list, therefore "Panda Kung Fu" appears first (case A, see code). It only changes to "Panda" after we get an exact match of an item with the entered text (case C), and after the 6th charachter it becomes again "Panda Kung Fu", because this is the first item in the most-recent-list and we don't have an exact match between usertext and items anymore. So the behavior is as intended.

 

The shortcut is made visible to the user via the keyboard shortcut menu ("assign tag"). I agree we could make it more visible to the user (ideas: via status bar like its done in Gimp, or via tip-of-the-day, any other ideas?). But I don't think is's a good idea to expose the shortcut via mouse context menu: the idea for this shortcut is NOT to use the mouse.

 

The one feature which is nowhere explained to the user: when you press the enter key TWICE after assigning a tag (while the tageditbox is focussed), the main iconview is again focussed, and the next image is selected. Any ideas how to make that feature obvious to the user?

 

best, Markus

 

 

On Tuesday 05 March 2013 22.44:51 Saurabh Patel wrote:

Hello,
    I was able to test the patch: http://git.reviewboard.kde.org/r/108382/ assigned to me.It worked fine.Also it focuses on tree view in right sidebar as you already mentioned Gilles.Also in menubar Tag in digikam there is no shortcut option seen.In other words it's a cached keyboard shortcut not visible to users.I also had a question Markus:I had 2 previous tags panda and panda kung fu, until 4th word panda kung fu was the first option then when it reached 5th word panda became the first option and then after 5th word panda kung fu became first option.Shouldn't first option be panda until 5th word if it is sorted and then panda kung fu.

Yes it's better than previously available option in which whole word had to be typed and is a good feature which every user would like and this feature should be added.Also shortcut made visible is different topic and could be implemnted differently but this sort of auto-completion feature is must.

Also,tell what should I try to do with this patch.

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Saurabh Patel]

Hello,
    It's long time since any body has replied to what should I do with the bug I have been assigned.I have already tested it and told about suggestions and problem in my previous mails and problems were even clarified so what should I do with this bug.Or should I start to search for other bug  in bugs list and try solving it.

I have been assigned keyboard tagging improvement bug on this link:
http://community.kde.org/Digikam/GSoC2013#Small_Projects_to_Introduce_Students

Thanks

On Wed, Mar 6, 2013 at 10:42 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.
    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.
    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

Thnx

On Wed, Mar 6, 2013 at 3:41 AM, Markus Leuthold <[hidden email]> wrote:

Hello Saurabh

 

Thanks for testing the patch!

 

I assume you mean "character" instead of "word". And I assume you assigned first "Panda", then "Panda Kung Fu" previously. So "Panda Kung Fu" is the most recent item in the list, therefore "Panda Kung Fu" appears first (case A, see code). It only changes to "Panda" after we get an exact match of an item with the entered text (case C), and after the 6th charachter it becomes again "Panda Kung Fu", because this is the first item in the most-recent-list and we don't have an exact match between usertext and items anymore. So the behavior is as intended.

 

The shortcut is made visible to the user via the keyboard shortcut menu ("assign tag"). I agree we could make it more visible to the user (ideas: via status bar like its done in Gimp, or via tip-of-the-day, any other ideas?). But I don't think is's a good idea to expose the shortcut via mouse context menu: the idea for this shortcut is NOT to use the mouse.

 

The one feature which is nowhere explained to the user: when you press the enter key TWICE after assigning a tag (while the tageditbox is focussed), the main iconview is again focussed, and the next image is selected. Any ideas how to make that feature obvious to the user?

 

best, Markus

 

 

On Tuesday 05 March 2013 22.44:51 Saurabh Patel wrote:

Hello,
    I was able to test the patch: http://git.reviewboard.kde.org/r/108382/ assigned to me.It worked fine.Also it focuses on tree view in right sidebar as you already mentioned Gilles.Also in menubar Tag in digikam there is no shortcut option seen.In other words it's a cached keyboard shortcut not visible to users.I also had a question Markus:I had 2 previous tags panda and panda kung fu, until 4th word panda kung fu was the first option then when it reached 5th word panda became the first option and then after 5th word panda kung fu became first option.Shouldn't first option be panda until 5th word if it is sorted and then panda kung fu.

Yes it's better than previously available option in which whole word had to be typed and is a good feature which every user would like and this feature should be added.Also shortcut made visible is different topic and could be implemnted differently but this sort of auto-completion feature is must.

Also,tell what should I try to do with this patch.

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

Hi Saurabh

Mostly, people in open source have their own full time jobs and priorities to be taken care of. So kindly forgive us if we are not able to respond promptly. That being said, you can start looking at bugs.kde.org, and start going through the bugs for kipi plugins, particularly export ones. This will help you in understanding the structure in which they are written. Understand the flow, inheritances, signal-slotting, how data is passed private, etc.

On Mon, Mar 11, 2013 at 10:44 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
    It's long time since any body has replied to what should I do with the bug I have been assigned.I have already tested it and told about suggestions and problem in my previous mails and problems were even clarified so what should I do with this bug.Or should I start to search for other bug  in bugs list and try solving it.

I have been assigned keyboard tagging improvement bug on this link:
http://community.kde.org/Digikam/GSoC2013#Small_Projects_to_Introduce_Students

Thanks

On Wed, Mar 6, 2013 at 10:42 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.
    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.
    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

Thnx

On Wed, Mar 6, 2013 at 3:41 AM, Markus Leuthold <[hidden email]> wrote:

Hello Saurabh

 

Thanks for testing the patch!

 

I assume you mean "character" instead of "word". And I assume you assigned first "Panda", then "Panda Kung Fu" previously. So "Panda Kung Fu" is the most recent item in the list, therefore "Panda Kung Fu" appears first (case A, see code). It only changes to "Panda" after we get an exact match of an item with the entered text (case C), and after the 6th charachter it becomes again "Panda Kung Fu", because this is the first item in the most-recent-list and we don't have an exact match between usertext and items anymore. So the behavior is as intended.

 

The shortcut is made visible to the user via the keyboard shortcut menu ("assign tag"). I agree we could make it more visible to the user (ideas: via status bar like its done in Gimp, or via tip-of-the-day, any other ideas?). But I don't think is's a good idea to expose the shortcut via mouse context menu: the idea for this shortcut is NOT to use the mouse.

 

The one feature which is nowhere explained to the user: when you press the enter key TWICE after assigning a tag (while the tageditbox is focussed), the main iconview is again focussed, and the next image is selected. Any ideas how to make that feature obvious to the user?

 

best, Markus

 

 

On Tuesday 05 March 2013 22.44:51 Saurabh Patel wrote:

Hello,
    I was able to test the patch: http://git.reviewboard.kde.org/r/108382/ assigned to me.It worked fine.Also it focuses on tree view in right sidebar as you already mentioned Gilles.Also in menubar Tag in digikam there is no shortcut option seen.In other words it's a cached keyboard shortcut not visible to users.I also had a question Markus:I had 2 previous tags panda and panda kung fu, until 4th word panda kung fu was the first option then when it reached 5th word panda became the first option and then after 5th word panda kung fu became first option.Shouldn't first option be panda until 5th word if it is sorted and then panda kung fu.

Yes it's better than previously available option in which whole word had to be typed and is a good feature which every user would like and this feature should be added.Also shortcut made visible is different topic and could be implemnted differently but this sort of auto-completion feature is must.

Also,tell what should I try to do with this patch.

Thanks

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

--
Smit Mehta
Junior year, B.Tech
Computer Science and Engineering
IIT Madras
[phone]

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2013/3/6 Saurabh Patel <[hidden email]>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.

You can patch tips of day content of course...

 

    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.

patch need to be tested on my computer.

 

    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

3.1.0 release will be done soon. After that, a tableview branch will be merged to git/master. Patch much be adapted to this branch to compile fine.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Saurabh Patel]

Hello,
     I tried to add tip of day for my assigned tag in digikam-software-compilation/core/data/Tips.html then I build digikam again using bootstrap.local,make,make install and tried to see if tip I added was visible in tip of day after running digikam but I was not able to see the tip I added.
Plz tell whether I am testing it correctly or not and also let me know if that tip is to be added somewhere also which might be problem.

Thanks

On Mon, Mar 11, 2013 at 11:46 AM, Gilles Caulier <[hidden email]> wrote:

2013/3/6 Saurabh Patel <[hidden email]>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.

You can patch tips of day content of course...

 

    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.

patch need to be tested on my computer.

 

    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

3.1.0 release will be done soon. After that, a tableview branch will be merged to git/master. Patch much be adapted to this branch to compile fine.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Saurabh Patel]

Hello,

    I recently got digikam 3.2.0 beta installed and saw that a sort of tool tip similar to tip required by this patch is already there with only difference that instead of pressing enter twice it requires pressing enter and then page down to assign tag to the image so it's just change of shortcut key.Also auto-completion feature based on alphabetical and most recently added tags is implemented as done by this patch so what further is to be done with this bug or should it be closed.

When I was assigned this bug it was already implemented and had only to be tested which I have tested.

Thanks

On Tue, Mar 12, 2013 at 10:48 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
     I tried to add tip of day for my assigned tag in digikam-software-compilation/core/data/Tips.html then I build digikam again using bootstrap.local,make,make install and tried to see if tip I added was visible in tip of day after running digikam but I was not able to see the tip I added.
Plz tell whether I am testing it correctly or not and also let me know if that tip is to be added somewhere also which might be problem.

Thanks

On Mon, Mar 11, 2013 at 11:46 AM, Gilles Caulier <[hidden email]> wrote:

2013/3/6 Saurabh Patel <[hidden email]>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.

You can patch tips of day content of course...

 

    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.

patch need to be tested on my computer.

 

    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

3.1.0 release will be done soon. After that, a tableview branch will be merged to git/master. Patch much be adapted to this branch to compile fine.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Saurabh Patel]

Hello,

   As Gilles pointed out in his previous reply,this patch needs to be tested on digikam 3 where a tableview branch would be merged.

So I tested this patch on digikam 3.2.0 beta.This patch didn't work at all.

First pressing T doesn't open Tags section from rightsidebar.

Then autocompletion of tags as suggested by Markus doesn't work.It remains same for digikam after applying patch the code.

Eg:Say I added tag 'abcde' and then tag 'abcdef' so according to patch 'abcdef' should be seen above 'abcde' in autocompletion since it is more recent but 'abcde' appears first in autocompletion than 'abcdef'

I had tested this on digikam 2 where this patch worked as Markus thought but now in digikam 3.2.0 beta it doesn't work

So kindly look into it

Thanks

On Tue, Apr 2, 2013 at 8:02 PM, Saurabh Patel <[hidden email]> wrote:

Hello,

    I recently got digikam 3.2.0 beta installed and saw that a sort of tool tip similar to tip required by this patch is already there with only difference that instead of pressing enter twice it requires pressing enter and then page down to assign tag to the image so it's just change of shortcut key.Also auto-completion feature based on alphabetical and most recently added tags is implemented as done by this patch so what further is to be done with this bug or should it be closed.

When I was assigned this bug it was already implemented and had only to be tested which I have tested.

Thanks

On Tue, Mar 12, 2013 at 10:48 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
     I tried to add tip of day for my assigned tag in digikam-software-compilation/core/data/Tips.html then I build digikam again using bootstrap.local,make,make install and tried to see if tip I added was visible in tip of day after running digikam but I was not able to see the tip I added.
Plz tell whether I am testing it correctly or not and also let me know if that tip is to be added somewhere also which might be problem.

Thanks

On Mon, Mar 11, 2013 at 11:46 AM, Gilles Caulier <[hidden email]> wrote:

2013/3/6 Saurabh Patel <[hidden email]>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.

You can patch tips of day content of course...

 

    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.

patch need to be tested on my computer.

 

    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

3.1.0 release will be done soon. After that, a tableview branch will be merged to git/master. Patch much be adapted to this branch to compile fine.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Kusi]

Hello Saurabh

 

The patch works fine with current HEAD from today (after rebasing), I just tested it. Pressing T focusses the editbox, the sorting works as intended with the patch. You probably forgot to rebase?

 

I've added a "tip of the day" to make the feature visible to the user.

 

best, Markus

 

 

 

On Tuesday 09 April 2013 02.14:37 Saurabh Patel wrote:

Hello,

   As Gilles pointed out in his previous reply,this patch needs to be tested on digikam 3 where a tableview branch would be merged.

So I tested this patch on digikam 3.2.0 beta.This patch didn't work at all.

First pressing T doesn't open Tags section from rightsidebar.

Then autocompletion of tags as suggested by Markus doesn't work.It remains same for digikam after applying patch the code.

Eg:Say I added tag 'abcde' and then tag 'abcdef' so according to patch 'abcdef' should be seen above 'abcde' in autocompletion since it is more recent but 'abcde' appears first in autocompletion than 'abcdef'

I had tested this on digikam 2 where this patch worked as Markus thought but now in digikam 3.2.0 beta it doesn't work

So kindly look into it

Thanks

On Tue, Apr 2, 2013 at 8:02 PM, Saurabh Patel <[hidden email]> wrote:

Hello,

    I recently got digikam 3.2.0 beta installed and saw that a sort of tool tip similar to tip required by this patch is already there with only difference that instead of pressing enter twice it requires pressing enter and then page down to assign tag to the image so it's just change of shortcut key.Also auto-completion feature based on alphabetical and most recently added tags is implemented as done by this patch so what further is to be done with this bug or should it be closed.

When I was assigned this bug it was already implemented and had only to be tested which I have tested.

Thanks

On Tue, Mar 12, 2013 at 10:48 AM, Saurabh Patel <[hidden email]> wrote:

Hello,
     I tried to add tip of day for my assigned tag in digikam-software-compilation/core/data/Tips.html then I build digikam again using bootstrap.local,make,make install and tried to see if tip I added was visible in tip of day after running digikam but I was not able to see the tip I added.
Plz tell whether I am testing it correctly or not and also let me know if that tip is to be added somewhere also which might be problem.

Thanks

On Mon, Mar 11, 2013 at 11:46 AM, Gilles Caulier <[hidden email]> wrote:

2013/3/6 Saurabh Patel <[hidden email]>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day would be a good idea rather than status bar because tip of the day are meant for providing tips which can make our work easy but not necessary to apply.

You can patch tips of day content of course...

 

    Regarding moving to next image after pressing enter twice,it seems difficult to be made obvious.Maybe along with the tip for the shortcut we could append this feature in tip.

patch need to be tested on my computer.

 

    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than testing.

3.1.0 release will be done soon. After that, a tableview branch will be merged to git/master. Patch much be adapted to this branch to compile fine.

Gilles Caulier

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel