patch for zooming with the

[Arnd Baecker]

Hi,

attached is a small patch for the previewwidget.cpp
which tries to keep the position under the mouse-pointer
fixed when using CTRL-mousewheel.

Overall it works fine, though it does not stay on
the point with pixel accuracy (sometimes it
jumps around a bit). I have no idea where this comes
from, either it is an error in the logic, or the way
the adjustment is made, or it has to do with
some internal behaviour of  the ``center`` function...

Gilles, maybe you could have a look at the patch
and give me some feed-back.
If you are interested, I would try to also implement this
for the ImageEditor itself.

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Thanks for your contrib Arnd. It very appreciate.

If you want to contrib again in the future, why not to take a svn account ?

I will take a look, but i want to finish in first the sync right/left panels implementation on Light Table (:=)))

Gilles

2007/5/8, Arnd Baecker <[hidden email]>:

Hi,

attached is a small patch for the previewwidget.cpp
which tries to keep the position under the mouse-pointer
fixed when using CTRL-mousewheel.

Overall it works fine, though it does not stay on
the point with pixel accuracy (sometimes it
jumps around a bit). I have no idea where this comes
from, either it is an error in the logic, or the way
the adjustment is made, or it has to do with
some internal behaviour of  the ``center`` function...

Gilles, maybe you could have a look at the patch
and give me some feed-back.
If you are interested, I would try to also implement this
for the ImageEditor itself.

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/5/8, Gilles Caulier <[hidden email]>:

Thanks for your contrib Arnd. It very appreciate.

If you want to contrib again in the future, why not to take a svn account ?

Look here :

http://techbase.kde.org/Contribute

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

Hi Gilles,

On Tue, 8 May 2007, Gilles Caulier wrote:

> 2007/5/8, Gilles Caulier <[hidden email]>:
> >
> > Thanks for your contrib Arnd. It very appreciate.
> >
> > If you want to contrib again in the future, why not to take a svn account
> > ?

thanks a lot for the offer - but at this point
it is better, if I do not accept it: I don't really speak C++
(all is just a combination of phrases from the code
put together in a different order, so - as always with foreign
languages - it is not always clear what the resulting meaning is ;-).
If it's ok for you, I will try to tackle from time to time
some small things,and just provide  patches for review
(which is definitively needed, see the next paragraph).

Actually, the posted patch has (apart from the zooming not working
as smoothly as I would like it to be) a bad side effect:
after using the zoom with CTRL-mousewheel, quitting the preview,
and trying to pre-view (F3) the same image again, one obtains:
"Cannot display preview for <image.jpg> ".
So obviously I screwed it up somehow...
(Moral: don't give me svn access right now ;-)

Best, Arnd

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Actually, the posted patch has (apart from the zooming not working
> as smoothly as I would like it to be) a bad side effect:
> after using the zoom with CTRL-mousewheel, quitting the preview,
> and trying to pre-view (F3) the same image again, one obtains:
> "Cannot display preview for <image.jpg> ".
> So obviously I screwed it up somehow...
> (Moral: don't give me svn access right now ;-)

This is not the fault of your patch!

>
> Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Marcel,

if you have review this patch please feel free to apply it on svn. I'm busy to finalize Light Table actually. Thanks in advance

Gilles

2007/5/8, Marcel Wiesweg < [hidden email]>:

> Actually, the posted patch has (apart from the zooming not working
> as smoothly as I would like it to be) a bad side effect:
> after using the zoom with CTRL-mousewheel, quitting the preview,
> and trying to pre-view (F3) the same image again, one obtains:
> "Cannot display preview for < image.jpg> ".
> So obviously I screwed it up somehow...
> (Moral: don't give me svn access right now ;-)

This is not the fault of your patch!

>
> Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

On Tue, 8 May 2007, Marcel Wiesweg wrote:

> > Actually, the posted patch has (apart from the zooming not working
> > as smoothly as I would like it to be) a bad side effect:
> > after using the zoom with CTRL-mousewheel, quitting the preview,
> > and trying to pre-view (F3) the same image again, one obtains:
> > "Cannot display preview for <image.jpg> ".
> > So obviously I screwed it up somehow...
> > (Moral: don't give me svn access right now ;-)
>
> This is not the fault of your patch!

Thanks ;-) - indeed I also get it right now
after a fresh recompile (without my patch).

Concerning the slight jumps when zooming with CTRL-mousewheel,
do you have an idea what could be causing this
(e.g. am I calling the ``center`` routine incorrectly?)

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel