maximal Thumbnail size

[Sebastian Bothe-2]

Hello,

  I`m new to digikam devel and I'm not sure if this is the right way- If not
please let me know.
 I wanted to change the maximal thumbnail size available with the new slider
in digikam. Taking a look a the sources it seems to me that it should be set
in thumnailsize.h - some hardcoded size values in thumnailjob and
digikamthumbnail keep it from working -

 I attach a patch which makes use of the size defined in thumbnailsize.h,  
which works for me- Perhaps someone with more knowledge on digikam can take a
look at it.

Thanks
Sebastian


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Sebastian,

I'm not agree with this patch. Why ? Because, supporting thumbnails largest than 256 will consume a lot of memory in pixmap cache manager and will slowdown digiKam.

Also, the thumnails size is standardized by freedesktop.org to be compatible between KDE, Gnome, etc. The max size is 256. The thumbs cache is saved on your hdd in your home directory and is shared by other applications.

To have a largest view of pictures, are you tried the preview mode (F3) ?

Gilles Caulier

2007/5/4, Sebastian Bothe <[hidden email]>:

Hello,

  I`m new to digikam devel and I'm not sure if this is the right way- If not
please let me know.
I wanted to change the maximal thumbnail size available with the new slider
in digikam. Taking a look a the sources it seems to me that it should be set
in thumnailsize.h - some hardcoded size values in thumnailjob and
digikamthumbnail keep it from working -

I attach a patch which makes use of the size defined in thumbnailsize.h,
which works for me- Perhaps someone with more knowledge on digikam can take a
look at it.

Thanks
Sebastian


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Sebastian Bothe-2]

Hello Gilles,

  thank you very much for your fast reply. I didn't know there is any
convention about thumb sizes and of course I don't want to brake it -
actually the patch I handed in does not change the defaults in
thumbnailsize.h it just uses the values given there at other places were the
max size is hardcoded in current svn.
  I'm using a 1600x1200er widescreen display and I like having two/three
thumbs in a row, so 256px are some kind of small ;-) This makes comparisons
between similar pictures more easy. Perhaps the new lighttable will be a
better way to do in future..
  Would you agree to use the sizes values from thumbnailsize.h and perhaps
hint for the restriction to max size of 256px there?

Sebastian

On Friday 04 May 2007 19:46:20 Gilles Caulier wrote:

> Sebastian,
>
> I'm not agree with this patch. Why ? Because, supporting thumbnails largest
> than 256 will consume a lot of memory in pixmap cache manager and will
> slowdown digiKam.
>
> Also, the thumnails size is standardized by freedesktop.org to be
> compatible between KDE, Gnome, etc. The max size is 256. The thumbs cache
> is saved on your hdd in your home directory and is shared by other
> applications.
>
> To have a largest view of pictures, are you tried the preview mode (F3) ?
>
> Gilles Caulier
>
> 2007/5/4, Sebastian Bothe <[hidden email]>:
> > Hello,
> >
> >   I`m new to digikam devel and I'm not sure if this is the right way- If
> > not
> > please let me know.
> > I wanted to change the maximal thumbnail size available with the new
> > slider
> > in digikam. Taking a look a the sources it seems to me that it should be
> > set
> > in thumnailsize.h - some hardcoded size values in thumnailjob and
> > digikamthumbnail keep it from working -
> >
> > I attach a patch which makes use of the size defined in thumbnailsize.h,
> > which works for me- Perhaps someone with more knowledge on digikam can
> > take a
> > look at it.
> >
> > Thanks
> > Sebastian
> >
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/5/4, Sebastian Bothe <[hidden email]>:

Hello Gilles,

  thank you very much for your fast reply. I didn't know there is any
convention about thumb sizes and of course I don't want to brake it -
actually the patch I handed in does not change the defaults in
thumbnailsize.h it just uses the values given there at other places were the
max size is hardcoded in current svn.
  I'm using a 1600x1200er widescreen display and I like having two/three
thumbs in a row, so 256px are some kind of small ;-) This makes comparisons
between similar pictures more easy. Perhaps the new lighttable will be a
better way to do in future..

(:=))... Really... like this :

http://digikam3rdparty.free.fr/Screenshots/lighttable_v3.png

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia sobota 05 maj 2007, Gilles Caulier napisał:
> Sebastian,
>
> I'm not agree with this patch. Why ? Because, supporting thumbnails
> largest than 256 will consume a lot of memory in pixmap cache manager
> and will slowdown digiKam.

I tried this patch with increased size of Huge in thumbnailsize.h for
about one hour with recreating of several hundreds of thumbnails and
didn't notice increased memory usage.

> Also, the thumnails size is standardized by freedesktop.org to be
> compatible between KDE, Gnome, etc. The max size is 256. The thumbs
> cache is saved on your hdd in your home directory and is shared by other
> applications.

Well, big monitors are more common and affordable. It this is possible
in few years sizes of thumbnails in standard will increase. Since this
patch only removes hardcoded values and not increase size of thumbnails
by itself I think it is quite good.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel