digiKam › digikam-devel

hu?

classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Bugzilla from tomalbers@kde.nl
Reply | Threaded
Open this post in threaded view
♦
♦
|

hu?

Bugzilla from tomalbers@kde.nl
Gilles,

Can you look at this patch? I can not understand why you are splitting a
qstringlist ;-)

Have not tested it though.

Tom
---------------------

Index: showfoto/showfoto.cpp
===================================================================
--- showfoto/showfoto.cpp       (revision 493241)
+++ showfoto/showfoto.cpp       (working copy)
@@ -725,8 +725,7 @@
             // Else, check if format from file name extension is include on
file mime type list.

             QString imgExtPattern;
-            QStringList imgExtList = QStringList::split(" ", mimetypes);
-            for (QStringList::ConstIterator it = imgExtList.begin() ; it !=
imgExtList.end() ; it++)
+            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
mimetypes.end() ; it++)
             {
                 imgExtPattern.append (KImageIO::typeForMime(*it));
                 imgExtPattern.append (" ");
Index: utilities/imageeditor/imagewindow.cpp
===================================================================
--- utilities/imageeditor/imagewindow.cpp       (revision 493241)
+++ utilities/imageeditor/imagewindow.cpp       (working copy)
@@ -1067,8 +1067,7 @@
             // Else, check if format from file name extension is include on
file mime type list.

             QString imgExtPattern;
-            QStringList imgExtList = QStringList::split(" ", mimetypes);
-            for (QStringList::ConstIterator it = imgExtList.begin() ; it !=
imgExtList.end() ; it++)
+            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
mimetypes.end() ; it++)
             {
                 imgExtPattern.append (KImageIO::typeForMime(*it));
                 imgExtPattern.append (" ");

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

smime.p7s (2K) Download Attachment
Gilles Caulier
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: hu?

Gilles Caulier
Le Lundi 2 Janvier 2006 00:35, Tom Albers a écrit :
> Gilles,
>
> Can you look at this patch? I can not understand why you are splitting a
> qstringlist ;-)
>

mimetypes is a simple QString, not a QStringList. You cannot use iterator on !
Have you tried to compile your patch (:=))) ?

My 10 cts €

Gilles

> Have not tested it though.
>
> Tom
> ---------------------
>
> Index: showfoto/showfoto.cpp
> ===================================================================
> --- showfoto/showfoto.cpp       (revision 493241)
> +++ showfoto/showfoto.cpp       (working copy)
> @@ -725,8 +725,7 @@
>              // Else, check if format from file name extension is include
> on file mime type list.
>
>              QString imgExtPattern;
> -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> != imgExtList.end() ; it++)
> +            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
> mimetypes.end() ; it++)
>              {
>                  imgExtPattern.append (KImageIO::typeForMime(*it));
>                  imgExtPattern.append (" ");
> Index: utilities/imageeditor/imagewindow.cpp
> ===================================================================
> --- utilities/imageeditor/imagewindow.cpp       (revision 493241)
> +++ utilities/imageeditor/imagewindow.cpp       (working copy)
> @@ -1067,8 +1067,7 @@
>              // Else, check if format from file name extension is include
> on file mime type list.
>
>              QString imgExtPattern;
> -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> != imgExtList.end() ; it++)
> +            for (QStringList::ConstIterator it = mimetypes.begin() ; it !=
> mimetypes.end() ; it++)
>              {
>                  imgExtPattern.append (KImageIO::typeForMime(*it));
>                  imgExtPattern.append (" ");
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Tom Albers-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: hu?

Tom Albers-2
Op maandag 2 januari 2006 10:19, schreef Caulier Gilles:
> Le Lundi 2 Janvier 2006 00:35, Tom Albers a écrit :
> > Gilles,
> >
> > Can you look at this patch? I can not understand why you are splitting a
> > qstringlist ;-)
>
> mimetypes is a simple QString, not a QStringList.

Look again ;-)

Toma

> You cannot use iterator
> on ! Have you tried to compile your patch (:=))) ?
>
> My 10 cts ¤
>
> Gilles
>
> > Have not tested it though.
> >
> > Tom
> > ---------------------
> >
> > Index: showfoto/showfoto.cpp
> > ===================================================================
> > --- showfoto/showfoto.cpp       (revision 493241)
> > +++ showfoto/showfoto.cpp       (working copy)
> > @@ -725,8 +725,7 @@
> >              // Else, check if format from file name extension is include
> > on file mime type list.
> >
> >              QString imgExtPattern;
> > -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> > -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> > != imgExtList.end() ; it++)
> > +            for (QStringList::ConstIterator it = mimetypes.begin() ; it
> > != mimetypes.end() ; it++)
> >              {
> >                  imgExtPattern.append (KImageIO::typeForMime(*it));
> >                  imgExtPattern.append (" ");
> > Index: utilities/imageeditor/imagewindow.cpp
> > ===================================================================
> > --- utilities/imageeditor/imagewindow.cpp       (revision 493241)
> > +++ utilities/imageeditor/imagewindow.cpp       (working copy)
> > @@ -1067,8 +1067,7 @@
> >              // Else, check if format from file name extension is include
> > on file mime type list.
> >
> >              QString imgExtPattern;
> > -            QStringList imgExtList = QStringList::split(" ", mimetypes);
> > -            for (QStringList::ConstIterator it = imgExtList.begin() ; it
> > != imgExtList.end() ; it++)
> > +            for (QStringList::ConstIterator it = mimetypes.begin() ; it
> > != mimetypes.end() ; it++)
> >              {
> >                  imgExtPattern.append (KImageIO::typeForMime(*it));
> >                  imgExtPattern.append (" ");
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Tom Albers-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: hu?

Tom Albers-2
Op maandag 2 januari 2006 10:26, schreef u:

> Op maandag 2 januari 2006 10:19, schreef Caulier Gilles:
> > Le Lundi 2 Janvier 2006 00:35, Tom Albers a écrit :
> > > Gilles,
> > >
> > > Can you look at this patch? I can not understand why you are splitting
> > > a qstringlist ;-)
> >
> > mimetypes is a simple QString, not a QStringList.
>
> Look again ;-)

in branch btw

Toma

> Toma
>
> > You cannot use iterator
> > on ! Have you tried to compile your patch (:=))) ?
> >
> > My 10 cts ¤
> >
> > Gilles
> >
> > > Have not tested it though.
> > >
> > > Tom
> > > ---------------------
> > >
> > > Index: showfoto/showfoto.cpp
> > > ===================================================================
> > > --- showfoto/showfoto.cpp       (revision 493241)
> > > +++ showfoto/showfoto.cpp       (working copy)
> > > @@ -725,8 +725,7 @@
> > >              // Else, check if format from file name extension is
> > > include on file mime type list.
> > >
> > >              QString imgExtPattern;
> > > -            QStringList imgExtList = QStringList::split(" ",
> > > mimetypes); -            for (QStringList::ConstIterator it =
> > > imgExtList.begin() ; it != imgExtList.end() ; it++)
> > > +            for (QStringList::ConstIterator it = mimetypes.begin() ;
> > > it != mimetypes.end() ; it++)
> > >              {
> > >                  imgExtPattern.append (KImageIO::typeForMime(*it));
> > >                  imgExtPattern.append (" ");
> > > Index: utilities/imageeditor/imagewindow.cpp
> > > ===================================================================
> > > --- utilities/imageeditor/imagewindow.cpp       (revision 493241)
> > > +++ utilities/imageeditor/imagewindow.cpp       (working copy)
> > > @@ -1067,8 +1067,7 @@
> > >              // Else, check if format from file name extension is
> > > include on file mime type list.
> > >
> > >              QString imgExtPattern;
> > > -            QStringList imgExtList = QStringList::split(" ",
> > > mimetypes); -            for (QStringList::ConstIterator it =
> > > imgExtList.begin() ; it != imgExtList.end() ; it++)
> > > +            for (QStringList::ConstIterator it = mimetypes.begin() ;
> > > it != mimetypes.end() ; it++)
> > >              {
> > >                  imgExtPattern.append (KImageIO::typeForMime(*it));
> > >                  imgExtPattern.append (" ");
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Gilles Caulier
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: hu?

Gilles Caulier
Le Lundi 2 Janvier 2006 10:48, Tom Albers a écrit :

> Op maandag 2 januari 2006 10:26, schreef u:
> > Op maandag 2 januari 2006 10:19, schreef Caulier Gilles:
> > > Le Lundi 2 Janvier 2006 00:35, Tom Albers a écrit :
> > > > Gilles,
> > > >
> > > > Can you look at this patch? I can not understand why you are
> > > > splitting a qstringlist ;-)
> > >
> > > mimetypes is a simple QString, not a QStringList.
> >
> > Look again ;-)
>
> in branch btw

Right for stable not for trunk. Getting writting image mimetypes method are
different in 0.8.1 (hardcoded) and 0.9.0 (from KImageIO).

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Free forum by Nabble Edit this page