The person who introduced these warnings wants to fix them: me. Sorry, I did'nt
> Yes, under linux, i cannot see these warnings.
>
> But i think that we can fix these warnings just to be to identify new
> real problem in code, especially with MSVC compiler.*
>
> M$ compiler console report is a worse to use. I clean up code when i
> can. Like this, new warnings are really new...
>
> Gilles
>
> 2010/1/3 Johannes Wienke <
[hidden email]>:
>
> > Is there any way to get this strict warnings also on linux? pedantic
> > seems not to catch these cases.
> >
> > Am 03.01.2010 19:08 schrieb Gilles Caulier:
> >> Some warnings to fix under windows :
> >>
> >> [ 11%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/histog
> >>ramwidget.obj [ 12%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/histog
> >>rampainter.obj
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>: In member function `double
> >> Digikam::HistogramPainterPriv::calculateMax()':
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:72: warning: converting to `int' from `double'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:73: warning: converting to `int' from `double'
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>: In member function `void
> >> Digikam::HistogramPainterPriv::renderSingleColorLine(QPixmap&,
> >> QPainter&)':
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:271: warning: passing `double' for converting 1 of `void
> >> QPainter::setClipRect(int, int, int, int, Qt::ClipOperation)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:271: warning: passing `double' for converting 3 of `void>
>
> Message: 5
> Date: Sun, 3 Jan 2010 20:15:04 +0100
> From: Gilles Caulier <
[hidden email]>
> Subject: Re: [Digikam-devel] i18nc vs i18n, possible patch for
>
https://bugs.kde.org/show_bug.cgi?id=219430> To: digiKam developers room - digiKam - Manage your photographs as a
> professional with the power of open source <
[hidden email]>,
>
[hidden email]
> Message-ID:
> <
[hidden email]>
> Content-Type: text/plain; charset=ISO-8859-1
>
> yes, it's fine for me. lets go
>
> Gilles Caulier
>
> 2010/1/3 Alexander Potashev <
[hidden email]>:
> > Hi,
> >
> > This patch replaces a few "i18n"s and a "i18np" with "i18nc"s and a
> > "i18ncp" to split translations of them.
> >
> > Shall I commit it?
> >
> >
> >
> >
> > Index: digikam/contextmenuhelper.cpp
> > ===================================================================
> > --- digikam/contextmenuhelper.cpp ? ? ? (revision 1069542)
> > +++ digikam/contextmenuhelper.cpp ? ? ? (working copy)
> > @@ -633,8 +633,8 @@
> >
> > ?void ContextMenuHelper::addActionItemDelete(QObject* recv, const char*
> > slot, int quantity) ?{
> > - ? ?QAction *trashAction = new QAction(SmallIcon("user-trash"),
> > i18np("Move to Trash", - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "Move %1
> > Files to Trash", quantity), d->parent); + ? ?QAction *trashAction = new
> > QAction(SmallIcon("user-trash"), i18ncp("@action:inmenu Pluralized", + ?
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? "Move to Trash", "Move %1 Files to
> > Trash", quantity), d->parent); ? ? connect(trashAction,
> > SIGNAL(triggered()),
> > ? ? ? ? ? ? recv, slot);
> > ? ? addAction(trashAction);
> > Index: digikam/digikamapp.cpp
> > ===================================================================
> > --- digikam/digikamapp.cpp ? ? ?(revision 1069542)
> > +++ digikam/digikamapp.cpp ? ? ?(working copy)
> > @@ -848,7 +848,7 @@
> > ? ? // -----------------------------------------------------------
> >
> > ? ? // Pop up dialog to ask user whether to move to trash
> > - ? ?d->imageDeleteAction = new KAction(KIcon("user-trash"), i18n("Move
> > to Trash"), this); + ? ?d->imageDeleteAction = new
> > KAction(KIcon("user-trash"), i18nc("Non-pluralized", "Move to Trash"),
> > this); ? ? d->imageDeleteAction->setShortcut(KShortcut(Qt::Key_Delete));
> > ? ? connect(d->imageDeleteAction, SIGNAL(triggered()), d->view,
> > SLOT(slotImageDelete())); ? ?
> > actionCollection()->addAction("image_delete", d->imageDeleteAction);
> > Index: showfoto/showfoto.cpp
> > ===================================================================
> > --- showfoto/showfoto.cpp ? ? ? (revision 1069542)
> > +++ showfoto/showfoto.cpp ? ? ? (working copy)
> > @@ -544,7 +544,7 @@
> > ? ? if (d->deleteItem2Trash)
> > ? ? {
> > ? ? ? ? m_fileDeleteAction->setIcon(KIcon("user-trash"));
> > - ? ? ? ?m_fileDeleteAction->setText(i18n("Move to Trash"));
> > + ? ? ? ?m_fileDeleteAction->setText(i18nc("Non-pluralized", "Move to
> > Trash")); ? ? }
> > ? ? else
> > ? ? {
> > Index: utilities/lighttable/lighttablepreview.cpp
> > ===================================================================
> > --- utilities/lighttable/lighttablepreview.cpp ?(revision 1069542)
> > +++ utilities/lighttable/lighttablepreview.cpp ?(working copy)
> > @@ -363,7 +363,7 @@
> > ? ? QAction *fitWindowAction = new QAction(SmallIcon("zoom-fit-best"),
> > i18n("Fit to &Window"), this); ? ? QAction *slideshowAction = new
> > QAction(SmallIcon("view-presentation"), i18n("Slideshow"), this); ? ?
> > QAction *editAction ? ? ?= new QAction(SmallIcon("editimage"),
> > i18n("Edit..."), this); - ? ?QAction *trashAction ? ? = new
> > QAction(SmallIcon("user-trash"), i18n("Move to Trash"), this); + ?
> > ?QAction *trashAction ? ? = new QAction(SmallIcon("user-trash"),
> > i18nc("Non-pluralized", "Move to Trash"), this);
> >
> > ? ? // --------------------------------------------------------
> >
> > Index: utilities/lighttable/lighttablewindow.cpp
> > ===================================================================
> > --- utilities/lighttable/lighttablewindow.cpp ? (revision 1069542)
> > +++ utilities/lighttable/lighttablewindow.cpp ? (working copy)
> > @@ -449,7 +449,7 @@
> > ? ? connect(d->clearListAction, SIGNAL(triggered()), this,
> > SLOT(slotClearItemsList())); ? ?
> > actionCollection()->addAction("lighttable_clearlist",
> > d->clearListAction);
> >
> > - ? ?d->fileDeleteAction = new KAction(KIcon("user-trash"), i18n("Move to
> > Trash"), this); + ? ?d->fileDeleteAction = new
> > KAction(KIcon("user-trash"), i18nc("Non-pluralized", "Move to Trash"),
> > this); ? ? d->fileDeleteAction->setShortcut(KShortcut(Qt::Key_Delete)); ?
> > ? d->fileDeleteAction->setEnabled(false);
> > ? ? connect(d->fileDeleteAction, SIGNAL(triggered()), this,
> > SLOT(slotDeleteItem())); Index:
> > utilities/imageeditor/editor/editorwindow.cpp
> > ===================================================================
> > --- utilities/imageeditor/editor/editorwindow.cpp ? ? ? (revision
> > 1069542) +++ utilities/imageeditor/editor/editorwindow.cpp ? ? ? (working
> > copy) @@ -339,7 +339,7 @@
> > ? ? connect(d->filePrintAction, SIGNAL(triggered()), this,
> > SLOT(slotFilePrint())); ? ?
> > actionCollection()->addAction("editorwindow_print", d->filePrintAction);
> >
> > - ? ?m_fileDeleteAction = new KAction(KIcon("user-trash"), i18n("Move to
> > Trash"), this); + ? ?m_fileDeleteAction = new
> > KAction(KIcon("user-trash"), i18nc("Non-pluralized", "Move to Trash"),
> > this); ? ? m_fileDeleteAction->setShortcut(KShortcut(Qt::Key_Delete));
> > ? ? connect(m_fileDeleteAction, SIGNAL(triggered()), this,
> > SLOT(slotDeleteCurrentItem())); ? ?
> > actionCollection()->addAction("editorwindow_delete", m_fileDeleteAction);
> >
> >
> >
> > --
> > Alexander Potashev
> > _______________________________________________
> > Digikam-devel mailing list
> >
[hidden email]
> >
https://mail.kde.org/mailman/listinfo/digikam-devel>
> ------------------------------
>
> Message: 6
> Date: Sun, 3 Jan 2010 20:18:04 +0100 (CET)
> From: Johannes Wienke <
[hidden email]>
> Subject: [Digikam-devel] [Bug 221142] Show as overlay some editable
> exif information on the images into the light table.
> To:
[hidden email]
> Message-ID: <
[hidden email]>
> Content-Type: text/plain; charset="UTF-8"
>
>
https://bugs.kde.org/show_bug.cgi?id=221142>
>
> Johannes Wienke <
[hidden email]> changed:
>
> What |Removed |Added
> ---------------------------------------------------------------------------
> - CC| |
[hidden email]
>
>
>
>
> --- Comment #1 from Johannes Wienke <languitar semipol de> 2010-01-03
> 20:18:03 --- There is the normal sidebar for both displayed images at the
> left and right. The sidebar can display exif information etc. Isn't that
> enough?
>
> >> QPainter::setClipRect(int, int, int, int, Qt::ClipOperation)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:273: warning: passing `double' for converting 1 of `void
> >> QPainter::fillRect(int, int, int, int, const QBrush&)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:273: warning: passing `double' for converting 3 of `void
> >> QPainter::fillRect(int, int, int, int, const QBrush&)'
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>: In member function `void
> >> Digikam::HistogramPainterPriv::renderMultiColorLine(QPixmap&,
> >> QPainter&)':
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:356: warning: passing `double' for converting 1 of `void
> >> QPainter::setClipRect(int, int, int, int, Qt::ClipOperation)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:356: warning: passing `double' for converting 3 of `void
> >> QPainter::setClipRect(int, int, int, int, Qt::ClipOperation)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:359: warning: passing `double' for converting 1 of `void
> >> QPainter::fillRect(int, int, int, int, const QColor&)'
> >>
> >> E:\devel-mingw\graphics\digikam\libs\widgets\common\histogrampainter.cpp
> >>:359: warning: passing `double' for converting 3 of `void
> >> QPainter::fillRect(int, int, int, int, const QColor&)'
> >> [ 12%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/itemvi
> >>ewhoverbutton.obj [ 12%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/itemvi
> >>ewtooltip.obj [ 12%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/knotif
> >>icationwrapper.obj [ 12%] Building CXX object
> >>
> >> digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/panico
> >>nwidget.obj
> >>
> >> Gilles
> >> _______________________________________________
> >> Digikam-devel mailing list
> >>
[hidden email]
> >>
https://mail.kde.org/mailman/listinfo/digikam-devel> >
> > _______________________________________________
> > Digikam-devel mailing list
> >
[hidden email]
> >
https://mail.kde.org/mailman/listinfo/digikam-devel>
Locked
signature.asc (268 bytes)