failed armhf build of digikam 4:2.6.0~beta2-2

[Debian buildds]

 * Source package: digikam
 * Version: 4:2.6.0~beta2-2
 * Architecture: armhf
 * State: failed
 * Suite: sid
 * Builder: henze.debian.org
 * Build log: https://buildd.debian.org/fetch.cgi?pkg=digikam&arch=armhf&ver=4%3A2.6.0%7Ebeta2-2&stamp=1333190767&file=log

Please note that these notifications do not necessarily mean bug reports
in your package but could also be caused by other packages, temporary
uninstallabilities and arch-specific breakages.  A look at the build log
despite this disclaimer would be appreciated however.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa]

The build problem is merely the 0.0 being treated as double, the other
variables in play already are float, so the following patch should make
compiling going.

I'm testing a build on _x86_64_, if it work it will be applied to trunk
(unless someone from dk-devel stop me ;)

diff --git a/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
b/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
index d0e5bf7..be9d7cb 100644
--- a/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
+++ b/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
@@ -340,8 +340,8 @@ void
CropWidgetItem::mouseMoveEvent(QGraphicsSceneMouseEvent * event)
          QPointF dif = event->scenePos() - event->lastScenePos();
          temp.translate(dif);

-        temp.translate( qMin(maxRect.right()-temp.right(),0.0),
qMin(maxRect.bottom()-temp.bottom(),0.0) );
-        temp.translate( qMax(maxRect.left()-temp.left(),0.0),
qMax(maxRect.top()-temp.top(),0.0) );
+        temp.translate( qMin<float>(maxRect.right()-temp.right(),0.0),
qMin<float>(maxRect.bottom()-temp.bottom(),0.0) );
+        temp.translate( qMax<float>(maxRect.left()-temp.left(),0.0),
qMax<float>(maxRect.top()-temp.top(),0.0) );
      }
      // Size change
      else


Il 31/03/2012 13:00, Debian buildds ha scritto:

>   * Source package: digikam
>   * Version: 4:2.6.0~beta2-2
>   * Architecture: armhf
>   * State: failed
>   * Suite: sid
>   * Builder: henze.debian.org
>   * Build log: https://buildd.debian.org/fetch.cgi?pkg=digikam&arch=armhf&ver=4%3A2.6.0%7Ebeta2-2&stamp=1333190767&file=log
>
> Please note that these notifications do not necessarily mean bug reports
> in your package but could also be caused by other packages, temporary
> uninstallabilities and arch-specific breakages.  A look at the build log
> despite this disclaimer would be appreciated however.
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa]

http://commits.kde.org/kipi-plugins/6e6ba88fbcc4fae800d97d44d7a14ff0c22a6302


Il 02/04/2012 18:35, Francesco Riosa ha scritto:

> The build problem is merely the 0.0 being treated as double, the other
> variables in play already are float, so the following patch should make
> compiling going.
>
> I'm testing a build on _x86_64_, if it work it will be applied to trunk
> (unless someone from dk-devel stop me ;)
>
> diff --git a/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
> b/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
> index d0e5bf7..be9d7cb 100644
> --- a/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
> +++ b/photolayoutseditor/widgets/canvas/CropWidgetItem.cpp
> @@ -340,8 +340,8 @@ void
> CropWidgetItem::mouseMoveEvent(QGraphicsSceneMouseEvent * event)
> QPointF dif = event->scenePos() - event->lastScenePos();
> temp.translate(dif);
>
> - temp.translate( qMin(maxRect.right()-temp.right(),0.0),
> qMin(maxRect.bottom()-temp.bottom(),0.0) );
> - temp.translate( qMax(maxRect.left()-temp.left(),0.0),
> qMax(maxRect.top()-temp.top(),0.0) );
> + temp.translate( qMin<float>(maxRect.right()-temp.right(),0.0),
> qMin<float>(maxRect.bottom()-temp.bottom(),0.0) );
> + temp.translate( qMax<float>(maxRect.left()-temp.left(),0.0),
> qMax<float>(maxRect.top()-temp.top(),0.0) );
> }
> // Size change
> else
>
>
> Il 31/03/2012 13:00, Debian buildds ha scritto:
>> * Source package: digikam
>> * Version: 4:2.6.0~beta2-2
>> * Architecture: armhf
>> * State: failed
>> * Suite: sid
>> * Builder: henze.debian.org
>> * Build log:
>> https://buildd.debian.org/fetch.cgi?pkg=digikam&arch=armhf&ver=4%3A2.6.0%7Ebeta2-2&stamp=1333190767&file=log
>>
>>
>> Please note that these notifications do not necessarily mean bug reports
>> in your package but could also be caused by other packages, temporary
>> uninstallabilities and arch-specific breakages. A look at the build log
>> despite this disclaimer would be appreciated however.
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel