extragear/graphics/kipi-plugins/gpssync

SVN commit 891658 by aclemens:

GPSsync plugin uses common ImagesList widget now

Right now the plugin only uses the widget as it is, but I think this is
not good, it really doesn't help to maintain the plugin code.
It would be much better to merge gpslistviewitem and
gpstracklistviewitem into one common item (GPSListViewItem) and derive a
common ListView widget from ImagesList (GPSImageList), that can be used
in gpssyncdialog and gpstracklisteditdialog.

Since I'm not the author of the plugin, I might get things wrong here,
but for me those views and listitems are nearly the same.

For now I will leave it this way, if we want to merge these widgets, we
can do it later.

Andi

CCMAIL:[hidden email]
CCMAIL:[hidden email]

 M  +14 -12    gpslistviewitem.cpp  
 M  +4 -4      gpslistviewitem.h  
 M  +31 -62    gpssyncdialog.cpp  
 M  +2 -5      gpssyncdialog.h  
 M  +45 -66    gpstracklisteditdialog.cpp  
 M  +1 -2      gpstracklisteditdialog.h  
 M  +9 -9      gpstracklistviewitem.cpp  
 M  +4 -4      gpstracklistviewitem.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2008/12/2 Andi Clemens <[hidden email]>

SVN commit 891658 by aclemens:

GPSsync plugin uses common ImagesList widget now

Right now the plugin only uses the widget as it is, but I think this is
not good, it really doesn't help to maintain the plugin code.
It would be much better to merge gpslistviewitem and
gpstracklistviewitem into one common item (GPSListViewItem) and derive a
common ListView widget from ImagesList (GPSImageList), that can be used
in gpssyncdialog and gpstracklisteditdialog.

Since I'm not the author of the plugin, I might get things wrong here,
but for me those views and listitems are nearly the same.

yes, it's fine for me to factorize this code too...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

There are still problems with GPSsync (not related to the factorizing though):

Deleting GPS information in Correlator doesn't work (and it tries to delete
info from all files, not only the selected).

When you deleted info from files (which is not working), a popup will tell you
that you have unsaved changes. Closing this popup will cause it to re-appear
again. You need to click "close" twice.

In Correlator->Edit: Button "Goto Location" never works, always disabled

Andi

On Tuesday 02 December 2008 16:02:20 Gilles Caulier wrote:

> 2008/12/2 Andi Clemens <[hidden email]>
>
> > SVN commit 891658 by aclemens:
> >
> > GPSsync plugin uses common ImagesList widget now
> >
> > Right now the plugin only uses the widget as it is, but I think this is
> > not good, it really doesn't help to maintain the plugin code.
> > It would be much better to merge gpslistviewitem and
> > gpstracklistviewitem into one common item (GPSListViewItem) and derive a
> > common ListView widget from ImagesList (GPSImageList), that can be used
> > in gpssyncdialog and gpstracklisteditdialog.
> >
> > Since I'm not the author of the plugin, I might get things wrong here,
> > but for me those views and listitems are nearly the same.
>
> yes, it's fine for me to factorize this code too...
>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel