extragear/graphics/digikam/utilities

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

extragear/graphics/digikam/utilities

Bugzilla from andi.clemens@gmx.net
SVN commit 997148 by aclemens:

Fullscreen is a toggle action and should be used as such.
Either press the button in the toolbar, or CTRL+SHIFT+F to exit
fullscreen.
This mechanism is used throughout KDE and should be used in digiKam as
well of course.
I would strongly recommend NOT to use ESC to quit the fullscreen mode.

I disable these actions for now, but again I would rather remove it
completely. What do you think?

Andi

CCMAIL:[hidden email]

 M  +4 -4      cameragui/cameraui.cpp  
 M  +4 -4      lighttable/lighttablewindow.cpp  
 M  +4 -4      queuemanager/queuemgrwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp #997147:997148
@@ -489,10 +489,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
     actionCollection()->addAction("cameraui_backward_shift_space", altBackwardAction);
--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cpp #997147:997148
@@ -550,10 +550,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
     actionCollection()->addAction("lighttable_backward_shift_space", altBackwardAction);
--- trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow.cpp #997147:997148
@@ -445,10 +445,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     // ---------------------------------------------------------------------------------
 
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities

Gilles Caulier-4
What others lead soft use to exit fullscreen, as Firefox, photoshop,
openoffice, etc.

For me ESC  is simple to use and logic : only one key to use.

Gilles

2009/7/15 Andi Clemens <[hidden email]>:

> SVN commit 997148 by aclemens:
>
> Fullscreen is a toggle action and should be used as such.
> Either press the button in the toolbar, or CTRL+SHIFT+F to exit
> fullscreen.
> This mechanism is used throughout KDE and should be used in digiKam as
> well of course.
> I would strongly recommend NOT to use ESC to quit the fullscreen mode.
>
> I disable these actions for now, but again I would rather remove it
> completely. What do you think?
>
> Andi
>
> CCMAIL:[hidden email]
>
>  M  +4 -4      cameragui/cameraui.cpp
>  M  +4 -4      lighttable/lighttablewindow.cpp
>  M  +4 -4      queuemanager/queuemgrwindow.cpp
>
>
> --- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp #997147:997148
> @@ -489,10 +489,10 @@
>
>     // -- Keyboard-only actions added to <MainWindow> ------------------------------
>
> -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> -    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
> -    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> -    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> +//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> +//    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
> +//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> +//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>
>     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
>     actionCollection()->addAction("cameraui_backward_shift_space", altBackwardAction);
> --- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cpp #997147:997148
> @@ -550,10 +550,10 @@
>
>     // -- Keyboard-only actions added to <MainWindow> ------------------------------
>
> -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> -    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
> -    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> -    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> +//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> +//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
> +//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> +//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>
>     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
>     actionCollection()->addAction("lighttable_backward_shift_space", altBackwardAction);
> --- trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow.cpp #997147:997148
> @@ -445,10 +445,10 @@
>
>     // -- Keyboard-only actions added to <MainWindow> ------------------------------
>
> -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> -    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
> -    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> -    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> +//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> +//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
> +//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
> +//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>
>     // ---------------------------------------------------------------------------------
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities

Bugzilla from andi.clemens@gmx.net
In Firefox you press F11... and F11 again to close fullscreen. There are no
two key shortcuts.

I can only say we are a KDE4 application, so we shouldn't care what firefox or
something else is doing. In KDE4 you press SHIFT+CTRL+F (or whatever you set
globally), and we should do so, too.
This way the global key is used in every application.
So if I like my KDE apps to go into fullscreen with F11, I set it in the
system settings.
Now all apps (digiKam, showFoto, Kate or whatever) will work the same way.

I just tested VLC: also just one shortcut (F), to get in and out of
fullscreen.

When we use ESC to go out (and we only used it in editor, cameraUI..., but not
in albumUI which is inconsistent inside of digiKam), then we can't close the
tools by using ESC, which would be also useful (and is asked by many users).

Again, it is just my opinion (:-)), but digiKam should behave like a KDE4
application, not re-invent everything.

Any other opinions?

Andi

On Wednesday 15 July 2009 14:32:10 Gilles Caulier wrote:

> What others lead soft use to exit fullscreen, as Firefox, photoshop,
> openoffice, etc.
>
> For me ESC  is simple to use and logic : only one key to use.
>
> Gilles
>
> 2009/7/15 Andi Clemens <[hidden email]>:
> > SVN commit 997148 by aclemens:
> >
> > Fullscreen is a toggle action and should be used as such.
> > Either press the button in the toolbar, or CTRL+SHIFT+F to exit
> > fullscreen.
> > This mechanism is used throughout KDE and should be used in digiKam as
> > well of course.
> > I would strongly recommend NOT to use ESC to quit the fullscreen mode.
> >
> > I disable these actions for now, but again I would rather remove it
> > completely. What do you think?
> >
> > Andi
> >
> > CCMAIL:[hidden email]
> >
> >  M  +4 -4      cameragui/cameraui.cpp
> >  M  +4 -4      lighttable/lighttablewindow.cpp
> >  M  +4 -4      queuemanager/queuemgrwindow.cpp
> >
> >
> > --- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp
> > #997147:997148 @@ -489,10 +489,10 @@
> >
> >     // -- Keyboard-only actions added to <MainWindow>
> > ------------------------------
> >
> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> > mode"), this); -  
> >  actionCollection()->addAction("cameraui_exitfullscreen",
> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> > +//    actionCollection()->addAction("cameraui_exitfullscreen",
> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >
> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
> > this); actionCollection()->addAction("cameraui_backward_shift_space",
> > altBackwardAction); ---
> > trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cp
> >p #997147:997148 @@ -550,10 +550,10 @@
> >
> >     // -- Keyboard-only actions added to <MainWindow>
> > ------------------------------
> >
> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> > mode"), this); -  
> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> > +//    actionCollection()->addAction("editorwindow_exitfullscreen",
> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >
> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
> > this); actionCollection()->addAction("lighttable_backward_shift_space",
> > altBackwardAction); ---
> > trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow.cp
> >p #997147:997148 @@ -445,10 +445,10 @@
> >
> >     // -- Keyboard-only actions added to <MainWindow>
> > ------------------------------
> >
> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> > mode"), this); -  
> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
> > +//    actionCollection()->addAction("editorwindow_exitfullscreen",
> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >
> >     //
> > -------------------------------------------------------------------------
> >--------
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities

Gilles Caulier-4
Look there :

http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts

Gilles

2009/7/15 Andi Clemens <[hidden email]>:

> In Firefox you press F11... and F11 again to close fullscreen. There are no
> two key shortcuts.
>
> I can only say we are a KDE4 application, so we shouldn't care what firefox or
> something else is doing. In KDE4 you press SHIFT+CTRL+F (or whatever you set
> globally), and we should do so, too.
> This way the global key is used in every application.
> So if I like my KDE apps to go into fullscreen with F11, I set it in the
> system settings.
> Now all apps (digiKam, showFoto, Kate or whatever) will work the same way.
>
> I just tested VLC: also just one shortcut (F), to get in and out of
> fullscreen.
>
> When we use ESC to go out (and we only used it in editor, cameraUI..., but not
> in albumUI which is inconsistent inside of digiKam), then we can't close the
> tools by using ESC, which would be also useful (and is asked by many users).
>
> Again, it is just my opinion (:-)), but digiKam should behave like a KDE4
> application, not re-invent everything.
>
> Any other opinions?
>
> Andi
>
> On Wednesday 15 July 2009 14:32:10 Gilles Caulier wrote:
>> What others lead soft use to exit fullscreen, as Firefox, photoshop,
>> openoffice, etc.
>>
>> For me ESC  is simple to use and logic : only one key to use.
>>
>> Gilles
>>
>> 2009/7/15 Andi Clemens <[hidden email]>:
>> > SVN commit 997148 by aclemens:
>> >
>> > Fullscreen is a toggle action and should be used as such.
>> > Either press the button in the toolbar, or CTRL+SHIFT+F to exit
>> > fullscreen.
>> > This mechanism is used throughout KDE and should be used in digiKam as
>> > well of course.
>> > I would strongly recommend NOT to use ESC to quit the fullscreen mode.
>> >
>> > I disable these actions for now, but again I would rather remove it
>> > completely. What do you think?
>> >
>> > Andi
>> >
>> > CCMAIL:[hidden email]
>> >
>> >  M  +4 -4      cameragui/cameraui.cpp
>> >  M  +4 -4      lighttable/lighttablewindow.cpp
>> >  M  +4 -4      queuemanager/queuemgrwindow.cpp
>> >
>> >
>> > --- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp
>> > #997147:997148 @@ -489,10 +489,10 @@
>> >
>> >     // -- Keyboard-only actions added to <MainWindow>
>> > ------------------------------
>> >
>> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
>> > mode"), this); -
>> >  actionCollection()->addAction("cameraui_exitfullscreen",
>> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
>> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
>> > +//    actionCollection()->addAction("cameraui_exitfullscreen",
>> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>> >
>> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
>> > this); actionCollection()->addAction("cameraui_backward_shift_space",
>> > altBackwardAction); ---
>> > trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cp
>> >p #997147:997148 @@ -550,10 +550,10 @@
>> >
>> >     // -- Keyboard-only actions added to <MainWindow>
>> > ------------------------------
>> >
>> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
>> > mode"), this); -
>> >  actionCollection()->addAction("editorwindow_exitfullscreen",
>> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
>> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
>> > +//    actionCollection()->addAction("editorwindow_exitfullscreen",
>> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>> >
>> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
>> > this); actionCollection()->addAction("lighttable_backward_shift_space",
>> > altBackwardAction); ---
>> > trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow.cp
>> >p #997147:997148 @@ -445,10 +445,10 @@
>> >
>> >     // -- Keyboard-only actions added to <MainWindow>
>> > ------------------------------
>> >
>> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
>> > mode"), this); -
>> >  actionCollection()->addAction("editorwindow_exitfullscreen",
>> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
>> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
>> > +//    actionCollection()->addAction("editorwindow_exitfullscreen",
>> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
>> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
>> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
>> >
>> >     //
>> > -------------------------------------------------------------------------
>> >--------
>> >
>> > _______________________________________________
>> > Digikam-devel mailing list
>> > [hidden email]
>> > https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities

Bugzilla from andi.clemens@gmx.net
Yes, but I guess this table is not accurate?
KDE sets CTRL+SHIFT+F, that's a fact :)
Also this table shows that you never use Esc for returning to normal size.

So if you want to use this table as a reference, we must use our own shortcut
and not the KDE one, which breaks consistency. Setting shortcuts in "system
settings" will not apply to digiKam and showFoto (which I still think is bad).

Andi

On Wednesday 15 July 2009 15:04:28 Gilles Caulier wrote:

> Look there :
>
> http://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts
>
> Gilles
>
> 2009/7/15 Andi Clemens <[hidden email]>:
> > In Firefox you press F11... and F11 again to close fullscreen. There are
> > no two key shortcuts.
> >
> > I can only say we are a KDE4 application, so we shouldn't care what
> > firefox or something else is doing. In KDE4 you press SHIFT+CTRL+F (or
> > whatever you set globally), and we should do so, too.
> > This way the global key is used in every application.
> > So if I like my KDE apps to go into fullscreen with F11, I set it in the
> > system settings.
> > Now all apps (digiKam, showFoto, Kate or whatever) will work the same
> > way.
> >
> > I just tested VLC: also just one shortcut (F), to get in and out of
> > fullscreen.
> >
> > When we use ESC to go out (and we only used it in editor, cameraUI...,
> > but not in albumUI which is inconsistent inside of digiKam), then we
> > can't close the tools by using ESC, which would be also useful (and is
> > asked by many users).
> >
> > Again, it is just my opinion (:-)), but digiKam should behave like a KDE4
> > application, not re-invent everything.
> >
> > Any other opinions?
> >
> > Andi
> >
> > On Wednesday 15 July 2009 14:32:10 Gilles Caulier wrote:
> >> What others lead soft use to exit fullscreen, as Firefox, photoshop,
> >> openoffice, etc.
> >>
> >> For me ESC  is simple to use and logic : only one key to use.
> >>
> >> Gilles
> >>
> >> 2009/7/15 Andi Clemens <[hidden email]>:
> >> > SVN commit 997148 by aclemens:
> >> >
> >> > Fullscreen is a toggle action and should be used as such.
> >> > Either press the button in the toolbar, or CTRL+SHIFT+F to exit
> >> > fullscreen.
> >> > This mechanism is used throughout KDE and should be used in digiKam as
> >> > well of course.
> >> > I would strongly recommend NOT to use ESC to quit the fullscreen mode.
> >> >
> >> > I disable these actions for now, but again I would rather remove it
> >> > completely. What do you think?
> >> >
> >> > Andi
> >> >
> >> > CCMAIL:[hidden email]
> >> >
> >> >  M  +4 -4      cameragui/cameraui.cpp
> >> >  M  +4 -4      lighttable/lighttablewindow.cpp
> >> >  M  +4 -4      queuemanager/queuemgrwindow.cpp
> >> >
> >> >
> >> > --- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp
> >> > #997147:997148 @@ -489,10 +489,10 @@
> >> >
> >> >     // -- Keyboard-only actions added to <MainWindow>
> >> > ------------------------------
> >> >
> >> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> >> > mode"), this); -
> >> >  actionCollection()->addAction("cameraui_exitfullscreen",
> >> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> >> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"),
> >> > this); +//    actionCollection()->addAction("cameraui_exitfullscreen",
> >> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >> >
> >> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
> >> > this); actionCollection()->addAction("cameraui_backward_shift_space",
> >> > altBackwardAction); ---
> >> > trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow
> >> >.cp p #997147:997148 @@ -550,10 +550,10 @@
> >> >
> >> >     // -- Keyboard-only actions added to <MainWindow>
> >> > ------------------------------
> >> >
> >> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> >> > mode"), this); -
> >> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> >> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> >> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"),
> >> > this); +//  
> >> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> >> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >> >
> >> >     KAction *altBackwardAction = new KAction(i18n("Previous Image"),
> >> > this);
> >> > actionCollection()->addAction("lighttable_backward_shift_space",
> >> > altBackwardAction); ---
> >> > trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow
> >> >.cp p #997147:997148 @@ -445,10 +445,10 @@
> >> >
> >> >     // -- Keyboard-only actions added to <MainWindow>
> >> > ------------------------------
> >> >
> >> > -    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen
> >> > mode"), this); -
> >> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> >> > exitFullscreenAction); -    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); -    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed())); +//    KAction
> >> > *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"),
> >> > this); +//  
> >> >  actionCollection()->addAction("editorwindow_exitfullscreen",
> >> > exitFullscreenAction); +//    exitFullscreenAction->setShortcut(
> >> > QKeySequence(Qt::Key_Escape) ); +//    connect(exitFullscreenAction,
> >> > SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
> >> >
> >> >     //
> >> > ----------------------------------------------------------------------
> >> >--- --------
> >> >
> >> > _______________________________________________
> >> > Digikam-devel mailing list
> >> > [hidden email]
> >> > https://mail.kde.org/mailman/listinfo/digikam-devel
> >>
> >> _______________________________________________
> >> Digikam-devel mailing list
> >> [hidden email]
> >> https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel