extragear/graphics/digikam/utilities

[Gilles Caulier-4]

SVN commit 668195 by cgilles:

digikam from trunk : Light Table : new option to load automaticly the selected item on thumbbar to the Right panel to speed up comparison of picture from Left panel (Ideas inspired from Luis De la Parra

CCMAIL: [hidden email]
CCMAIL: [hidden email]

 M  +6 -0      lighttable/lighttablewindow.cpp  
 M  +2 -0      lighttable/lighttablewindowprivate.h  
 M  +13 -6     setup/setuplighttable.cpp  


--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cpp #668194:668195
@@ -150,6 +150,7 @@
     KConfig* config = kapp->config();
     config->setGroup("LightTable Settings");
 
+    d->autoLoadOnRightPanel  = config->readBoolEntry("Auto Load Right Panel", true);
     d->autoSyncPreview       = config->readBoolEntry("Auto Sync Preview", true);
     d->fullScreenHideToolBar = config->readBoolEntry("FullScreen Hide ToolBar", false);
 }
@@ -689,6 +690,11 @@
                 d->barView->setOnLeftPanel(info);
                 slotSetItemOnLeftPanel(info);
             }
+            else if (d->autoLoadOnRightPanel && !curr->getOnLeftPanel())
+            {
+                d->barView->setOnRightPanel(info);
+                slotSetItemOnRightPanel(info);
+            }
         }
     }
     else
--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindowprivate.h #668194:668195
@@ -48,6 +48,7 @@
 
     LightTableWindowPriv()
     {
+        autoLoadOnRightPanel   = true;    
         autoSyncPreview        = true;
         fullScreenHideToolBar  = false;
         fullScreen             = false;
@@ -90,6 +91,7 @@
         navigateByPairAction   = 0;
     }
 
+    bool                      autoLoadOnRightPanel;
     bool                      autoSyncPreview;
     bool                      fullScreenHideToolBar;
     bool                      fullScreen;
--- trunk/extragear/graphics/digikam/utilities/setup/setuplighttable.cpp #668194:668195
@@ -55,12 +55,14 @@
 
     SetupLightTablePriv()
     {
-        hideToolBar     = 0;
-        autoSyncPreview = 0;
+        hideToolBar          = 0;
+        autoSyncPreview      = 0;
+        autoLoadOnRightPanel = 0;
     }
 
     QCheckBox *hideToolBar;
     QCheckBox *autoSyncPreview;
+    QCheckBox *autoLoadOnRightPanel;
 };
 
 SetupLightTable::SetupLightTable(QWidget* parent )
@@ -74,12 +76,15 @@
     QVGroupBox *interfaceOptionsGroup = new QVGroupBox(i18n("Interface Options"), parent);
 
 
-    d->autoSyncPreview = new QCheckBox(i18n("Synchronize panels automatically"),
-                                      interfaceOptionsGroup);
+    d->autoSyncPreview      = new QCheckBox(i18n("Synchronize panels automatically"),
+                                            interfaceOptionsGroup);
 
-    d->hideToolBar = new QCheckBox(i18n("H&ide toolbar in fullscreen mode"),
-                                   interfaceOptionsGroup);
+    d->autoLoadOnRightPanel = new QCheckBox(i18n("Selecting a thumbbar item load picture on right panel"),
+                                            interfaceOptionsGroup);
 
+    d->hideToolBar          = new QCheckBox(i18n("H&ide toolbar in fullscreen mode"),
+                                            interfaceOptionsGroup);
+
     // --------------------------------------------------------
 
     layout->addWidget(interfaceOptionsGroup);
@@ -103,6 +108,7 @@
     config->setGroup("LightTable Settings");
     d->hideToolBar->setChecked(config->readBoolEntry("FullScreen Hide ToolBar", false));
     d->autoSyncPreview->setChecked(config->readBoolEntry("Auto Sync Preview", true));
+    d->autoLoadOnRightPanel->setChecked(config->readBoolEntry("Auto Load Right Panel", true));
 }
 
 void SetupLightTable::applySettings()
@@ -111,6 +117,7 @@
     config->setGroup("LightTable Settings");
     config->writeEntry("FullScreen Hide ToolBar", d->hideToolBar->isChecked());
     config->writeEntry("Auto Sync Preview", d->autoSyncPreview->isChecked());
+    config->writeEntry("Auto Load Right Panel", d->autoLoadOnRightPanel->isChecked());
     config->sync();
 }
 
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hello Guilles,

Just checked the latest svn (revision 669615)... I think it is *much* better
now...
just three small details are still missing IMHO:

1) when a bunch of images are selected in the album view and added to the LT,
the first one is open on the "candidate" panel (right hand side) and
the "select" (Left hand side) is empty. --> I think it would be better if the
first image was automatically "selected" and the second one was automatically
set as "candidate"

2)if the current select is (for example) nr. 3, and the current candidate is
nr. 4, then clicking page-up moves the highlighted image on the thumbbar to
image nr. 3, but the image on the candidate panel is not changed (which I
think is OK, because that's the same image as in the select panel). clicking
page-up once more highlights the nr.2 and puts it as candidate.  --> I think
when image nr. 4 is candidate, and you click page-up you should skip the
one "dead step" and go directly to highlighting and really selecting image
nr. 2 as "select"  (the same goes when navigating from left to right)

3) I didn't find an easy way to swap select and candidate.. it would be great
if you could add an action for it (and *please* add a one-key shortcut). when
you promote a "select" to "candidate", the next image after the select should
become the new select automatically.

ok. that's it for now...  great work!!

regards. luis




On Friday 25 May 2007 14:28:26 Gilles Caulier wrote:
> SVN commit 668195 by cgilles:
>
> digikam from trunk : Light Table : new option to load automaticly the
> selected item on thumbbar to the Right panel to speed up comparison of
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/5/29, Luis De la Parra <[hidden email]>:

Hello Gilles,

Just checked the latest svn (revision 669615)... I think it is *much* better
now...
just three small details are still missing IMHO:

1) when a bunch of images are selected in the album view and added to the LT,
the first one is open on the "candidate" panel (right hand side) and
the "select" (Left hand side) is empty. --> I think it would be better if the
first image was automatically "selected" and the second one was automatically
set as "candidate"

Already reported by Mik in this room (:=)) It's in my todo list...

2)if the current select is (for example) nr. 3, and the current candidate is
nr. 4, then clicking page-up moves the highlighted image on the thumbbar to
image nr. 3, but the image on the candidate panel is not changed (which I
think is OK, because that's the same image as in the select panel). clicking
page-up once more highlights the nr.2 and puts it as candidate.  --> I think
when image nr. 4 is candidate, and you click page-up you should skip the
one "dead step" and go directly to highlighting and really selecting image
nr. 2 as "select"  (the same goes when navigating from left to right)

Need to investiguate...
 

3) I didn't find an easy way to swap select and candidate.. it would be great
if you could add an action for it (and *please* add a one-key shortcut). when
you promote a "select" to "candidate", the next image after the select should
become the new select automatically.

Excelent idea. I will take a look.
 

ok. that's it for now...  great work!!

Thanks for your support.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel