extragear/graphics/digikam/utilities/lighttable

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

extragear/graphics/digikam/utilities/lighttable

Gilles Caulier-4
SVN commit 664544 by cgilles:

digikam from trunk : JPEGLossLess kipi plugin cannot be used as well with Light Table because plugin work only with current selection from Album GUI.
So, if we want a rotation tool in Light Table, we need to find another way to do it...

CCMAIL: [hidden email]

 M  +0 -35     lighttablepreview.cpp  


--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablepreview.cpp #664543:664544
@@ -48,11 +48,6 @@
 #include <kprocess.h>
 #include <kapplication.h>
 
-// LibKipi includes.
-
-#include <libkipi/pluginloader.h>
-#include <libkipi/plugin.h>
-
 // Local includes.
 
 #include "ddebug.h"
@@ -361,36 +356,6 @@
     popmenu.insertItem(SmallIcon("editimage"), i18n("Edit..."), 12);
     popmenu.insertItem(i18n("Open With"), &openWithMenu, 13);
 
-    // Merge in the KIPI plugins actions ----------------------------
-
-    KIPI::PluginLoader* kipiPluginLoader      = KIPI::PluginLoader::instance();
-    KIPI::PluginLoader::PluginList pluginList = kipiPluginLoader->pluginList();
-    
-    for (KIPI::PluginLoader::PluginList::const_iterator it = pluginList.begin();
-        it != pluginList.end(); ++it)
-    {
-        KIPI::Plugin* plugin = (*it)->plugin();
-
-        if (plugin && (*it)->name() == "JPEGLossless")
-        {
-            DDebug() << "Found JPEGLossless plugin" << endl;
-
-            KActionPtrList actionList = plugin->actions();
-            
-            for (KActionPtrList::const_iterator iter = actionList.begin();
-                iter != actionList.end(); ++iter)
-            {
-                KAction* action = *iter;
-                
-                if (QString::fromLatin1(action->name())
-                    == QString::fromLatin1("jpeglossless_rotate"))
-                {
-                    action->plug(&popmenu);
-                }
-            }
-        }
-    }
-
     //-- Trash action -------------------------------------------
 
     popmenu.insertSeparator();
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities/lighttable

Bugzilla from mikmach@wp.pl
Dnia poniedziaƂek 14 maj 2007, Gilles Caulier napisaƂ:
> digikam from trunk : JPEGLossLess kipi plugin cannot be used as well
> with Light Table because plugin work only with current selection from
> Album GUI. So, if we want a rotation tool in Light Table, we need to
> find another way to do it...

I am not sure if we want to do that in LT. Sure it would be comfortable
but many other thing also would be comfortable. For example I'd like to
open in all panels of LT (I hope in future for more than two) the same
image and apply to each panel slightly different values of sharpening
to compare effects. It would be nice. But do we really need that?

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel