extragear/graphics/digikam/utilities/imageeditor/canvas

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

extragear/graphics/digikam/utilities/imageeditor/canvas

Gilles Caulier-4
SVN commit 649833 by cgilles:

digiKam from trunk : image editor canvas tile cache mechanism fix !!!
The tile is only recoder in cache in diagonal, and never on all image. This is why image editor is slow to render an image with old computer.

Nota : Lure, Angelo : this patch is really easy to backport on 0.9.1 package of kubuntu and Mandriva. Please backport it. Thanks in advance...

CCMAIL: [hidden email]

 M  +1 -1      canvas.cpp  


--- trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/canvas.cpp #649832:649833
@@ -485,7 +485,7 @@
         {
             for (int i = x1 ; i < x2 ; i += d->tileSize)
             {
-                QString key  = QString("%1,%1").arg(i).arg(j);
+                QString key  = QString("%1,%2").arg(i).arg(j);
                 QPixmap *pix = d->tileCache.find(key);
                 
                 if (!pix)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities/imageeditor/canvas

Gerhard Kulzer
Gilles, during all the versions of canvas.cpp of the last few days I had one
problem: the image editor (and only IE) shows a constant tiling as shown in
the attachment. The viewer and the plugin widgets show the correct pictures,
which correctly stored as well. So it's a IE viewing problem, the picture in
the cache is fine.

Gerhard

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

tiling.png (300K) Download Attachment
attachment1 (196 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities/imageeditor/canvas

Gilles Caulier-4
Gerhard,

Can you send me the picture to test here ?

Also, to be sure, cleanup all digiKam and re-checkout/compile/install to try again. I have fixed a lots of problems and implemented some improvements in canvas this week, especially about the persistant selection. Normally the code is more stable today.

Gilles

2007/4/6, Gerhard Kulzer <[hidden email]>:
Gilles, during all the versions of canvas.cpp of the last few days I had one
problem: the image editor (and only IE) shows a constant tiling as shown in
the attachment. The viewer and the plugin widgets show the correct pictures,
which correctly stored as well. So it's a IE viewing problem, the picture in
the cache is fine.

Gerhard

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel




_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam/utilities/imageeditor/canvas

Gilles Caulier-4
In reply to this post by Gerhard Kulzer
Gerhard,

Also, can you give me more informations  the conditions to reproduce this disfunction in editor. Witch zoom level, witch zoom mode (fit to windows), if you have used the pan icon tool, etc...

Gilles

2007/4/6, Gerhard Kulzer <[hidden email]>:
Gilles, during all the versions of canvas.cpp of the last few days I had one
problem: the image editor (and only IE) shows a constant tiling as shown in
the attachment. The viewer and the plugin widgets show the correct pictures,
which correctly stored as well. So it's a IE viewing problem, the picture in
the cache is fine.

Gerhard

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel




_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel