extragear/graphics/digikam

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

extragear/graphics/digikam

Bugzilla from andi.clemens@gmx.net
SVN commit 1067927 by aclemens:

Change TODO keywords to doxygen style, so that we can have a generated todo
list in our documentation.
I only changed some keywords for now, could you please check if your IDE /
editor still displays them correctly in the "Tasks view"?
At least Eclipse works fine...

CCMAIL:[hidden email]

 M  +3 -1      digikam/albummanager.cpp  
 M  +3 -1      digikam/digikamimageview.cpp  
 M  +6 -2      libs/database/imagescanner.cpp  
 M  +12 -6     utilities/searchwindow/searchfields.cpp  
 M  +24 -8     utilities/setup/setupicc.cpp  


--- trunk/extragear/graphics/digikam/digikam/albummanager.cpp #1067926:1067927
@@ -2679,7 +2679,9 @@
             break;
         case TagChangeset::Renamed:
         case TagChangeset::IconChanged:
-            //TODO
+            /**
+             * @todo
+             */
             break;
         case TagChangeset::Unknown:
             break;
--- trunk/extragear/graphics/digikam/digikam/digikamimageview.cpp #1067926:1067927
@@ -258,7 +258,9 @@
     KAction *paste        = KStandardAction::paste(this, SLOT(paste()), 0);
     const QMimeData *data = kapp->clipboard()->mimeData(QClipboard::Clipboard);
 
-    //TODO
+    /**
+    * @todo
+    */
     if(!data || !KUrl::List::canDecode(data))
         paste->setEnabled(false);
 
--- trunk/extragear/graphics/digikam/libs/database/imagescanner.cpp #1067926:1067927
@@ -463,7 +463,9 @@
 
 void ImageScanner::scanVideoFile()
 {
-    //TODO
+    /**
+    * @todo
+    */
 
     QVariantList metadataInfos;
 
@@ -522,7 +524,9 @@
 
 void ImageScanner::scanAudioFile()
 {
-    //TODO
+    /**
+    * @todo
+    */
 
     QVariantList infos;
     infos << -1
--- trunk/extragear/graphics/digikam/utilities/searchwindow/searchfields.cpp #1067926:1067927
@@ -121,8 +121,10 @@
     }
     else if (name == "notag")
     {
-        //TODO: Merge a "Not tagged" field into TagModel together with AND/OR control for checked tags
-        // and logical connections (AND and Not Tagged checked => all other tags disabled)
+        /**
+        * @todo Merge a "Not tagged" field into TagModel together with AND/OR control
+        * for checked tags and logical connections (AND and Not Tagged checked => all other tags disabled)
+        */
         SearchFieldCheckBox *field = new SearchFieldCheckBox(parent);
         field->setFieldName(name);
         field->setText(i18n("Tags"), i18n("Image has no tags"));
@@ -394,7 +396,9 @@
     }
     else if (name == "flashmode")
     {//choice
-        //TODO: This is a bitmask, and gives some more information
+        /**
+        * @todo This is a bitmask, and gives some more information
+        */
         SearchFieldChoice *field = new SearchFieldChoice(parent);
         field->setFieldName(name);
         field->setText(i18n("Flash"), i18n("Flash mode"));
@@ -1095,9 +1099,11 @@
         }
         else
         {
-            //TODO: This condition is never met.
-            // Right value is either displayed empty (minimum, greater than left)
-            // or one step larger than left
+            /**
+            * @todo : This condition is never met.
+            * Right value is either displayed empty (minimum, greater than left)
+            * or one step larger than left
+            */
             writer.writeField(m_name, SearchXml::Equal);
             if (m_reciprocal)
                 writer.writeValue(m_firstBox->fractionMagicValue());
--- trunk/extragear/graphics/digikam/utilities/setup/setupicc.cpp #1067926:1067927
@@ -278,10 +278,14 @@
                                             "and to which color space it shall be transformed for editing.</p>"));
 
     d->defaultSRGBMissing = new QRadioButton(i18n("Assume it is using the sRGB color space (Internet standard)"));
-    //TODO d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
+    /**
+     * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
+     */
 
     d->defaultSRGBConvert = new QCheckBox(i18n("and convert it to the working color space"));
-    //TODO d->defaultSRGBConvert->setWhatsThis( i18n("<p></p>"));
+    /**
+     * @todo d->defaultSRGBConvert->setWhatsThis( i18n("<p></p>"));
+     */
     d->defaultSRGBConvert->setChecked(true);
 
     QGridLayout *gridRgb = new QGridLayout;
@@ -290,10 +294,14 @@
     gridRgb->setColumnMinimumWidth(0, 10);
 
     d->defaultWSMissing  = new QRadioButton(i18n("Assume it is using the working color space"));
-    //TODO d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
+    /**
+     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
+     */
 
     d->defaultInputMissing = new QRadioButton(i18n("Convert it from default input color space to working space"));
-    //TODO d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
+    /**
+     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
+     */
 
     vlayMissing->addLayout(hboxMP);
     vlayMissing->addWidget(d->defaultAskMissing);
@@ -316,13 +324,19 @@
     hboxRF->addWidget(rawBehaviorLabel, 10);
 
     d->defaultAskRaw   = new QRadioButton(i18n("Ask for the input profile"));
-    //TODO d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
+    /**
+    * @todo d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
+    */
 
     d->defaultGuessRaw = new QRadioButton(i18n("Automatic color correction"));
-    //TODO d->defaultGuessRaw->setWhatsThis( i18n("<p></p>"));
+    /**
+    * @todo d->defaultGuessRaw->setWhatsThis( i18n("<p></p>"));
+    */
 
     d->defaultInputRaw = new QRadioButton(i18n("Convert it from the default input profile"));
-    //TODO d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
+    /**
+    * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
+    */
 
     d->defaultGuessRaw->setChecked(true);
 
@@ -369,7 +383,9 @@
 
     d->managedPreviews = new QCheckBox;
     d->managedPreviews->setText(i18n("Use color managed view for previews and thumbnails"));
-    //TODO d->managedPreview->setWhatsThis( i18n("") );
+    /**
+    * @todo d->managedPreview->setWhatsThis( i18n("") );
+    */
 
     gridView->addWidget(monitorIcon,            0, 0);
     gridView->addWidget(monitorProfiles,        0, 1, 1, 2);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam

Johannes Wienke-3
Do you have fun with the cmake integration of doxygen? ;)

Am 31.12.2009 00:22 schrieb Andi Clemens:

> SVN commit 1067927 by aclemens:
>
> Change TODO keywords to doxygen style, so that we can have a generated todo
> list in our documentation.
> I only changed some keywords for now, could you please check if your IDE /
> editor still displays them correctly in the "Tasks view"?
> At least Eclipse works fine...
>
> CCMAIL:[hidden email]
>
>  M  +3 -1      digikam/albummanager.cpp  
>  M  +3 -1      digikam/digikamimageview.cpp  
>  M  +6 -2      libs/database/imagescanner.cpp  
>  M  +12 -6     utilities/searchwindow/searchfields.cpp  
>  M  +24 -8     utilities/setup/setupicc.cpp  
>
>
> --- trunk/extragear/graphics/digikam/digikam/albummanager.cpp #1067926:1067927
> @@ -2679,7 +2679,9 @@
>              break;
>          case TagChangeset::Renamed:
>          case TagChangeset::IconChanged:
> -            //TODO
> +            /**
> +             * @todo
> +             */
>              break;
>          case TagChangeset::Unknown:
>              break;
> --- trunk/extragear/graphics/digikam/digikam/digikamimageview.cpp #1067926:1067927
> @@ -258,7 +258,9 @@
>      KAction *paste        = KStandardAction::paste(this, SLOT(paste()), 0);
>      const QMimeData *data = kapp->clipboard()->mimeData(QClipboard::Clipboard);
>  
> -    //TODO
> +    /**
> +    * @todo
> +    */
>      if(!data || !KUrl::List::canDecode(data))
>          paste->setEnabled(false);
>  
> --- trunk/extragear/graphics/digikam/libs/database/imagescanner.cpp #1067926:1067927
> @@ -463,7 +463,9 @@
>  
>  void ImageScanner::scanVideoFile()
>  {
> -    //TODO
> +    /**
> +    * @todo
> +    */
>  
>      QVariantList metadataInfos;
>  
> @@ -522,7 +524,9 @@
>  
>  void ImageScanner::scanAudioFile()
>  {
> -    //TODO
> +    /**
> +    * @todo
> +    */
>  
>      QVariantList infos;
>      infos << -1
> --- trunk/extragear/graphics/digikam/utilities/searchwindow/searchfields.cpp #1067926:1067927
> @@ -121,8 +121,10 @@
>      }
>      else if (name == "notag")
>      {
> -        //TODO: Merge a "Not tagged" field into TagModel together with AND/OR control for checked tags
> -        // and logical connections (AND and Not Tagged checked => all other tags disabled)
> +        /**
> +        * @todo Merge a "Not tagged" field into TagModel together with AND/OR control
> +        * for checked tags and logical connections (AND and Not Tagged checked => all other tags disabled)
> +        */
>          SearchFieldCheckBox *field = new SearchFieldCheckBox(parent);
>          field->setFieldName(name);
>          field->setText(i18n("Tags"), i18n("Image has no tags"));
> @@ -394,7 +396,9 @@
>      }
>      else if (name == "flashmode")
>      {//choice
> -        //TODO: This is a bitmask, and gives some more information
> +        /**
> +        * @todo This is a bitmask, and gives some more information
> +        */
>          SearchFieldChoice *field = new SearchFieldChoice(parent);
>          field->setFieldName(name);
>          field->setText(i18n("Flash"), i18n("Flash mode"));
> @@ -1095,9 +1099,11 @@
>          }
>          else
>          {
> -            //TODO: This condition is never met.
> -            // Right value is either displayed empty (minimum, greater than left)
> -            // or one step larger than left
> +            /**
> +            * @todo : This condition is never met.
> +            * Right value is either displayed empty (minimum, greater than left)
> +            * or one step larger than left
> +            */
>              writer.writeField(m_name, SearchXml::Equal);
>              if (m_reciprocal)
>                  writer.writeValue(m_firstBox->fractionMagicValue());
> --- trunk/extragear/graphics/digikam/utilities/setup/setupicc.cpp #1067926:1067927
> @@ -278,10 +278,14 @@
>                                              "and to which color space it shall be transformed for editing.</p>"));
>  
>      d->defaultSRGBMissing = new QRadioButton(i18n("Assume it is using the sRGB color space (Internet standard)"));
> -    //TODO d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> +    /**
> +     * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> +     */
>  
>      d->defaultSRGBConvert = new QCheckBox(i18n("and convert it to the working color space"));
> -    //TODO d->defaultSRGBConvert->setWhatsThis( i18n("<p></p>"));
> +    /**
> +     * @todo d->defaultSRGBConvert->setWhatsThis( i18n("<p></p>"));
> +     */
>      d->defaultSRGBConvert->setChecked(true);
>  
>      QGridLayout *gridRgb = new QGridLayout;
> @@ -290,10 +294,14 @@
>      gridRgb->setColumnMinimumWidth(0, 10);
>  
>      d->defaultWSMissing  = new QRadioButton(i18n("Assume it is using the working color space"));
> -    //TODO d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> +    /**
> +     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> +     */
>  
>      d->defaultInputMissing = new QRadioButton(i18n("Convert it from default input color space to working space"));
> -    //TODO d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> +    /**
> +     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> +     */
>  
>      vlayMissing->addLayout(hboxMP);
>      vlayMissing->addWidget(d->defaultAskMissing);
> @@ -316,13 +324,19 @@
>      hboxRF->addWidget(rawBehaviorLabel, 10);
>  
>      d->defaultAskRaw   = new QRadioButton(i18n("Ask for the input profile"));
> -    //TODO d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
> +    /**
> +    * @todo d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
> +    */
>  
>      d->defaultGuessRaw = new QRadioButton(i18n("Automatic color correction"));
> -    //TODO d->defaultGuessRaw->setWhatsThis( i18n("<p></p>"));
> +    /**
> +    * @todo d->defaultGuessRaw->setWhatsThis( i18n("<p></p>"));
> +    */
>  
>      d->defaultInputRaw = new QRadioButton(i18n("Convert it from the default input profile"));
> -    //TODO d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> +    /**
> +    * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> +    */
>  
>      d->defaultGuessRaw->setChecked(true);
>  
> @@ -369,7 +383,9 @@
>  
>      d->managedPreviews = new QCheckBox;
>      d->managedPreviews->setText(i18n("Use color managed view for previews and thumbnails"));
> -    //TODO d->managedPreview->setWhatsThis( i18n("") );
> +    /**
> +    * @todo d->managedPreview->setWhatsThis( i18n("") );
> +    */
>  
>      gridView->addWidget(monitorIcon,            0, 0);
>      gridView->addWidget(monitorProfiles,        0, 1, 1, 2);


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

signature.asc (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: extragear/graphics/digikam

Bugzilla from andi.clemens@gmx.net
Hmm no I have doxygen locally running since a few months... it has nothing to
do with your changes, I just realized that you can have doxygen TODO tags
(never used them before, but had to at work today)... ;-)

On Thursday 31 December 2009 00:24:15 Johannes Wienke wrote:

> Do you have fun with the cmake integration of doxygen? ;)
>
> Am 31.12.2009 00:22 schrieb Andi Clemens:
> > SVN commit 1067927 by aclemens:
> >
> > Change TODO keywords to doxygen style, so that we can have a generated
> > todo list in our documentation.
> > I only changed some keywords for now, could you please check if your IDE
> > / editor still displays them correctly in the "Tasks view"?
> > At least Eclipse works fine...
> >
> > CCMAIL:[hidden email]
> >
> >  M  +3 -1      digikam/albummanager.cpp
> >  M  +3 -1      digikam/digikamimageview.cpp
> >  M  +6 -2      libs/database/imagescanner.cpp
> >  M  +12 -6     utilities/searchwindow/searchfields.cpp
> >  M  +24 -8     utilities/setup/setupicc.cpp
> >
> >
> > --- trunk/extragear/graphics/digikam/digikam/albummanager.cpp
> > #1067926:1067927 @@ -2679,7 +2679,9 @@
> >              break;
> >          case TagChangeset::Renamed:
> >          case TagChangeset::IconChanged:
> > -            //TODO
> > +            /**
> > +             * @todo
> > +             */
> >              break;
> >          case TagChangeset::Unknown:
> >              break;
> > --- trunk/extragear/graphics/digikam/digikam/digikamimageview.cpp
> > #1067926:1067927 @@ -258,7 +258,9 @@
> >      KAction *paste        = KStandardAction::paste(this, SLOT(paste()),
> > 0); const QMimeData *data =
> > kapp->clipboard()->mimeData(QClipboard::Clipboard);
> >
> > -    //TODO
> > +    /**
> > +    * @todo
> > +    */
> >      if(!data || !KUrl::List::canDecode(data))
> >          paste->setEnabled(false);
> >
> > --- trunk/extragear/graphics/digikam/libs/database/imagescanner.cpp
> > #1067926:1067927 @@ -463,7 +463,9 @@
> >
> >  void ImageScanner::scanVideoFile()
> >  {
> > -    //TODO
> > +    /**
> > +    * @todo
> > +    */
> >
> >      QVariantList metadataInfos;
> >
> > @@ -522,7 +524,9 @@
> >
> >  void ImageScanner::scanAudioFile()
> >  {
> > -    //TODO
> > +    /**
> > +    * @todo
> > +    */
> >
> >      QVariantList infos;
> >      infos << -1
> > ---
> > trunk/extragear/graphics/digikam/utilities/searchwindow/searchfields.cpp
> > #1067926:1067927 @@ -121,8 +121,10 @@
> >      }
> >      else if (name == "notag")
> >      {
> > -        //TODO: Merge a "Not tagged" field into TagModel together with
> > AND/OR control for checked tags -        // and logical connections (AND
> > and Not Tagged checked => all other tags disabled) +        /**
> > +        * @todo Merge a "Not tagged" field into TagModel together with
> > AND/OR control +        * for checked tags and logical connections (AND
> > and Not Tagged checked => all other tags disabled) +        */
> >          SearchFieldCheckBox *field = new SearchFieldCheckBox(parent);
> >          field->setFieldName(name);
> >          field->setText(i18n("Tags"), i18n("Image has no tags"));
> > @@ -394,7 +396,9 @@
> >      }
> >      else if (name == "flashmode")
> >      {//choice
> > -        //TODO: This is a bitmask, and gives some more information
> > +        /**
> > +        * @todo This is a bitmask, and gives some more information
> > +        */
> >          SearchFieldChoice *field = new SearchFieldChoice(parent);
> >          field->setFieldName(name);
> >          field->setText(i18n("Flash"), i18n("Flash mode"));
> > @@ -1095,9 +1099,11 @@
> >          }
> >          else
> >          {
> > -            //TODO: This condition is never met.
> > -            // Right value is either displayed empty (minimum, greater
> > than left) -            // or one step larger than left
> > +            /**
> > +            * @todo : This condition is never met.
> > +            * Right value is either displayed empty (minimum, greater
> > than left) +            * or one step larger than left
> > +            */
> >              writer.writeField(m_name, SearchXml::Equal);
> >              if (m_reciprocal)
> >                  writer.writeValue(m_firstBox->fractionMagicValue());
> > --- trunk/extragear/graphics/digikam/utilities/setup/setupicc.cpp
> > #1067926:1067927 @@ -278,10 +278,14 @@
> >                                              "and to which color space it
> > shall be transformed for editing.</p>"));
> >
> >      d->defaultSRGBMissing = new QRadioButton(i18n("Assume it is using
> > the sRGB color space (Internet standard)")); -    //TODO
> > d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>")); +    /**
> > +     * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> > +     */
> >
> >      d->defaultSRGBConvert = new QCheckBox(i18n("and convert it to the
> > working color space")); -    //TODO d->defaultSRGBConvert->setWhatsThis(
> > i18n("<p></p>")); +    /**
> > +     * @todo d->defaultSRGBConvert->setWhatsThis( i18n("<p></p>"));
> > +     */
> >      d->defaultSRGBConvert->setChecked(true);
> >
> >      QGridLayout *gridRgb = new QGridLayout;
> > @@ -290,10 +294,14 @@
> >      gridRgb->setColumnMinimumWidth(0, 10);
> >
> >      d->defaultWSMissing  = new QRadioButton(i18n("Assume it is using the
> > working color space")); -    //TODO d->defaultWSMissing->setWhatsThis(
> > i18n("<p></p>")); +    /**
> > +     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> > +     */
> >
> >      d->defaultInputMissing = new QRadioButton(i18n("Convert it from
> > default input color space to working space")); -    //TODO
> > d->defaultWSMissing->setWhatsThis( i18n("<p></p>")); +    /**
> > +     * @todo d->defaultWSMissing->setWhatsThis( i18n("<p></p>"));
> > +     */
> >
> >      vlayMissing->addLayout(hboxMP);
> >      vlayMissing->addWidget(d->defaultAskMissing);
> > @@ -316,13 +324,19 @@
> >      hboxRF->addWidget(rawBehaviorLabel, 10);
> >
> >      d->defaultAskRaw   = new QRadioButton(i18n("Ask for the input
> > profile")); -    //TODO d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
> > +    /**
> > +    * @todo d->defaultAskRaw->setWhatsThis( i18n("<p></p>"));
> > +    */
> >
> >      d->defaultGuessRaw = new QRadioButton(i18n("Automatic color
> > correction")); -    //TODO d->defaultGuessRaw->setWhatsThis(
> > i18n("<p></p>"));
> > +    /**
> > +    * @todo d->defaultGuessRaw->setWhatsThis( i18n("<p></p>"));
> > +    */
> >
> >      d->defaultInputRaw = new QRadioButton(i18n("Convert it from the
> > default input profile")); -    //TODO
> > d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>")); +    /**
> > +    * @todo d->defaultSRGBMissing->setWhatsThis( i18n("<p></p>"));
> > +    */
> >
> >      d->defaultGuessRaw->setChecked(true);
> >
> > @@ -369,7 +383,9 @@
> >
> >      d->managedPreviews = new QCheckBox;
> >      d->managedPreviews->setText(i18n("Use color managed view for
> > previews and thumbnails")); -    //TODO d->managedPreview->setWhatsThis(
> > i18n("") );
> > +    /**
> > +    * @todo d->managedPreview->setWhatsThis( i18n("") );
> > +    */
> >
> >      gridView->addWidget(monitorIcon,            0, 0);
> >      gridView->addWidget(monitorProfiles,        0, 1, 1, 2);
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel