extragear/graphics/digikam

SVN commit 921944 by anaselli:

Added print management to ShowFoto.
Don't need to reinvent the wheel, so i used gwenview code - that is a great improvement of my old one :) Thanks Aurelien

CCMAIL:  [hidden email],  [hidden email]

 M  +10 -1     CMakeLists.txt  
 M  +1 -0      NEWS  
 M  +7 -0      digikam/CMakeLists.txt  
 M  +7 -7      utilities/imageeditor/editor/editorwindow.cpp  
 A             utilities/imageeditor/tools/digikamconfig.kcfg  
 A             utilities/imageeditor/tools/digikamconfig.kcfgc  
 D             utilities/imageeditor/tools/imageprint.cpp  
 D             utilities/imageeditor/tools/imageprint.h  
 AM            utilities/imageeditor/tools/printhelper.cpp   [License: GPL (v2+)]
 AM            utilities/imageeditor/tools/printhelper.h   [License: GPL (v2+)]
 AM            utilities/imageeditor/tools/printoptionspage.cpp   [License: GPL (v2+)]
 AM            utilities/imageeditor/tools/printoptionspage.h   [License: GPL (v2+)]
 A             utilities/imageeditor/tools/printoptionspage.ui  
 AM            utilities/imageeditor/tools/signalblocker.h   [License: GPL (v2+)]


--- trunk/extragear/graphics/digikam/CMakeLists.txt #921943:921944
@@ -559,10 +559,19 @@
        )
 
     SET(libdimgeditortools_SRCS
-        ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/imageprint.cpp
+        ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/printhelper.cpp  
+        ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/printoptionspage.cpp  
         ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/imageresize.cpp
        )
 
+#     KDE4_ADD_UI_FILES(libdimgeditortools_SRCS
+#         ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/printoptionspage.ui
+#        )
+#
+#     kde4_add_kcfg_files(libdimgeditortools_SRCS
+#         ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/tools/digikamconfig.kcfgc
+#        )
+
     SET(librawimport_SRCS
         ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/rawimport/rawpostprocessing.cpp
         ${CMAKE_CURRENT_SOURCE_DIR}/utilities/imageeditor/rawimport/rawimport.cpp
--- trunk/extragear/graphics/digikam/NEWS #921943:921944
@@ -4,6 +4,7 @@
 NEW FEATURES:
 
 General        : Sidebar type is configurable: title is visible for only active tab, or for all tabs.
+ShowFoto       : Added print management
 
 BUGFIXES FROM KDE BUGZILLA (alias B.K.O | http://bugs.kde.org):
 
--- trunk/extragear/graphics/digikam/digikam/CMakeLists.txt #921943:921944
@@ -93,6 +93,13 @@
                         ${librawimport_SRCS}
    )
 
+    KDE4_ADD_UI_FILES(digikamcore_LIB_SRCS
+        ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/imageeditor/tools/printoptionspage.ui
+       )
+
+    kde4_add_kcfg_files(digikamcore_LIB_SRCS
+        ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/imageeditor/tools/digikamconfig.kcfgc
+       )
 KDE4_ADD_LIBRARY(digikamcore SHARED ${digikamcore_LIB_SRCS})
 
 TARGET_LINK_LIBRARIES(digikamcore
--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #921943:921944
@@ -104,7 +104,6 @@
 #include "imagedialog.h"
 #include "imageplugin.h"
 #include "imagepluginloader.h"
-#include "imageprint.h"
 #include "imageresize.h"
 #include "iofilesettingscontainer.h"
 #include "libsinfodlg.h"
@@ -116,6 +115,7 @@
 #include "statusprogressbar.h"
 #include "themeengine.h"
 #include "thumbbar.h"
+#include "printhelper.h"
 
 namespace Digikam
 {
@@ -607,11 +607,6 @@
 
 void EditorWindow::printImage(KUrl /*url*/)
 {
-#ifndef Q_CC_MSVC
-#warning "TODO: KPrinter is disabled for KDE4.0";
-#endif
-
-/*
     uchar* ptr      = m_canvas->interface()->getImage();
     int w           = m_canvas->interface()->origWidth();
     int h           = m_canvas->interface()->origHeight();
@@ -623,6 +618,10 @@
 
     DImg image(w, h, sixteenBit, hasAlpha, ptr);
 
+    PrintHelper printHelp(this);
+    printHelp.print(image);
+
+    /*
     KPrinter printer;
     QString appName = KGlobal::mainComponent().aboutData()->appName();
     printer.setDocName( url.fileName() );
@@ -639,7 +638,8 @@
             KMessageBox::error(this, i18n("Failed to print file: '%1'",
                                url.fileName()));
         }
-    }*/
+    }
+    */
 }
 
 void EditorWindow::slotEditKeys()
** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/printhelper.cpp #property svn:eol-style
   + native
** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/printhelper.h #property svn:eol-style
   + native
** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/printoptionspage.cpp #property svn:eol-style
   + native
** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/printoptionspage.h #property svn:eol-style
   + native
** trunk/extragear/graphics/digikam/utilities/imageeditor/tools/signalblocker.h #property svn:eol-style
   + native
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Il venerdì 06 febbraio 2009 01:22:50 Angelo Naselli ha scritto:
> SVN commit 921944 by anaselli:
>
> Added print management to ShowFoto.
> Don't need to reinvent the wheel, so i used gwenview code - that is a great
> improvement of my old one :) Thanks Aurelien

I seem i can't  enable color management, so i'm not sure it works
under print options :/

Any help?

Thanks
--
Angelo


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

I take a look this morning.

Gilles

2009/2/6 Angelo Naselli <[hidden email]>

Il venerdì 06 febbraio 2009 01:22:50 Angelo Naselli ha scritto:

> SVN commit 921944 by anaselli:
>
> Added print management to ShowFoto.
> Don't need to reinvent the wheel, so i used gwenview code - that is a great
> improvement of my old one :) Thanks Aurelien

I seem i can't  enable color management, so i'm not sure it works
under print options :/

Any help?

Thanks
--
Angelo


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Angello,

Editor doesn't compile :

-- Configuring done
-- Generating done
-- Build files have been written to: /home/gilles/Documents/devel/SVN/trunk/graphics
[  0%] Built target svnversion
[  0%] Generating digikamconfig.h, digikamconfig.cpp
Generating printoptionspage.moc
[  0%] Generating ui_printoptionspage.h
Scanning dependencies of target digikamcore
[  0%] Building CXX object digikam/digikam/CMakeFiles/digikamcore.dir/digikamcore_automoc.o
[  0%] Building CXX object digikam/digikam/CMakeFiles/digikamcore.dir/__/utilities/imageeditor/tools/printhelper.o
[  0%] Building CXX object digikam/digikam/CMakeFiles/digikamcore.dir/__/utilities/imageeditor/tools/printoptionspage.o
[  0%] Building CXX object digikam/digikam/CMakeFiles/digikamcore.dir/__/utilities/imageeditor/editor/editorwindow.o
[  0%] Building CXX object digikam/digikam/CMakeFiles/digikamcore.dir/digikamconfig.o
Linking CXX shared library ../../lib/libdigikamcore.so
[ 12%] Built target digikamcore
Linking CXX shared library ../../lib/libdigikamdatabase.so
[ 17%] Built target digikamdatabase
Scanning dependencies of target digikam
[ 17%] Building CXX object digikam/digikam/CMakeFiles/digikam.dir/__/utilities/imageeditor/editor/imagewindow.o
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp:101:24: error: imageprint.h: No such file or directory
make[2]: *** [digikam/digikam/CMakeFiles/digikam.dir/__/utilities/imageeditor/editor/imagewindow.o] Error 1
make[1]: *** [digikam/digikam/CMakeFiles/digikam.dir/all] Error 2
make: *** [all] Error 2

[gilles@localhost graphics]$
[gilles@localhost editor]$

Gilles

2009/2/6 Gilles Caulier <[hidden email]>

I take a look this morning.

Gilles

2009/2/6 Angelo Naselli <[hidden email]>

Il venerdì 06 febbraio 2009 01:22:50 Angelo Naselli ha scritto:

> SVN commit 921944 by anaselli:
>
> Added print management to ShowFoto.
> Don't need to reinvent the wheel, so i used gwenview code - that is a great
> improvement of my old one :) Thanks Aurelien

I seem i can't  enable color management, so i'm not sure it works
under print options :/

Any help?

Thanks
--
Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

venerdì 06 febbraio 2009 alle 05:25, Gilles Caulier ha scritto:
---------------------------------------\^^^^\
Sorry i was sleeping at that time :)

> /home/gilles/Documents/devel/SVN/trunk/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp:101:24:
> error: imageprint.h: No such file or directory
ARGH! I've thought i had removed all the imageprint.h includes :/
Remove it and should be ok.
Sorry,
        Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/2/6 Angelo Naselli <[hidden email]>

venerdì 06 febbraio 2009 alle 05:25, Gilles Caulier ha scritto:
---------------------------------------\^^^^\
Sorry i was sleeping at that time :)

> /home/gilles/Documents/devel/SVN/trunk/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp:101:24:
> error: imageprint.h: No such file or directory

ARGH! I've thought i had removed all the imageprint.h includes :/
Remove it and should be ok.
Sorry,

yes, already done. its work...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> yes, already done. its work...
>
> Gilles
>
Great!
Gilles please can you contact i18n group to tell them i added new  strings?
I forgot to add them in CC :/

Moreover I'll try to see what i have to do in printwizard. I will contact you again
if i realize i need help to finish critical functionalities... I believe i need anyway :)

Angelo

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/2/6 Angelo Naselli <[hidden email]>

> yes, already done. its work...
>
> Gilles
>

Great!
Gilles please can you contact i18n group to tell them i added new  strings?
I forgot to add them in CC :/

Moreover I'll try to see what i have to do in printwizard. I will contact you again
if i realize i need help to finish critical functionalities... I believe i need anyway :)

i18n freeze have been delayed to rc2 (digiKam and kipi-plugins). So, no problem...

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel