extragear/graphics/digikam

[Gilles Caulier]

SVN commit 499561 by cgilles:

digikam from trunk : image properties side bar BUGFIX : When an album item is selected from main interface, and if "Comments & Tag" tab is selected, if this item is deleted, "Comments & Tags" tab been lost. This commit fix this problem to adding a new signal/slot connection to invalid image properties sidebar contents just before item deletion.
CCMAIL: [hidden email]



 M  +0 -3      TODO  
 M  +8 -0      digikam/digikamview.cpp  
 M  +1 -0      digikam/digikamview.h  


--- trunk/extragear/graphics/digikam/TODO #499560:499561
@@ -17,9 +17,6 @@
 
    - Added signal/slots control between IE and main interface about "comments & tags" tab.
      Comments & tags set from main must be updated in IE and vise-versa.
-   - There is a bug releavant of sidebar (?) implementation. when an album item is selected
-     from main interface, and if "Comments & Tag" tab is selected, if this item is deleted, "Comments
-     & Tags" tab is lost!
     
 * 16 bits/color/pixels support : Any Image plugins must be adapted. Current port status is listed below :
 
--- trunk/extragear/graphics/digikam/digikam/digikamview.cpp #499560:499561
@@ -144,6 +144,9 @@
 
     connect(mIconView, SIGNAL(signalItemsAdded()),
             this, SLOT(slot_albumHighlight()));
+
+    connect(mIconView, SIGNAL(signalItemDeleted(AlbumIconItem*)),
+            this, SLOT(slot_imageDeleted()));
     
     connect(mTagFolderView, SIGNAL(signalTagsAssigned()),
             mIconView->viewport(), SLOT(update()));
@@ -510,6 +513,11 @@
     emit signal_imageSelected(selected);
 }
 
+void DigikamView::slot_imageDeleted()
+{
+    mRightSidebar->noCurrentItem();
+}
+
 void DigikamView::slot_albumsCleared()
 {
     mIconView->clear();
--- trunk/extragear/graphics/digikam/digikam/digikamview.h #499560:499561
@@ -136,6 +136,7 @@
     void slotAllAlbumsLoaded();
     
     void slot_imageSelected();
+    void slot_imageDeleted();
 
     void slot_albumsCleared();
     void slot_albumHighlight();
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia środa, 18 stycznia 2006 09:51, Gilles Caulier napisał:
> SVN commit 499561 by cgilles:
>
> digikam from trunk : image properties side bar BUGFIX : When an album
> item is selected from main interface, and if "Comments & Tag" tab is
> selected, if this item is deleted, "Comments & Tags" tab been lost. This
> commit fix this problem to adding a new signal/slot connection to
> invalid image properties sidebar contents just before item deletion.

Yesss. Thanks. Very irritating and almost impossible to reproduce with
100% accuracy.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Mercredi 18 Janvier 2006 11:45, Mikolaj Machowski a écrit :

> Dnia środa, 18 stycznia 2006 09:51, Gilles Caulier napisał:
> > SVN commit 499561 by cgilles:
> >
> > digikam from trunk : image properties side bar BUGFIX : When an album
> > item is selected from main interface, and if "Comments & Tag" tab is
> > selected, if this item is deleted, "Comments & Tags" tab been lost. This
> > commit fix this problem to adding a new signal/slot connection to
> > invalid image properties sidebar contents just before item deletion.
>
> Yesss. Thanks. Very irritating and almost impossible to reproduce with
> 100% accuracy.
>

 
Mikolaj, this is fix all your problem with image properties side bar (excepted
current album items selection : still TODO) ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia środa, 18 stycznia 2006 21:29, Caulier Gilles napisał:

> Le Mercredi 18 Janvier 2006 11:45, Mikolaj Machowski a écrit :
> > Dnia środa, 18 stycznia 2006 09:51, Gilles Caulier napisał:
> > > SVN commit 499561 by cgilles:
> > >
> > > digikam from trunk : image properties side bar BUGFIX : When an
> > > album item is selected from main interface, and if "Comments & Tag"
> > > tab is selected, if this item is deleted, "Comments & Tags" tab been
> > > lost. This commit fix this problem to adding a new signal/slot
> > > connection to invalid image properties sidebar contents just before
> > > item deletion.
> >
> > Yesss. Thanks. Very irritating and almost impossible to reproduce with
> > 100% accuracy.
>
> Mikolaj, this is fix all your problem with image properties side bar
> (excepted current album items selection : still TODO) ?

Still two problems:

1. Where is old fashioned file properties info (name change, owner,
   weight, etc.)?
2. Sometimes, when clearing selection with clicking on canvas and with
   opened sidebar, digiKam crashes. Don't have current backtraces
   unfortunately.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Jeudi 19 Janvier 2006 00:32, Mikolaj Machowski a écrit :

> Dnia środa, 18 stycznia 2006 21:29, Caulier Gilles napisał:
> > Le Mercredi 18 Janvier 2006 11:45, Mikolaj Machowski a écrit :
> > > Dnia środa, 18 stycznia 2006 09:51, Gilles Caulier napisał:
> > > > SVN commit 499561 by cgilles:
> > > >
> > > > digikam from trunk : image properties side bar BUGFIX : When an
> > > > album item is selected from main interface, and if "Comments & Tag"
> > > > tab is selected, if this item is deleted, "Comments & Tags" tab been
> > > > lost. This commit fix this problem to adding a new signal/slot
> > > > connection to invalid image properties sidebar contents just before
> > > > item deletion.
> > >
> > > Yesss. Thanks. Very irritating and almost impossible to reproduce with
> > > 100% accuracy.
> >
> > Mikolaj, this is fix all your problem with image properties side bar
> > (excepted current album items selection : still TODO) ?
>
> Still two problems:
>
> 1. Where is old fashioned file properties info (name change, owner,
>    weight, etc.)?

well, this tab have been removed after talking with the team, because it's
redondant with album item tool tip informations.

> 2. Sometimes, when clearing selection with clicking on canvas and with
>    opened sidebar, digiKam crashes. Don't have current backtraces
>    unfortunately.

I can't reproduce this bug here...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Dnia czwartek, 19 stycznia 2006 07:49, Gilles Caulier napisał:
> > 1. Where is old fashioned file properties info (name change, owner,
> >    weight, etc.)?
>
> well, this tab have been removed after talking with the team, because
> it's redondant with album item tool tip informations.

1. Tool tip requires excessive use of mouse - bad for accessibility. BTW,
   what about keyboard navigation across for tabs? Don't see way to
   choose/open/close tabs with keyboard.
2. With properties dialog/tab was possibility to change name of image in
IE.
3. Tool tip can be disabled and there will be no info.

Maybe an option: tool tip OR properties tab?

> > 2. Sometimes, when clearing selection with clicking on canvas and with
> >    opened sidebar, digiKam crashes. Don't have current backtraces
> >    unfortunately.
>
> I can't reproduce this bug here...

Yeah. I know, it happens rarely. Maybe was fixed in meantime.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Jeudi 19 Janvier 2006 11:09, Mikolaj Machowski a écrit :

> Dnia czwartek, 19 stycznia 2006 07:49, Gilles Caulier napisał:
> > > 1. Where is old fashioned file properties info (name change, owner,
> > >    weight, etc.)?
> >
> > well, this tab have been removed after talking with the team, because
> > it's redondant with album item tool tip informations.
>
> 1. Tool tip requires excessive use of mouse - bad for accessibility. BTW,
>    what about keyboard navigation across for tabs? Don't see way to
>    choose/open/close tabs with keyboard.
> 2. With properties dialog/tab was possibility to change name of image in
> IE.
> 3. Tool tip can be disabled and there will be no info.
>
> Maybe an option: tool tip OR properties tab?

This point must be discuted with other developers. Any viewpoints welcome...

>
> > > 2. Sometimes, when clearing selection with clicking on canvas and with
> > >    opened sidebar, digiKam crashes. Don't have current backtraces
> > >    unfortunately.
> >
> > I can't reproduce this bug here...
>
> Yeah. I know, it happens rarely. Maybe was fixed in meantime.

I suspect a problem of temp lib in building. I have seen this problem here
since digkam 0.9.0 is under development. I recommend you to purge and rebuild
all periodicly.

--
Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Murphy, James (Tech)]

Just tried 8.1 last night seems to work faster but did we lose functionality, also I didn't upgrade the plugins kipi and digikam, do I need to upgrade those plugins?

-----Original Message-----
From: Mikolaj Machowski [mailto:[hidden email]]
Sent: Thursday, January 19, 2006 5:10 AM
To: [hidden email]
Subject: Re: [Digikam-devel] extragear/graphics/digikam

Dnia czwartek, 19 stycznia 2006 07:49, Gilles Caulier napisał:
> > 1. Where is old fashioned file properties info (name change, owner,
> >    weight, etc.)?
>
> well, this tab have been removed after talking with the team, because
> it's redondant with album item tool tip informations.

1. Tool tip requires excessive use of mouse - bad for accessibility. BTW,
   what about keyboard navigation across for tabs? Don't see way to
   choose/open/close tabs with keyboard.
2. With properties dialog/tab was possibility to change name of image in
IE.
3. Tool tip can be disabled and there will be no info.

Maybe an option: tool tip OR properties tab?

> > 2. Sometimes, when clearing selection with clicking on canvas and with
> >    opened sidebar, digiKam crashes. Don't have current backtraces
> >    unfortunately.
>
> I can't reproduce this bug here...

Yeah. I know, it happens rarely. Maybe was fixed in meantime.

m.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Jeudi 19 Janvier 2006 14:01, Murphy, James (Tech) a écrit :
> Just tried 8.1 last night seems to work faster but did we lose
> functionality, also I didn't upgrade the plugins kipi and digikam, do I
> need to upgrade those plugins?
>

You can update kipi plugins without problem. there is no depencies between
current digikam core changes and kipi-plugins.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel