extragear/graphics/digikam/libs/widgets

[Gilles Caulier]

SVN commit 497567 by cgilles:

digikam from trunk : CIE tongue widget :
- polish implementation more C++ like.
- more data are include in internal private class to reduce time compilation and limited visibility of private items. This way reducing time compilation.

To the team : we need to use always a private internal class to inclide all private data when its possible. I will fix any codes in this way in the future in digikam/libs.

CCMAIL: [hidden email]


 M  +77 -70    cietonguewidget.cpp  
 M  +1 -14     cietonguewidget.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Friday 13 January 2006 08:15, Gilles Caulier wrote:
> SVN commit 497567 by cgilles:
>
> digikam from trunk : CIE tongue widget :
> - polish implementation more C++ like.
> - more data are include in internal private class to reduce time compilation and limited visibility of private items. This way reducing time compilation.
>
> To the team : we need to use always a private internal class to inclide all private data when its possible. I will fix any codes in this way in the future in digikam/libs.

Just some thoughts that jump to my mind.  They may be
complete nonsense.

Doesn't this make backporting to stable branch
even more complicated?  _Maybe_ if it does not distrub
your work on trunk, can this be delayed until later in
0.9 development?

Curious:
  Are symbols in internal classes resolved like with the
  visibility feature to speed up loading libraries too?

  does this imply a more recent g++ version than before?

Achim
>
> CCMAIL: [hidden email]
>
>
>  M  +77 -70    cietonguewidget.cpp  
>  M  +1 -14     cietonguewidget.h  
>
>
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Vendredi 13 Janvier 2006 10:13, Achim Bohnet a écrit :

> On Friday 13 January 2006 08:15, Gilles Caulier wrote:
> > SVN commit 497567 by cgilles:
> >
> > digikam from trunk : CIE tongue widget :
> > - polish implementation more C++ like.
> > - more data are include in internal private class to reduce time
> > compilation and limited visibility of private items. This way reducing
> > time compilation.
> >
> > To the team : we need to use always a private internal class to inclide
> > all private data when its possible. I will fix any codes in this way in
> > the future in digikam/libs.
>
> Just some thoughts that jump to my mind.  They may be
> complete nonsense.
>
> Doesn't this make backporting to stable branch
> even more complicated?

no. It's just to move private class data from header file to implementation
file

> _Maybe_ if it does not distrub
> your work on trunk, can this be delayed until later in
> 0.9 development?

Sure, it can be done only on new implementation

>
> Curious:
>   Are symbols in internal classes resolved like with the
>   visibility feature to speed up loading libraries too?
>
>   does this imply a more recent g++ version than before?

no. It's a standard KDE developement tip since a long time.

>
> Achim
>
> > CCMAIL: [hidden email]
> >
> >
> >  M  +77 -70    cietonguewidget.cpp
> >  M  +1 -14     cietonguewidget.h

--
Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel