extragear/graphics/digikam/libs/widgets/imageplugins

[Gilles Caulier-4]

SVN commit 654897 by cgilles:

digikam from trunk : Important improvements here !

The zoom functions available on image editor plugins have been completly rewritten. We use now the new common preview widget. The plugins affected by these changes are Noise Reduction, Restoration, Sharpen, Gaussian Blur, Hot Pixels, Infrared Film, Oil Paint, Emboss, Film Grain, Blur FX, and Charcoal.

Let's me explain the difference between the old an new implementations.

With old stuff, the zoom function is very limited :

- zoom factors from x1 to x3 with step 0.5
- huge memory allocation duing to pre-zoomed picture rendering.
- very slow.
- Can frozen the computer when swap is require (with huge pictures)
- Effect rendering is computed on a redimentionned part of image. It Slow

The new zoom function is completly different :

- Zoom factors from x1 to x12. Free value can be set.
- No more memory allocation. You can use it with huge pictures. No swap is require.
- Zooming/paning is based on new common preview widget witch use a QPixmap cache in memory.
- It's very very fast to change zoom. Can be done in live.
- Effect is computed on crop 1:1 image. render is more fast.

Note : the mouse handling to pan/zoom in preview pannel is the same than Image Editor Canvas and Preview Mode from Album Gui.

With Urls given below, you can see the Sharpen Tool in action using the new implementation. Note the new zoom slider on the bottom/left of dialog.

http://digikam3rdparty.free.fr/Screenshots/digikam0.9.2-newimagepluginszoomfunction1.png
http://digikam3rdparty.free.fr/Screenshots/digikam0.9.2-newimagepluginszoomfunction2.png

You will seen than it's now a real pleasure to navigate over the image to test an effect...

CCMAIL: [hidden email]




 M  +80 -96    imagepannelwidget.cpp  
 M  +19 -19    imagepannelwidget.h  
 M  +207 -241  imageregionwidget.cpp  
 M  +21 -24    imageregionwidget.h  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gerhard Kulzer]

Am Tuesday 17 April 2007 schrieb Gilles Caulier:
> SVN commit 654897 by cgilles:
>
> digikam from trunk : Important improvements here !
>
> The zoom functions available on image editor plugins have been completly
> rewritten. We use now the new common preview widget. The plugins affected
> by these changes are Noise Reduction, Restoration, Sharpen, Gaussian Blur,
> Hot Pixels, Infrared Film, Oil Paint, Emboss, Film Grain, Blur FX, and
> Charcoal.
That's really great Gilles, that's the way it should work.
I'll reflect it in the documentation.

Gerhard

> Let's me explain the difference between the old an new implementations.
>
> With old stuff, the zoom function is very limited :
>
> - zoom factors from x1 to x3 with step 0.5
> - huge memory allocation duing to pre-zoomed picture rendering.
> - very slow.
> - Can frozen the computer when swap is require (with huge pictures)
> - Effect rendering is computed on a redimentionned part of image. It Slow
>
> The new zoom function is completly different :
>
> - Zoom factors from x1 to x12. Free value can be set.
> - No more memory allocation. You can use it with huge pictures. No swap is
> require. - Zooming/paning is based on new common preview widget witch use a
> QPixmap cache in memory. - It's very very fast to change zoom. Can be done
> in live.
> - Effect is computed on crop 1:1 image. render is more fast.
>
> Note : the mouse handling to pan/zoom in preview pannel is the same than
> Image Editor Canvas and Preview Mode from Album Gui.
>
> With Urls given below, you can see the Sharpen Tool in action using the new
> implementation. Note the new zoom slider on the bottom/left of dialog.
>
> http://digikam3rdparty.free.fr/Screenshots/digikam0.9.2-newimagepluginszoom
>function1.png
> http://digikam3rdparty.free.fr/Screenshots/digikam0.9.2-newimagepluginszoom
>function2.png
>
> You will seen than it's now a real pleasure to navigate over the image to
> test an effect...
>
> CCMAIL: [hidden email]
>
>
>
>
>  M  +80 -96    imagepannelwidget.cpp
>  M  +19 -19    imagepannelwidget.h
>  M  +207 -241  imageregionwidget.cpp
>  M  +21 -24    imageregionwidget.h
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

--
Hakuna matata
http://www.gerhard.fr

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

On Tue, 17 Apr 2007, Gilles Caulier wrote:

> You will seen than it's now a real pleasure to navigate over the image to test an effect...

Yes, this is pure pleasure now - brilliant - many thanks!!

Some small points:

> - Zoom factors from x1 to x12. Free value can be set.

  where can this be done? (I did not find it,
  also 300% was the maximum I got with the slider?)

  Ah: it seems that it depends on the image size:
  for an 8 MP pixel the maximal zoom (in %) was smaller
  than for a smaller image.

- For Restauration (for example), when no filtering has been
  specified yet, a larger area than the selection
  is shown, ranging into the target area.
  Maybe the right-hand corners are not taken into account?
  (could maybe give another small speed-up? ;-).

- when zooming in maximally,
  there seems to be some interpolation to happen.
  It would be nice to have an option to switch off interpolation.

- When zooming in with the slider: it would be nice
  if the center of the box stays fixed
  (Reason: Usually one moves the box to some region with the part
   of interest being in the middle, so subsequent zooming
   would keep that object in view)

Now that this works so extremely well, could
one also use the original image for the View mode in the Album view?
(Maybe loaded in a background thread, or only from a certain
zoom level on?

Best, Arnd

P.S.: where is the lighttable - it's gone out of the side menue??... ;-)

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2007/4/17, Arnd Baecker <[hidden email]>:

On Tue, 17 Apr 2007, Gilles Caulier wrote:

> You will seen than it's now a real pleasure to navigate over the image to test an effect...

Yes, this is pure pleasure now - brilliant - many thanks!!

Some small points:

> - Zoom factors from x1 to x12. Free value can be set.

  where can this be done? (I did not find it,
  also 300% was the maximum I got with the slider?)

  Ah: it seems that it depends on the image size:
  for an 8 MP pixel the maximal zoom (in %) was smaller
  than for a smaller image.

x1 == minzoom value
x12 == minzoomvalue x 12
 

- For Restauration (for example), when no filtering has been
  specified yet, a larger area than the selection
  is shown, ranging into the target area.
  Maybe the right-hand corners are not taken into account?
  (could maybe give another small speed-up? ;-).

i will take a look
 

- when zooming in maximally,
  there seems to be some interpolation to happen.
  It would be nice to have an option to switch off interpolation.

Real pixel based scaling is currently implementation by Antonio.

Antonio, what's news ?

 

- When zooming in with the slider: it would be nice

  if the center of the box stays fixed
  (Reason: Usually one moves the box to some region with the part
   of interest being in the middle, so subsequent zooming
   would keep that object in view)

Yes, i will take a look
 

Now that this works so extremely well, could
one also use the original image for the View mode in the Album view?

(Maybe loaded in a background thread, or only from a certain
zoom level on?

no, the original image is displayed by editor, using Color Management. Preview still a fast mode sithout using CM.
 

Best, Arnd

P.S.: where is the lighttable - it's gone out of the side menue??... ;-)

Talking by IRC with Paco and Luka about LT, i have deleguate this implementation...

Paco, Luke, what's news ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel