extragear/graphics/digikam/libs/dimg

[Marcel Wiesweg]

SVN commit 512791 by mwiesweg:

digikam from trunk: HSL modifier
- DColor, getHSL and setRGB
    - remove hardcoded 255.0 values
    - fix wrong assignment of variable in setRGB
      (use double value hue in 0..360, not int h in 0..255)
- HSLMOdifier
    - use mathematically simplified version of algorithm in setLightness and setSaturation,
      old version had integer overflows with 16 bit and rounding errors
    - in setLightness, the value range was -200..200, while it is -100..100 in setSaturation
      and in the widget. Changed this to use range -100..100.
- use lround instead of truncating to int in BCGModifier, HSLModifier

Please test if the HSL filter now has the desired effect for both 8 bit and 16 bit.
CCMAIL:[hidden email]



 M  +90 -77    dcolor.cpp  
 M  +11 -9     filters/bcgmodifier.cpp  
 M  +74 -22    filters/hslmodifier.cpp  


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Jeudi 23 Février 2006 17:27, Marcel Wiesweg a écrit :

> SVN commit 512791 by mwiesweg:
>
> digikam from trunk: HSL modifier
> - DColor, getHSL and setRGB
>     - remove hardcoded 255.0 values
>     - fix wrong assignment of variable in setRGB
>       (use double value hue in 0..360, not int h in 0..255)
> - HSLMOdifier
>     - use mathematically simplified version of algorithm in setLightness
> and setSaturation, old version had integer overflows with 16 bit and
> rounding errors - in setLightness, the value range was -200..200, while it
> is -100..100 in setSaturation and in the widget. Changed this to use range
> -100..100.
> - use lround instead of truncating to int in BCGModifier, HSLModifier
>
> Please test if the HSL filter now has the desired effect for both 8 bit and
> 16 bit. CCMAIL:[hidden email]

Incredible. HSL tool work fine now with 16 bits images. Great job Marcel.
Thanks...

But The other part witch used HSL modifier algorithm is Image Editor Black &
White converter. Any B&W converter options are broken :

- Sepia tone.
- Brown Tone.
- Cold Tone.
- Selenium Tone.
- Platinium Tone.

I think that the B&W implementations must be adapted to your patch...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 24 Février 2006 07:51, Gilles Caulier a écrit :

> Le Jeudi 23 Février 2006 17:27, Marcel Wiesweg a écrit :
> > SVN commit 512791 by mwiesweg:
> >
> > digikam from trunk: HSL modifier
> > - DColor, getHSL and setRGB
> >     - remove hardcoded 255.0 values
> >     - fix wrong assignment of variable in setRGB
> >       (use double value hue in 0..360, not int h in 0..255)
> > - HSLMOdifier
> >     - use mathematically simplified version of algorithm in setLightness
> > and setSaturation, old version had integer overflows with 16 bit and
> > rounding errors - in setLightness, the value range was -200..200, while
> > it is -100..100 in setSaturation and in the widget. Changed this to use
> > range -100..100.
> > - use lround instead of truncating to int in BCGModifier, HSLModifier
> >
> > Please test if the HSL filter now has the desired effect for both 8 bit
> > and 16 bit. CCMAIL:[hidden email]
>
> Incredible. HSL tool work fine now with 16 bits images. Great job Marcel.
> Thanks...

An i forget to say that i'm happy to see a mathematician in the team. Thanks
again Marcel.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 24 Février 2006 07:51, Gilles Caulier a écrit :

> Le Jeudi 23 Février 2006 17:27, Marcel Wiesweg a écrit :
> > SVN commit 512791 by mwiesweg:
> >
> > digikam from trunk: HSL modifier
> > - DColor, getHSL and setRGB
> >     - remove hardcoded 255.0 values
> >     - fix wrong assignment of variable in setRGB
> >       (use double value hue in 0..360, not int h in 0..255)
> > - HSLMOdifier
> >     - use mathematically simplified version of algorithm in setLightness
> > and setSaturation, old version had integer overflows with 16 bit and
> > rounding errors - in setLightness, the value range was -200..200, while
> > it is -100..100 in setSaturation and in the widget. Changed this to use
> > range -100..100.
> > - use lround instead of truncating to int in BCGModifier, HSLModifier
> >
> > Please test if the HSL filter now has the desired effect for both 8 bit
> > and 16 bit. CCMAIL:[hidden email]
>
> Incredible. HSL tool work fine now with 16 bits images. Great job Marcel.
> Thanks...
>
> But The other part witch used HSL modifier algorithm is Image Editor Black
> & White converter. Any B&W converter options are broken :
>
> - Sepia tone.
> - Brown Tone.
> - Cold Tone.
> - Selenium Tone.
> - Platinium Tone.
>
> I think that the B&W implementations must be adapted to your patch...
>

Fixed in svn (:=)))...

Now all image plugins from digikam core are ported to 16 bits.

Marcel, the next stage to complete digiKam 0.9.0 package about 16 bits image
support is the non-ported to Dimg tools from DigikamImagePlugins (look in
digiKam README for the list)

Are you interressed to help me about ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 24 Février 2006 13:12, Gilles Caulier a écrit :

> Le Vendredi 24 Février 2006 07:51, Gilles Caulier a écrit :
> > Le Jeudi 23 Février 2006 17:27, Marcel Wiesweg a écrit :
> > > SVN commit 512791 by mwiesweg:
> > >
> > > digikam from trunk: HSL modifier
> > > - DColor, getHSL and setRGB
> > >     - remove hardcoded 255.0 values
> > >     - fix wrong assignment of variable in setRGB
> > >       (use double value hue in 0..360, not int h in 0..255)
> > > - HSLMOdifier
> > >     - use mathematically simplified version of algorithm in
> > > setLightness and setSaturation, old version had integer overflows with
> > > 16 bit and rounding errors - in setLightness, the value range was
> > > -200..200, while it is -100..100 in setSaturation and in the widget.
> > > Changed this to use range -100..100.
> > > - use lround instead of truncating to int in BCGModifier, HSLModifier
> > >
> > > Please test if the HSL filter now has the desired effect for both 8 bit
> > > and 16 bit. CCMAIL:[hidden email]
> >
> > Incredible. HSL tool work fine now with 16 bits images. Great job Marcel.
> > Thanks...
> >
> > But The other part witch used HSL modifier algorithm is Image Editor
> > Black & White converter. Any B&W converter options are broken :
> >
> > - Sepia tone.
> > - Brown Tone.
> > - Cold Tone.
> > - Selenium Tone.
> > - Platinium Tone.
> >
> > I think that the B&W implementations must be adapted to your patch...
>
> Fixed in svn (:=)))...
>
> Now all image plugins from digikam core are ported to 16 bits.
>
> Marcel, the next stage to complete digiKam 0.9.0 package about 16 bits
> image support is the non-ported to Dimg tools from DigikamImagePlugins
> (look in digiKam README for the list)

Not README file, but TODO (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Fixed in svn (:=)))...
>
> Now all image plugins from digikam core are ported to 16 bits.
>
> Marcel, the next stage to complete digiKam 0.9.0 package about 16 bits
> image support is the non-ported to Dimg tools from DigikamImagePlugins
> (look in digiKam README for the list)
>
> Are you interressed to help me about ?

Yes, I can help you. I will have a look at the missing plugins. Which plugin
to start with, any special considerations?

I think the threaded loading stuff is almost finished, only thing I am aware
of I have forgot is preloading in dimginterface, but that should only be a
few lines.

>
> An i forget to say that i'm happy to see a mathematician in the team.
> Thanks again Marcel.

Well I am certainly not a mathematician, it was rather taking a piece of paper
and a pencil, writing down and simplifying the formula, and being lucky that
the resulting term was actually better suited for computation than the
original one :-)

Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Vendredi 24 Février 2006 19:23, Marcel Wiesweg a écrit :
> Yes, I can help you. I will have a look at the missing plugins. Which
> plugin to start with, any special considerations?

I will update the DigikamImagePlugins TODO file with all informations/tasks to
do for 0.9.0 release. Any plugins will be simple to update, others need to be
rewritted about algorithms.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 25 Février 2006 09:36, Gilles Caulier a écrit :
> Le Vendredi 24 Février 2006 19:23, Marcel Wiesweg a écrit :
> > Yes, I can help you. I will have a look at the missing plugins. Which
> > plugin to start with, any special considerations?
>
> I will update the DigikamImagePlugins TODO file with all informations/tasks
> to do for 0.9.0 release. Any plugins will be simple to update, others need
> to be rewritted about algorithms.
>

Done on svn. Please let's me hear your choise and If you need more
informations about.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

Am Samstag 25 Februar 2006 12:33 schrieb Gilles Caulier:

> Le Samedi 25 Février 2006 09:36, Gilles Caulier a écrit :
> > Le Vendredi 24 Février 2006 19:23, Marcel Wiesweg a écrit :
> > > Yes, I can help you. I will have a look at the missing plugins. Which
> > > plugin to start with, any special considerations?
> >
> > I will update the DigikamImagePlugins TODO file with all
> > informations/tasks to do for 0.9.0 release. Any plugins will be simple to
> > update, others need to be rewritted about algorithms.
>
> Done on svn. Please let's me hear your choise and If you need more
> informations about.
>

Ok, since I am pretty indifferent about which plugins I port I will start with
the topmost "easy" one which is Add Border, then the next one on the list is
BlurFX.
I have no experience with backporting or rewriting algorithms, so I won't do
Charcoal, Superimpose, Unsharp, Perspective, Noise reduction.

What needs to be ported except for the actual 16-bits data handling and
replacing QImage with DImg?
I understand that ImageGuideDialog becomes DIgikam::ImageGuideDlg and
CtrlPanelDialog Digikam::CtrlPanelDlg, does this change require any
substantial changes in the UI code?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 25 Février 2006 18:56, Marcel Wiesweg a écrit :

> Am Samstag 25 Februar 2006 12:33 schrieb Gilles Caulier:
> > Le Samedi 25 Février 2006 09:36, Gilles Caulier a écrit :
> > > Le Vendredi 24 Février 2006 19:23, Marcel Wiesweg a écrit :
> > > > Yes, I can help you. I will have a look at the missing plugins. Which
> > > > plugin to start with, any special considerations?
> > >
> > > I will update the DigikamImagePlugins TODO file with all
> > > informations/tasks to do for 0.9.0 release. Any plugins will be simple
> > > to update, others need to be rewritted about algorithms.
> >
> > Done on svn. Please let's me hear your choise and If you need more
> > informations about.
>
> Ok, since I am pretty indifferent about which plugins I port I will start
> with the topmost "easy" one which is Add Border, then the next one on the
> list is BlurFX.

I have updated TODO list by difficulty order.

> I have no experience with backporting or rewriting algorithms, so I won't
> do Charcoal, Superimpose, Unsharp, Perspective, Noise reduction.

I will do Charcoal, Unsharp and Noise Reduction.

About SuperImpose, the plugin widget must be fixed accordinly with Achim B.K.O
files. There is no backport. It's pure Qt widget implementation to do using
QPixmap.

About Perspective, the algorithm must be ported to 16 bits. there is no
backport to do.

>
> What needs to be ported except for the actual 16-bits data handling and
> replacing QImage with DImg?

Yes, especially about render algorithm. Widget rendering don't need to support
16 bits mode. There is just an interface to do. Take a look in already ported
plugin like refocus for example.

> I understand that ImageGuideDialog becomes DIgikam::ImageGuideDlg and
> CtrlPanelDialog Digikam::CtrlPanelDlg, does this change require any
> substantial changes in the UI code?

DigikamImagePlugins::ImageGuideDialog and DigikamImagePlugins::CtrlPanelDialog  
are obsolete now. dialog from digiKam core must be used instead.

In the same time, Digikam::DImgImageFilters must be used instead
Digikam::ImageFilters. For example, Blur algorithm is used in any
DigikamimagePlugins tools like Infrared. This is want mean that
digikam/libs/filters will be removed before to release 0.9.0.

About changes in the UI code, I can do it in a plugins to give an example. I
can prepare 'Add Border' tool or Blur FX' to about this point if you want.

About 'Add Border' tool, i have forget to said that we need to fix algorithm
to preserve original image aspect ratio when a border is add to image (I have
any requests from users about this point).

Gilless
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I have updated TODO list by difficulty order.
>
> I will do Charcoal, Unsharp and Noise Reduction.

Ok, I will work on the list from top to bottom.

>
> About SuperImpose, the plugin widget must be fixed accordinly with Achim
> B.K.O files. There is no backport. It's pure Qt widget implementation to do
> using QPixmap.
>
> About Perspective, the algorithm must be ported to 16 bits. there is no
> backport to do.
>
> > What needs to be ported except for the actual 16-bits data handling and
> > replacing QImage with DImg?
>
> Yes, especially about render algorithm. Widget rendering don't need to
> support 16 bits mode. There is just an interface to do. Take a look in
> already ported plugin like refocus for example.
>
> > I understand that ImageGuideDialog becomes DIgikam::ImageGuideDlg and
> > CtrlPanelDialog Digikam::CtrlPanelDlg, does this change require any
> > substantial changes in the UI code?
>
> DigikamImagePlugins::ImageGuideDialog and
> DigikamImagePlugins::CtrlPanelDialog are obsolete now. dialog from digiKam
> core must be used instead.
>
> In the same time, Digikam::DImgImageFilters must be used instead
> Digikam::ImageFilters. For example, Blur algorithm is used in any
> DigikamimagePlugins tools like Infrared. This is want mean that
> digikam/libs/filters will be removed before to release 0.9.0.
>
> About changes in the UI code, I can do it in a plugins to give an example.
> I can prepare 'Add Border' tool or Blur FX' to about this point if you
> want.

I just committed my port of the Add Border plugin. I mostly took Refocus as an
example, and so far it works. I hope I got everything right.

>
> About 'Add Border' tool, i have forget to said that we need to fix
> algorithm to preserve original image aspect ratio when a border is add to
> image (I have any requests from users about this point).
>
> Gilless
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Lundi 27 Février 2006 23:43, Marcel Wiesweg a écrit :

> > I have updated TODO list by difficulty order.
> >
> > I will do Charcoal, Unsharp and Noise Reduction.
>
> Ok, I will work on the list from top to bottom.
>
> > About SuperImpose, the plugin widget must be fixed accordinly with Achim
> > B.K.O files. There is no backport. It's pure Qt widget implementation to
> > do using QPixmap.
> >
> > About Perspective, the algorithm must be ported to 16 bits. there is no
> > backport to do.
> >
> > > What needs to be ported except for the actual 16-bits data handling and
> > > replacing QImage with DImg?
> >
> > Yes, especially about render algorithm. Widget rendering don't need to
> > support 16 bits mode. There is just an interface to do. Take a look in
> > already ported plugin like refocus for example.
> >
> > > I understand that ImageGuideDialog becomes DIgikam::ImageGuideDlg and
> > > CtrlPanelDialog Digikam::CtrlPanelDlg, does this change require any
> > > substantial changes in the UI code?
> >
> > DigikamImagePlugins::ImageGuideDialog and
> > DigikamImagePlugins::CtrlPanelDialog are obsolete now. dialog from
> > digiKam core must be used instead.
> >
> > In the same time, Digikam::DImgImageFilters must be used instead
> > Digikam::ImageFilters. For example, Blur algorithm is used in any
> > DigikamimagePlugins tools like Infrared. This is want mean that
> > digikam/libs/filters will be removed before to release 0.9.0.
> >
> > About changes in the UI code, I can do it in a plugins to give an
> > example. I can prepare 'Add Border' tool or Blur FX' to about this point
> > if you want.
>
> I just committed my port of the Add Border plugin. I mostly took Refocus as
> an example, and so far it works. I hope I got everything right.

ok, i will take a look.

Gilles

>
> > About 'Add Border' tool, i have forget to said that we need to fix
> > algorithm to preserve original image aspect ratio when a border is add to
> > image (I have any requests from users about this point).
> >
> > Gilless
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel