extragear/graphics/digikam/libs/dimg/filters

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

extragear/graphics/digikam/libs/dimg/filters

Gilles Caulier
SVN commit 513066 by cgilles:

digikam from trunk : fix changeTonality algorithm accordinly with last HSLModifier changes from Marcel.
Now all image plugins from digiKam core are ported to 16 bits and work fine !!! (Champagne ?)

CCMAIL: [hidden email]

 M  +7 -7      dimgimagefilters.cpp  


--- trunk/extragear/graphics/digikam/libs/dimg/filters/dimgimagefilters.cpp #513065:513066
@@ -813,9 +813,9 @@
             
             mask.setRGB(hue, sat, lig, sixteenBit);
 
-            ptr[0] = mask.blue();
-            ptr[1] = mask.green();
-            ptr[2] = mask.red();
+            ptr[0] = (uchar)mask.blue();
+            ptr[1] = (uchar)mask.green();
+            ptr[2] = (uchar)mask.red();
             ptr += 4;
         }
     }
@@ -827,13 +827,13 @@
         {
             // Convert to grayscale using tonal mask
                 
-            lig = ROUND (0.3 * ptr[2] + 0.59 * ptr[1] + 0.11 * ptr[0])/256;
+            lig = ROUND (0.3 * ptr[2] + 0.59 * ptr[1] + 0.11 * ptr[0]);
             
             mask.setRGB(hue, sat, lig, sixteenBit);
                                 
-            ptr[0] = mask.blue();
-            ptr[1] = mask.green();
-            ptr[2] = mask.red();
+            ptr[0] = (unsigned short)mask.blue();
+            ptr[1] = (unsigned short)mask.green();
+            ptr[2] = (unsigned short)mask.red();
             ptr += 4;
         }
     }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikam/libs/dimg/filters

F.J.Cruz
El Viernes, 24 de Febrero de 2006 13:09, Gilles Caulier escribió:
> SVN commit 513066 by cgilles:
>
> digikam from trunk : fix changeTonality algorithm accordinly with last
> HSLModifier changes from Marcel. Now all image plugins from digiKam core
> are ported to 16 bits and work fine !!! (Champagne ?)
>

Of course!!.....Salud!! ;-)

Paco
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikam/libs/dimg/filters

Gilles Caulier-2
Le Vendredi 24 Février 2006 16:45, F.J.Cruz a écrit :

> El Viernes, 24 de Febrero de 2006 13:09, Gilles Caulier escribió:
> > SVN commit 513066 by cgilles:
> >
> > digikam from trunk : fix changeTonality algorithm accordinly with last
> > HSLModifier changes from Marcel. Now all image plugins from digiKam core
> > are ported to 16 bits and work fine !!! (Champagne ?)
>
> Of course!!.....Salud!! ;-)
>
> Paco

Paco, we will finalize ICC profile management next week because I'm out of
town this week end.... We will trying to solve all the problem that you have
annoted in you last e-mail.

Right for you ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] extragear/graphics/digikam/libs/dimg/filters

F.J.Cruz
El Viernes, 24 de Febrero de 2006 16:44, Gilles Caulier escribió:

> Le Vendredi 24 Février 2006 16:45, F.J.Cruz a écrit :
> > El Viernes, 24 de Febrero de 2006 13:09, Gilles Caulier escribió:
> > > SVN commit 513066 by cgilles:
> > >
> > > digikam from trunk : fix changeTonality algorithm accordinly with last
> > > HSLModifier changes from Marcel. Now all image plugins from digiKam
> > > core are ported to 16 bits and work fine !!! (Champagne ?)
> >
> > Of course!!.....Salud!! ;-)
> >
> > Paco
>
> Paco, we will finalize ICC profile management next week because I'm out of
> town this week end.... We will trying to solve all the problem that you
> have annoted in you last e-mail.
>
> Right for you ?
>

Ok, when you have some free time :-).

Paco.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel