extragear/graphics/digikam/imageplugins

[F.J.Cruz]

SVN commit 499249 by fjcruz:

Code cleanup.

For Gilles: all right now?

CCMAIL:[hidden email]

 M  +24 -24    imageeffect_iccproof.cpp  


--- trunk/extragear/graphics/digikam/imageplugins/imageeffect_iccproof.cpp #499248:499249
@@ -231,26 +231,26 @@
 
     QVBoxLayout *firstPageLayout = new QVBoxLayout(inProfiles, 0, KDialog::spacingHint());
 
-    QButtonGroup *m_inProfile = new QButtonGroup(6, Qt::Vertical, inProfiles);
-    m_inProfile->setFrameStyle(QFrame::NoFrame);
+    QButtonGroup *inProfileBG = new QButtonGroup(6, Qt::Vertical, inProfiles);
+    inProfileBG->setFrameStyle(QFrame::NoFrame);
 
-    QRadioButton *m_useEmbeddedProfile = new QRadioButton(m_inProfile);
+    QRadioButton *m_useEmbeddedProfile = new QRadioButton(inProfileBG);
     m_useEmbeddedProfile->setText(i18n("Use embedded profile"));
 
-    QRadioButton *m_useSRGBDefaultProfile = new QRadioButton(m_inProfile);
+    QRadioButton *m_useSRGBDefaultProfile = new QRadioButton(inProfileBG);
     m_useSRGBDefaultProfile->setText(i18n("Use builtin sRGB profile"));
 
-    QRadioButton *m_useInDefaultProfile = new QRadioButton(m_inProfile);
+    QRadioButton *m_useInDefaultProfile = new QRadioButton(inProfileBG);
     m_useInDefaultProfile->setText(i18n("Use default profile"));
 
-    QRadioButton *m_useInSelectedProfile = new QRadioButton(m_inProfile);
+    QRadioButton *m_useInSelectedProfile = new QRadioButton(inProfileBG);
     m_useInSelectedProfile->setText(i18n("Use selected profile"));
 
-    QComboBox *m_inProfilesCB = new QComboBox(m_inProfile);
+    QComboBox *m_inProfilesCB = new QComboBox(inProfileBG);
     
-    QPushButton *m_inProfilesInfo = new QPushButton(i18n("Info"), m_inProfile);
+    QPushButton *m_inProfilesInfo = new QPushButton(i18n("Info"), inProfileBG);
 
-    firstPageLayout->addWidget(m_inProfile);
+    firstPageLayout->addWidget(inProfileBG);
     firstPageLayout->addStretch();
 
     //---------- End First Page ------------------------------------
@@ -262,21 +262,21 @@
 
     QVBoxLayout *secondPageLayout = new QVBoxLayout(proofProfiles, 0, KDialog::spacingHint());
 
-    QButtonGroup *m_proofProfile = new QButtonGroup(4,Qt::Vertical, proofProfiles);
-    m_proofProfile->setFrameStyle(QFrame::NoFrame);
+    QButtonGroup *proofProfileBG = new QButtonGroup(4,Qt::Vertical, proofProfiles);
+    proofProfileBG->setFrameStyle(QFrame::NoFrame);
 
-    QRadioButton *m_useOutDefaultProfile = new QRadioButton(m_proofProfile);
+    QRadioButton *m_useOutDefaultProfile = new QRadioButton(proofProfileBG);
     m_useOutDefaultProfile->setText(i18n("Use default proof profile"));
 
-    QRadioButton *m_useOutSelectedProfile = new QRadioButton(m_proofProfile);
+    QRadioButton *m_useOutSelectedProfile = new QRadioButton(proofProfileBG);
     m_useOutSelectedProfile->setText(i18n("Use selected profile"));
     
-    QComboBox *m_outProfileCB = new QComboBox(m_proofProfile);
+    QComboBox *m_outProfileCB = new QComboBox(proofProfileBG);
 
-    QPushButton *m_outProfilesInfo = new QPushButton(i18n("Info"), m_proofProfile);
+    QPushButton *m_outProfilesInfo = new QPushButton(i18n("Info"), proofProfileBG);
 
 
-    secondPageLayout->addWidget(m_proofProfile);
+    secondPageLayout->addWidget(proofProfileBG);
     secondPageLayout->addStretch();
 
     //---------- End Second Page -----------------------------------
@@ -288,26 +288,26 @@
 
     QVBoxLayout *thirdPageLayout = new QVBoxLayout(displayProfiles, 0, KDialog::spacingHint());
 
-    QButtonGroup *m_displayProfile = new QButtonGroup(4,Qt::Vertical, displayProfiles);
-    m_displayProfile->setFrameStyle(QFrame::NoFrame);
+    QButtonGroup *displayProfileBG = new QButtonGroup(4,Qt::Vertical, displayProfiles);
+    displayProfileBG->setFrameStyle(QFrame::NoFrame);
 
-    QRadioButton *m_useDisplayDefaultProfile = new QRadioButton(m_displayProfile);
+    QRadioButton *m_useDisplayDefaultProfile = new QRadioButton(displayProfileBG);
     m_useDisplayDefaultProfile->setText(i18n("Use default display profile"));
 
-    QRadioButton *m_useDisplaySelectedProfile = new QRadioButton(m_displayProfile);
+    QRadioButton *m_useDisplaySelectedProfile = new QRadioButton(displayProfileBG);
     m_useDisplaySelectedProfile->setText(i18n("Use selected profile"));
 
-//     QComboBox *m_displayProfileCB = new QComboBox(m_displayProfile);
-    KURLRequester *m_displayProfileCB = new KURLRequester(m_displayProfile);
+//     QComboBox *m_displayProfileCB = new QComboBox(displayProfileBG);
+    KURLRequester *m_displayProfileCB = new KURLRequester(displayProfileBG);
     m_displayProfileCB->setMode(KFile::File|KFile::ExistingOnly);
     m_displayProfileCB->setFilter("*.icc *.icm|"+i18n("ICC Files (*.icc; *.icm)"));
     KFileDialog *displayProfiles_dialog = m_displayProfileCB->fileDialog();
     m_iccPreviewWidget = new Digikam::ICCPreviewWidget(displayProfiles_dialog);
     displayProfiles_dialog->setPreviewWidget(m_iccPreviewWidget);
 
-    QPushButton *m_DisplayProfilesInfo = new QPushButton(i18n("Info"), m_displayProfile);
+    QPushButton *m_DisplayProfilesInfo = new QPushButton(i18n("Info"), displayProfileBG);
 
-    thirdPageLayout->addWidget(m_displayProfile);
+    thirdPageLayout->addWidget(displayProfileBG);
     thirdPageLayout->addStretch();
     
     //---------- End Third Page ------------------------------------
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Mardi 17 Janvier 2006 13:16, Francisco J. Cruz a écrit :
> SVN commit 499249 by fjcruz:
>
> Code cleanup.
>
> For Gilles: all right now?

I will take a look (:=)))...

Please update trunk and look if new icons rules backported from stable work
fine for you...

A nice day

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[F.J.Cruz]

---- Gilles Caulier <[hidden email]> escribió:
> Le Mardi 17 Janvier 2006 13:16, Francisco J. Cruz a écrit :

> I will take a look (:=)))...
>
> Please update trunk and look if new icons rules backported from stable work
> fine for you...
>

Already updated. It seems all work right here with new icons.

> A nice day
>
U2
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

Paco Cruz
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tung NGUYEN]

Can you add the attached colormanagement icons set to
trunk/graphics/digikam/imageplugins/icons ?




Le Mardi 17 Janvier 2006 14:00, [hidden email] a écrit :

> ---- Gilles Caulier <[hidden email]> escribió:
> > Le Mardi 17 Janvier 2006 13:16, Francisco J. Cruz a écrit :
> >
> > I will take a look (:=)))...
> >
> > Please update trunk and look if new icons rules backported from stable
> > work fine for you...
>
> Already updated. It seems all work right here with new icons.
>
> > A nice day
>
> U2
>
> > Gilles
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> Paco Cruz
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Tuesday 17 January 2006 23:30, Tung NGUYEN wrote:
> Can you add the attached colormanagement icons set to
> trunk/graphics/digikam/imageplugins/icons ?
>
Great, thx.  Commited.

00:34] <CIA-11> ach * r499508 digikam/trunk/extragear/graphics/digikam/imageplugins/icons/ (7 files):
[00:34] <CIA-11> digikam/trunk: new colormanagement icons for imageplugins
[00:34] <CIA-11> from Tung NGUYEN.

 
Achim

>
>
>
> Le Mardi 17 Janvier 2006 14:00, [hidden email] a écrit :
> > ---- Gilles Caulier <[hidden email]> escribió:
> > > Le Mardi 17 Janvier 2006 13:16, Francisco J. Cruz a écrit :
> > >
> > > I will take a look (:=)))...
> > >
> > > Please update trunk and look if new icons rules backported from stable
> > > work fine for you...
> >
> > Already updated. It seems all work right here with new icons.
> >
> > > A nice day
> >
> > U2
> >
> > > Gilles
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > [hidden email]
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > Paco Cruz
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hi Tung NGUYEN,

watching your new icons, I think they are a little bit too
detailed for small icon size (<32pixel) like you see them left in
the menu. I do not recognize the function when looking at small
sized icons. What do you think about simplifying them for small
sizes?

Thanks

  Thorsten

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

Le Mercredi 18 Janvier 2006 13:01, Thorsten Schnebeck a écrit :

> Hi Tung NGUYEN,
>
> watching your new icons, I think they are a little bit too
> detailed for small icon size (<32pixel) like you see them left in
> the menu. I do not recognize the function when looking at small
> sized icons. What do you think about simplifying them for small
> sizes?
>
> Thanks
>
>   Thorsten

I'm agree with Thorsten about this point.

Thorsten, can you list the icons to fix ?

Thanks in advance

--
Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Thorsten Schnebeck-2]

Am Mittwoch 18 Januar 2006 12:58 schrieb Gilles Caulier:

> Le Mercredi 18 Janvier 2006 13:01, Thorsten Schnebeck a écrit :
> > Hi Tung NGUYEN,
> >
> > watching your new icons, I think they are a little bit too
> > detailed for small icon size (<32pixel) like you see them
> > left in the menu. I do not recognize the function when
> > looking at small sized icons. What do you think about
> > simplifying them for small sizes?
> >
> > Thanks
> >
> >   Thorsten
>
> I'm agree with Thorsten about this point.
>
> Thorsten, can you list the icons to fix ?

OK, I just checked
http://ntung.free.fr/new-icons-0.8.1.tar.bz2
and the icons I can not recognize are called:
graphics/digikam/imageplugins/hi16-action-adjustrgb.png
graphics/digikam/imageplugins/hi16-action-blurimage.png
graphics/digikam/imageplugins/hi16-action-bwtonal.png
graphics/digikam/imageplugins/hi16-action-contrast.png
graphics/digikam/imageplugins/hi16-action-invertimage.png
graphics/digikam/imageplugins/hi16-action-ratiocrop.png
graphics/digikam/imageplugins/hi16-action-sharpenimage.png
graphics/digikam/digikam/pics/cr16-action-fileopen.png
graphics/digikam/digikam/pics/hi16-action-addimagefolder.png
graphics/digikam/digikam/pics/hi16-action-albumfoldercomment.png
graphics/digikam/digikam/pics/hi16-action-albumfoldernew.png
graphics/digikam/digikam/pics/hi16-action-editimage.png
graphics/digikam/digikam/pics/hi16-action-importfolders2albums.png
graphics/digikam/digikam/pics/hi16-action-imagecomment.png
graphics/digikam/digikam/pics/hi16-action-exifinfo.png
graphics/digikam/utilities/imageeditor/pics/hi16-action-flip.png
graphics/digikam/utilities/imageeditor/pics/hi16-action-resize_image.png
graphics/digikam/showfoto/pics/hi16-action-flip.png
graphics/digikam/showfoto/pics/hi16-action-resize_image.png

and the same for 22 instead of 16.

HTH

  Thorsten



>
> Thanks in advance

--
Dipl.-Ing. Thorsten Schnebeck
PZH-GmbH · Schönebecker Allee 2 · D-30823 Garbsen
Tel: [phone] · Fax: [phone]
[hidden email] · www.pzh-gmbh.de

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tung NGUYEN]

Hi Thorsten,

I have no idea on how to improve the icons in sizes 16x16 and 22x22. I propose
you 2 solutions to fix the problem:

1) For each listed icon, you propose me a simplification to make and I will
draw it for you.

2) OR, if you have no simplification to propose for an icon, I will replace it
by its former icon (Gimp) in size 16x16 and 22x22.

---
Tung.


Le Mercredi 18 Janvier 2006 14:04, Thorsten Schnebeck a écrit :

> Am Mittwoch 18 Januar 2006 12:58 schrieb Gilles Caulier:
> > Le Mercredi 18 Janvier 2006 13:01, Thorsten Schnebeck a écrit :
> > > Hi Tung NGUYEN,
> > >
> > > watching your new icons, I think they are a little bit too
> > > detailed for small icon size (<32pixel) like you see them
> > > left in the menu. I do not recognize the function when
> > > looking at small sized icons. What do you think about
> > > simplifying them for small sizes?
> > >
> > > Thanks
> > >
> > >   Thorsten
> >
> > I'm agree with Thorsten about this point.
> >
> > Thorsten, can you list the icons to fix ?
>
> OK, I just checked
> http://ntung.free.fr/new-icons-0.8.1.tar.bz2
> and the icons I can not recognize are called:
> graphics/digikam/imageplugins/hi16-action-adjustrgb.png
> graphics/digikam/imageplugins/hi16-action-blurimage.png
> graphics/digikam/imageplugins/hi16-action-bwtonal.png
> graphics/digikam/imageplugins/hi16-action-contrast.png
> graphics/digikam/imageplugins/hi16-action-invertimage.png
> graphics/digikam/imageplugins/hi16-action-ratiocrop.png
> graphics/digikam/imageplugins/hi16-action-sharpenimage.png
> graphics/digikam/digikam/pics/cr16-action-fileopen.png
> graphics/digikam/digikam/pics/hi16-action-addimagefolder.png
> graphics/digikam/digikam/pics/hi16-action-albumfoldercomment.png
> graphics/digikam/digikam/pics/hi16-action-albumfoldernew.png
> graphics/digikam/digikam/pics/hi16-action-editimage.png
> graphics/digikam/digikam/pics/hi16-action-importfolders2albums.png
> graphics/digikam/digikam/pics/hi16-action-imagecomment.png
> graphics/digikam/digikam/pics/hi16-action-exifinfo.png
> graphics/digikam/utilities/imageeditor/pics/hi16-action-flip.png
> graphics/digikam/utilities/imageeditor/pics/hi16-action-resize_image.png
> graphics/digikam/showfoto/pics/hi16-action-flip.png
> graphics/digikam/showfoto/pics/hi16-action-resize_image.png
>
> and the same for 22 instead of 16.
>
> HTH
>
>   Thorsten
>
> > Thanks in advance

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel