extragear/graphics/digikam/digikam

[Marcel Wiesweg]

SVN commit 1090214 by mwiesweg:

Expand the children of a newly selected current item in left sidebar album and tag tree view.

Waiting for protests...
(we can revert if we dont like it)

CCMAIL: [hidden email]

 M  +5 -0      albumtreeview.cpp  
 M  +3 -0      leftsidebarwidgets.cpp  


--- trunk/extragear/graphics/digikam/digikam/albumtreeview.cpp #1090213:1090214
@@ -260,6 +260,11 @@
     d->expandOnSingleClick = doThat;
 }
 
+void AbstractAlbumTreeView::setExpandNewCurrentItem(bool doThat)
+{
+    d->expandNewCurrent = doThat;
+}
+
 void AbstractAlbumTreeView::setSelectAlbumOnClick(bool selectOnClick)
 {
     d->selectAlbumOnClick = selectOnClick;
--- trunk/extragear/graphics/digikam/digikam/leftsidebarwidgets.cpp #1090213:1090214
@@ -84,7 +84,9 @@
     QVBoxLayout *layout = new QVBoxLayout(this);
 
     d->albumFolderView = new AlbumSelectionTreeView(this, model, d->albumModificationHelper);
+    d->albumFolderView->setObjectName("AlbumFolderView");
     d->albumFolderView->setConfigGroup(getConfigGroup());
+    d->albumFolderView->setExpandNewCurrentItem(true);
     d->searchTextBar   = new SearchTextBar(this, "DigikamViewFolderSearchBar");
     d->searchTextBar->setHighlightOnResult(true);
     d->searchTextBar->setModel(model, AbstractAlbumModel::AlbumIdRole, AbstractAlbumModel::AlbumTitleRole);
@@ -182,6 +184,7 @@
 
     d->tagFolderView = new TagFolderView(this, model);
     d->tagFolderView->setConfigGroup(getConfigGroup());
+    d->tagFolderView->setExpandNewCurrentItem(true);
     d->tagSearchBar  = new SearchTextBar(this, "DigikamViewTagSearchBar");
     d->tagSearchBar->setHighlightOnResult(true);
     d->tagSearchBar->setModel(model, AbstractAlbumModel::AlbumIdRole, AbstractAlbumModel::AlbumTitleRole);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

Marcel,

I suspect that this commit causes the following strange behaviour:
Expand an album that already has children, create a new child of this
album via the context menu. Afterwards the parent is collapsed, so that
the new child cannot be seen in the tree view.

Can you have a look at this?

Johannes

Am 14.02.2010 23:20 schrieb Marcel Wiesweg:

> SVN commit 1090214 by mwiesweg:
>
> Expand the children of a newly selected current item in left sidebar album and tag tree view.
>
> Waiting for protests...
> (we can revert if we dont like it)
>
> CCMAIL: [hidden email]
>
>  M  +5 -0      albumtreeview.cpp  
>  M  +3 -0      leftsidebarwidgets.cpp  
>
>
> --- trunk/extragear/graphics/digikam/digikam/albumtreeview.cpp #1090213:1090214
> @@ -260,6 +260,11 @@
>      d->expandOnSingleClick = doThat;
>  }
>  
> +void AbstractAlbumTreeView::setExpandNewCurrentItem(bool doThat)
> +{
> +    d->expandNewCurrent = doThat;
> +}
> +
>  void AbstractAlbumTreeView::setSelectAlbumOnClick(bool selectOnClick)
>  {
>      d->selectAlbumOnClick = selectOnClick;
> --- trunk/extragear/graphics/digikam/digikam/leftsidebarwidgets.cpp #1090213:1090214
> @@ -84,7 +84,9 @@
>      QVBoxLayout *layout = new QVBoxLayout(this);
>  
>      d->albumFolderView = new AlbumSelectionTreeView(this, model, d->albumModificationHelper);
> +    d->albumFolderView->setObjectName("AlbumFolderView");
>      d->albumFolderView->setConfigGroup(getConfigGroup());
> +    d->albumFolderView->setExpandNewCurrentItem(true);
>      d->searchTextBar   = new SearchTextBar(this, "DigikamViewFolderSearchBar");
>      d->searchTextBar->setHighlightOnResult(true);
>      d->searchTextBar->setModel(model, AbstractAlbumModel::AlbumIdRole, AbstractAlbumModel::AlbumTitleRole);
> @@ -182,6 +184,7 @@
>  
>      d->tagFolderView = new TagFolderView(this, model);
>      d->tagFolderView->setConfigGroup(getConfigGroup());
> +    d->tagFolderView->setExpandNewCurrentItem(true);
>      d->tagSearchBar  = new SearchTextBar(this, "DigikamViewTagSearchBar");
>      d->tagSearchBar->setHighlightOnResult(true);
>      d->tagSearchBar->setModel(model, AbstractAlbumModel::AlbumIdRole, AbstractAlbumModel::AlbumTitleRole);

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Marcel,
>
> I suspect that this commit causes the following strange behaviour:
> Expand an album that already has children, create a new child of this
> album via the context menu. Afterwards the parent is collapsed, so that
> the new child cannot be seen in the tree view.
>
> Can you have a look at this?

I put this in line 126:
kDebug() << m_orgImage.numBytes() <<
m_orgImage.width()*m_orgImage.height()*(m_orgImage.sixteenBit() ? 8 : 4);

and get the same (correct) result for an 8 or 16bit image.
However, I get a lot of these:
Digikam::HistogramPainterPriv::scaleToPixmapHeight: Scaling value < 0:  0 .
Falling back to 1.0

and the filter is broken: for 8bit, I get simply a gray result image, for
16bit, the upper half is grey and the lower half is the original.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I put this in line 126:
> kDebug() << m_orgImage.numBytes() <<
> m_orgImage.width()*m_orgImage.height()*(m_orgImage.sixteenBit() ? 8 : 4);
>
> and get the same (correct) result for an 8 or 16bit image.
> However, I get a lot of these:
> Digikam::HistogramPainterPriv::scaleToPixmapHeight: Scaling value < 0:  0 .
> Falling back to 1.0
>
> and the filter is broken: for 8bit, I get simply a gray result image, for
> 16bit, the upper half is grey and the lower half is the original.

Sorry, sending answer to the wrong mail
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel