SVN commit 688541 by cgilles:
KDE4 port. This is the last one to complete digiKam port under KDE4 ! Note : this port is uncomplete. It just to be able to compile and link digiKam as well, and start testing... Marcel : QCUstomMenuItem implementation need to be ported to QWidgetAction. Still TODO.. CCMAIL: [hidden email] CCMAIL: [hidden email] M +1 -1 CMakeLists.txt M +21 -15 tagspopupmenu.cpp --- trunk/extragear/graphics/digikam/digikam/CMakeLists.txt #688540:688541 @@ -122,7 +122,7 @@ tagcreatedlg.cpp tagfilterview.cpp tagfolderview.cpp -# tagspopupmenu.cpp + tagspopupmenu.cpp welcomepageview.cpp main.cpp ) --- trunk/extragear/graphics/digikam/digikam/tagspopupmenu.cpp #688540:688541 @@ -57,6 +57,9 @@ namespace Digikam { +#warning "TODO: kde4 port it"; +/* // TODO: KDE4PORT: use KWidgetAction API instead QCustomMenuItem + class TagsPopupCheckedMenuItem : public QCustomMenuItem { @@ -114,6 +117,7 @@ QPixmap m_pix; }; +*/ // ------------------------------------------------------------------------ @@ -123,14 +127,14 @@ TagsPopupMenuPriv(){} - int addToID; + int addToID; - QPixmap addTagPix; + QPixmap addTagPix; - Q3ValueList<int> assignedTags; + Q3ValueList<int> assignedTags; Q3ValueList<qlonglong> selectedImageIDs; - TagsPopupMenu::Mode mode; + TagsPopupMenu::Mode mode; }; TagsPopupMenu::TagsPopupMenu(const Q3ValueList<qlonglong>& selectedImageIDs, int addToID, Mode mode) @@ -142,11 +146,8 @@ d->mode = mode; KIconLoader *iconLoader = KIconLoader::global(); - d->addTagPix = iconLoader->loadIcon("tag", - KIcon::NoGroup, - KIcon::SizeSmall, - KIcon::DefaultState, - 0, true); + d->addTagPix = iconLoader->loadIcon("tag", K3Icon::NoGroup, K3Icon::SizeSmall, + K3Icon::DefaultState, 0, true); connect(this, SIGNAL(aboutToShow()), this, SLOT(slotAboutToShow())); @@ -186,8 +187,10 @@ QPixmap pix = SyncJob::getTagThumbnail(album); if ((d->mode == ASSIGN) && (d->assignedTags.contains(album->id()))) { +#warning "TODO: kde4 port it"; +/* // TODO: KDE4PORT: use KWidgetAction API instead QCustomMenuItem popup->insertItem(new TagsPopupCheckedMenuItem(popup, album->title(), pix), - d->addToID + album->id()); + d->addToID + album->id());*/ } else { @@ -231,8 +234,8 @@ return; // also add the parents of the assigned tags - IntList tList; - for (IntList::iterator it = d->assignedTags.begin(); + QLinkedList<int> tList; + for (QLinkedList<int>::iterator it = d->assignedTags.begin(); it != d->assignedTags.end(); ++it) { TAlbum* album = man->findTAlbum(*it); @@ -247,7 +250,7 @@ } } - for (IntList::iterator it = tList.begin(); + for (QLinkedList<int>::iterator it = tList.begin(); it != tList.end(); ++it) { d->assignedTags.append(*it); @@ -301,8 +304,7 @@ if (d->mode == REMOVE) { - IntList::iterator it = qFind(d->assignedTags.begin(), - d->assignedTags.end(), a->id()); + QLinkedList<int>::iterator it = qFind(d->assignedTags.begin(), d->assignedTags.end(), a->id()); if (it == d->assignedTags.end()) continue; } @@ -319,8 +321,12 @@ { if ((d->mode == ASSIGN) && (d->assignedTags.contains(a->id()))) { +#warning "TODO: kde4 port it"; +/* // TODO: KDE4PORT: use KWidgetAction API instead QCustomMenuItem + menu->insertItem(new TagsPopupCheckedMenuItem(this, a->title(), pix), d->addToID + a->id()); +*/ } else { _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Gilles Caulier wrote:
> SVN commit 688541 by cgilles: > > KDE4 port. This is the last one to complete digiKam port under KDE4 ! > > Note : this port is uncomplete. It just to be able to compile and link digiKam as well, and start testing... > > Marcel : QCUstomMenuItem implementation need to be ported to QWidgetAction. Still TODO.. Nice milestone Gilles good work. I guess I'd better crack out those KDE4 RPMs :) Out of interest. If i launch DK will it trash the old DK database or will it "migrate" it to a new version, leaving the old one in tact? Col _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
2007/7/16, Colin Guthrie <[hidden email]>: GillesGilles Caulier wrote: After a million of commiuts since 5 weeks, i'm tired. Need hollidays (:=))) I guess I'd better crack out those KDE4 RPMs :) No. The digikam3.db will be renamed to digikam4.db. Content still unchanged because we haven't yet modified the DB structure... but of it's planed for KDE4... The port is not the only thing to do with the new relase. We will work to make a huge update of database, especially to store new photo informations to perform advanced search : GPS, Haar matrix (to perform fuzzy comparison), Photograph info (fnumber, focal, lens id, etc) copyright etc... _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
2007/7/16, Gilles Caulier <[hidden email]>:
Colin, i forget to said than i recommend to not use in production digiKam for KDE4 now. It still alpha code with huge indeep changed not yet tested. Make a new album collection with test pictures. digiKam will certainly crash (:=))). No need to take risk... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
> No. The digikam3.db will be renamed to digikam4.db. Content still unchanged
> because we haven't yet modified the DB structure... but of it's planed for > KDE4... At the moment not even that, the code is commented out. No need until the schema will really be changed. Then we are prepared. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
Gilles Caulier wrote:
> Colin, i forget to said than i recommend to not use in production > digiKam for KDE4 now. It still alpha code with huge indeep changed not > yet tested. Make a new album collection with test pictures. > > digiKam will certainly crash (:=))). No need to take risk... Yeah, I was thinking of using my existing one as a base but I think I'll create a test user instead... just seems safer all round ;) Cheers Col _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Marcel Wiesweg
Hi Marcel,
First test on KDE4 digikam of course... crash at start up (:=))). this is the backtrace : #gdb /opt/kde4/bin/digikam ... Object::connect: No such signal KIO::TransferJob::result(KIO::Job*) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1259734816 (LWP 19206)] 0xb5e7b20c in QAction::setEnabled () from /usr/lib/qt4/lib/libQtGui.so.4 Current language: auto; currently c (gdb) bt #0 0xb5e7b20c in QAction::setEnabled () from /usr/lib/qt4/lib/libQtGui.so.4 #1 0xb7468540 in Digikam::DigikamApp::slotAlbumSelected (this=0x80ff590, val=true) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:1038 #2 0xb7474ba9 in Digikam::DigikamApp::qt_metacall (this=0x80ff590, _c=QMetaObject::InvokeMetaMethod, _id=9, _a=0xbf9ecd1c) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamapp.moc:157 #3 0xb7e99f47 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #4 0xb7e9a8b5 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #5 0xb74c4d12 in Digikam::DigikamView::signalAlbumSelected (this=0x810bdb0, _t1=true) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.moc:294 #6 0xb74c4dea in Digikam::DigikamView::slotAlbumSelected (this=0x810bdb0, album=0x873a6c0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.cpp:640 #7 0xb74c53a2 in Digikam::DigikamView::qt_metacall (this=0x810bdb0, _c=QMetaObject::InvokeMetaMethod, _id=33, _a=0xbf9ed24c) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.moc:237 #8 0xb7e99f47 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #9 0xb7e9a8b5 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #10 0xb74a353e in Digikam::AlbumManager::signalAlbumCurrentChanged (this=0x80fb2b8, _t1=0x873a6c0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.moc:141 #11 0xb74a3574 in Digikam::AlbumManager::setCurrentAlbum (this=0x80fb2b8, album=0x873a6c0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.cpp:708 #12 0xb74c4fa6 in Digikam::DigikamView::slotAllAlbumsLoaded (this=0x810bdb0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.cpp:458 #13 0xb74c55a2 in Digikam::DigikamView::qt_metacall (this=0x810bdb0, _c=QMetaObject::InvokeMetaMethod, _id=61, _a=0xbf9ed340) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.moc:265 #14 0xb7e99f47 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #15 0xb7e9a8b5 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #16 0xb74a34ed in Digikam::AlbumManager::signalAllAlbumsLoaded (this=0x80fb2b8) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.moc:147 #17 0xb74a801c in Digikam::AlbumManager::startScan (this=0x80fb2b8) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.cpp:342 #18 0xb7473d15 in DigikamApp (this=0x80ff590) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:174 #19 0x0804de8b in main (argc=1, argv=0xbf9edda4) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/main.cpp:280 (gdb) Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Marcel,
I have find the problem : d->albumImportAction instance is never initialised in digikamapp.cpp. Gilles 2007/7/16, Gilles Caulier <[hidden email]>: Hi Marcel, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Ok, now the Album GUI apperas on my computer, but, when i select an album on left sidebar, it crash :
(gdb) bt #0 0x00000021 in ?? () #1 0xb7d03132 in KJob::kill (this=0x874f1c0, verbosity=KJob::Quietly) at /home/mandrake/rpm/BUILD/kdelibs-3.91/kdecore/jobs/kjob.cpp:112 #2 0xb7550b93 in Digikam::AlbumLister::stop (this=0x810d408) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albumlister.cpp:277 #3 0xb752e47e in Digikam::AlbumIconView::setAlbum (this=0x810e978, album=0x8722780) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albumiconview.cpp:330 #4 0xb7578399 in Digikam::DigikamView::slotAlbumSelected (this=0x810bdb0, album=0x8722780) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.cpp:653 #5 0xb7578862 in Digikam::DigikamView::qt_metacall (this=0x810bdb0, _c=QMetaObject::InvokeMetaMethod, _id=33, _a=0xbfa8b0ac) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/digikamview.moc:237 #6 0xb7f4cf47 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #7 0xb7f4d8b5 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #8 0xb7556242 in Digikam::AlbumManager::signalAlbumCurrentChanged (this=0x80fb2c8, _t1=0x8722780) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.moc:141 #9 0xb7556278 in Digikam::AlbumManager::setCurrentAlbum (this=0x80fb2c8, album=0x8722780) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albummanager.cpp:702 #10 0xb754687b in Digikam::AlbumFolderView::slotSelectionChanged (this=0x84f26f0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albumfolderview.cpp:435 #11 0xb754d461 in Digikam::AlbumFolderView::qt_metacall (this=0x84f26f0, _c=QMetaObject::InvokeMetaMethod, _id=4, _a=0xbfa8b1c0) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/albumfolderview.moc:90 #12 0xb7f4cf47 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #13 0xb7f4d8b5 in QMetaObject::activate () from /usr/lib/qt4/lib/libQtCore.so.4 #14 0xb6fa3645 in Q3ListView::selectionChanged () from /usr/lib/qt4/lib/libQt3Support.so.4 #15 0xb6e536bd in Q3ListView::setCurrentItem () from /usr/lib/qt4/lib/libQt3Support.so.4 #16 0xb6e5b1ed in Q3ListView::contentsMousePressEventEx () from /usr/lib/qt4/lib/libQt3Support.so.4 #17 0xb6e5bc73 in Q3ListView::contentsMousePressEvent () from /usr/lib/qt4/lib/libQt3Support.so.4 #18 0xb757f4f1 in Digikam::FolderView::contentsMousePressEvent (this=0x84f26f0, e=0xbfa8b7fc) at /home/gilles/Documents/Devel/SVN/trunk/graphics/digikam/digikam/folderview.cpp:207 #19 0xb6eb26a5 in Q3ScrollView::viewportMousePressEvent () from /usr/lib/qt4/lib/libQt3Support.so.4 #20 0xb6eb4a71 in Q3ScrollView::eventFilter () from /usr/lib/qt4/lib/libQt3Support.so.4 #21 0xb6e5f1b7 in Q3ListView::eventFilter () from /usr/lib/qt4/lib/libQt3Support.so.4 #22 0xb5f31f61 in QApplicationPrivate::notify_helper () from /usr/lib/qt4/lib/libQtGui.so.4 #23 0xb5f38b78 in QApplication::notify () from /usr/lib/qt4/lib/libQtGui.so.4 #24 0xb7aca590 in KApplication::notify (this=0xbfa8c270, receiver=0x84f68d0, event=0xbfa8bcb8) Note : All image editor plugins are properlly loaded, but not kipi-plugins... libkipi still to be pached (:=))) Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Well, digikam start now:
http://digikam3rdparty.free.fr/Screenshots/digikamKDE4_01.png ... but crash everywhere (:=))) - Select an album - Go to setup dialog - Start LightTable - go to Date view. - when main window is closed. etc... In others words : debug, debug, debug... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
On Mon, 16 Jul 2007, Gilles Caulier wrote:
> Well, digikam start now: > > http://digikam3rdparty.free.fr/Screenshots/digikamKDE4_01.png Great! Well done! > ... but crash everywhere (:=))) This is not really a surprise ... ;=) Arnd _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Gilles Caulier-4
Marcel,
are you seen this message on the console : kio (Slave): createSlave 'digikamdates' for digikamdates://?databaseType=QSQLITE&databaseName=%2Fhome%2Fgilles%2FImages%2Fdigikam3.db kio (Slave): createSlave 'digikamalbums' for digikamalbums:///Test Photographs/RAW/Horizontal/?albumRoot=/home/gilles/Images&databaseType=QSQLITE&databaseName=%2Fhome%2Fgilles%2FImages%2Fdigikam3.db digikam: ERROR: : couldn't create slave : Unable to create io-slave: klauncher said: Error loading 'kio_digikamalbums'. digikam: This is why iconview is empty... Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |