[digikamimageplugins] [Bug 331523] New: digikam probably won't compile with next lensfun version

[Marc Cousin]

https://bugs.kde.org/show_bug.cgi?id=331523

            Bug ID: 331523
           Summary: digikam probably won't compile with next lensfun
                    version
    Classification: Unclassified
           Product: digikamimageplugins
           Version: unspecified
          Platform: Archlinux Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Lens Distortion
          Assignee: [hidden email]
          Reporter: [hidden email]

When trying to compile digikam 4.0.0-beta3 with latest lensfun svn, building
fails with

‘LF_MODIFY_CCI’ was not declared in this scope


This is because of commit 480 in lensfun:
http://svn.berlios.de/wsvn/lensfun?op=comp&compare[]=/@479&compare[]=/@480

It removes support for CCI. So maybe it would be better to anticipate ?

I didn't see it mentionned in the bug tracking system, and didn't know if this
should be made into a bug report.

Regards.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
The question is why CCI Feature (Lens Color Contribution) have been removed
from Lensfun ? I cannot see any comment about in commit message...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marc Cousin]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #2 from Marc Cousin <[hidden email]> ---
No idea. I just tried to compile latest digikam with latest lensfun (because I
wanted to see if the bug 330943 was there too).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Removing code from digiKam to drop CCI features is easy. I want to be sure that
CCI is really removed and why, before to touch code from digiKam lensfun
interface

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marc Cousin]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #4 from Marc Cousin <[hidden email]> ---
http://developer.berlios.de/forum/message.php?msg_id=97629

I guess that, as nobody objected… :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frantisek Repkovsky]

https://bugs.kde.org/show_bug.cgi?id=331523

Fero <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om

--- Comment #5 from Fero <[hidden email]> ---
Hello, I tried to compile digikam 4.2.0 with lensfun svn snapshot today and it
failed due to the same problem as above... :-( i want to use latest lensfun
because my camera support has been added there...

best regards

Frantisek

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Fero,

When is planed next lensfun release without CCI feature ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digikam probably won't      |digiKam don't compile with
                   |compile with next lensfun   |next Lensfun version where
                   |version                     |CCI correction have been
                   |                            |removed

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frantisek Repkovsky]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #7 from Fero <[hidden email]> ---
Hi Gilles,

I'm sorry, I have no idea when next version of lensfun will be released ;-). I
checked on their website, mailing list but found no info...

Fero

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=331523

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.3.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/2ad23dae290c64c293d9c3d
                   |                            |3ae2c8734c99f902b
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Git commit 2ad23dae290c64c293d9c3d3ae2c8734c99f902b by Gilles Caulier.
Committed on 02/09/2014 at 15:06.
Pushed by cgilles into branch 'master'.

Make digiKam ready to use next Lensfun API where CII correction have been
removed.
Related: bug 319383, bug 333540
FIXED-IN: 4.3.0

M  +1    -2    imageplugins/enhance/lensautofixtool.cpp
M  +1    -1    imageplugins/enhance/lensautofixtool.h
M  +3    -12   libs/dimg/filters/lens/lensfunfilter.cpp
M  +3    -5    libs/dimg/filters/lens/lensfunfilter.h
M  +3    -6    libs/dimg/filters/lens/lensfuniface.cpp
M  +0    -1    libs/dimg/filters/lens/lensfuniface.h
M  +1    -26   libs/dimg/filters/lens/lensfunsettings.cpp
M  +1    -2    libs/dimg/filters/lens/lensfunsettings.h
M  +8    -13   utilities/queuemanager/basetools/enhance/lensautofix.cpp
M  +1    -1    utilities/queuemanager/basetools/enhance/lensautofix.h

http://commits.kde.org/digikam/2ad23dae290c64c293d9c3d3ae2c8734c99f902b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Frantisek Repkovsky]

https://bugs.kde.org/show_bug.cgi?id=331523

--- Comment #9 from Fero <[hidden email]> ---
Hi Gilles,

compiled successfully - current lensfun git clone with digikam 4.3.0

many thanks! keep up the great job! ;-)

Best regards

Fero

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=331523

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
                 CC|                            |veaceslav.munteanu90@gmail.
                   |                            |com

--- Comment #10 from Veaceslav Munteanu <[hidden email]> ---
Current master do not compile with lensfun 0.3.0-1

the same error:

error: 'LF_MODIFY_CCI' was not declared in this scope
         modifyFlags |= LF_MODIFY_CCI;

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Veaceslav Munteanu-2]

https://bugs.kde.org/show_bug.cgi?id=331523

Veaceslav Munteanu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Veaceslav Munteanu <[hidden email]> ---
Oops.. A mistake from my side :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=331523

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Lens Distortion             |Tool-LensDistortion

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel