digikamadaptop.moc in object library error on older cmake versions
Locked
digikamadaptop.moc in object library error on older cmake versions
 
|
Hi,
digiKam[frameworks] doesn't build here because I have CMake-2.8.12 and digikamadaptop.moc is built into an object library. What can we do: 1. Bump CMake version requirement (not sure about minimum version we need to fix this problem), OR 2. Cherry-pick the commit [1] into branch frameworks. I would prefer the 1st solution. Any objections? [1] http://quickgit.kde.org/?p=digikam.git&a=commit&h=d9d715deaacd4fb6d021ccb3c1fa1120ef183201 -- Alexander Potashev _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
Hello,
that commit of mine was broken and didn't fix the problem. I have Cmake 3.2.3 which generates without errors. I'm not sure, but even if old versions throw an error, you can still build it. Have you tried to run make after? I will try now to find a solution to this problem On Mon, Jul 6, 2015 at 12:27 AM, Alexander Potashev <[hidden email]> wrote: > Hi, > > digiKam[frameworks] doesn't build here because I have CMake-2.8.12 and > digikamadaptop.moc is built into an object library. > > What can we do: > 1. Bump CMake version requirement (not sure about minimum version we > need to fix this problem), OR > 2. Cherry-pick the commit [1] into branch frameworks. > > I would prefer the 1st solution. Any objections? > > [1] http://quickgit.kde.org/?p=digikam.git&a=commit&h=d9d715deaacd4fb6d021ccb3c1fa1120ef183201 > > -- > Alexander Potashev > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
For me cmake 3.0.1 under Mageia generate only a warning and compile. So a minimum cmake to 3.0.0 is safe. Gilles 2015-07-06 9:01 GMT+02:00 Veaceslav Munteanu <[hidden email]>: Hello, _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
Veaceslav, For me it fixed the build. I needed to resolve conflicts when cherry picking, and may the patch went a little different ;) Gilles, -- _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
Here is no fast way to solve problem with that .moc ...
Alexander, it may fix the cmake generation, but after make clean, it won't compile because digikamapp won't find digikamadaptor.h I bumped min cmake version to 3.0.0 ... On Mon, Jul 6, 2015 at 10:15 AM, Alexander Potashev <[hidden email]> wrote: > > On Jul 6, 2015 10:29, "Gilles Caulier" <[hidden email]> wrote: >> >> For me cmake 3.0.1 under Mageia generate only a warning and compile. >> >> So a minimum cmake to 3.0.0 is safe. >> >> Gilles >> >> 2015-07-06 9:01 GMT+02:00 Veaceslav Munteanu >> <[hidden email]>: >>> >>> Hello, >>> >>> that commit of mine was broken and didn't fix the problem. I have >>> Cmake 3.2.3 which generates without errors. >>> >>> I'm not sure, but even if old versions throw an error, you can still >>> build it. Have you tried to run make after? >>> >>> I will try now to find a solution to this problem >>> >>> On Mon, Jul 6, 2015 at 12:27 AM, Alexander Potashev >>> <[hidden email]> wrote: >>> > Hi, >>> > >>> > digiKam[frameworks] doesn't build here because I have CMake-2.8.12 and >>> > digikamadaptop.moc is built into an object library. >>> > >>> > What can we do: >>> > 1. Bump CMake version requirement (not sure about minimum version we >>> > need to fix this problem), OR >>> > 2. Cherry-pick the commit [1] into branch frameworks. >>> > >>> > I would prefer the 1st solution. Any objections? >>> > >>> > [1] >>> > http://quickgit.kde.org/?p=digikam.git&a=commit&h=d9d715deaacd4fb6d021ccb3c1fa1120ef183201 >>> > > > Veaceslav, > > For me it fixed the build. I needed to resolve conflicts when cherry > picking, and may the patch went a little different ;) > > Gilles, > What kind of warning are you getting? > > -- > Alexander Potashev > > > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel > Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
In reply to this post by Alexander Potashev
-- ---------------------------------------------------------------------------------- -- digiKam 5.0.0-git dependencies results <http://www.digikam.org> -- -- MySQL Database Support will be compiled.. YES (optional) -- MySQL Server found....................... YES -- MySQL install_db tool found.............. YES -- libqt found.............................. YES -- libkde found............................. YES -- libjpeg found............................ YES -- libtiff found............................ YES -- libpng found............................. YES -- liblcms found............................ YES -- libboostgraph found...................... YES -- libpgf found............................. YES -- libopencv found.......................... YES -- libkexiv2 found.......................... YES -- libkdcraw found.......................... YES -- libkipi found............................ YES (optional) -- libkface found........................... YES (optional) -- libkgeomap found......................... YES (optional) -- libkfilemetadata found................... YES (optional) -- libakonadicontact found.................. NO (optional) -- digiKam will be compiled without KDE address book support. -- Please install the libakonadicontact (version >= 5.0.0) development package. -- -- libjasper found.......................... YES (optional) -- liblensfun found......................... YES (optional) -- liblqr-1 found........................... YES (optional) -- libeigen3 found.......................... YES (optional) -- libgphoto2 found......................... YES (optional) -- doxygen found............................ YES (optional) -- digiKam can be compiled.................. YES -- ---------------------------------------------------------------------------------- -- INFOgphoto2 includes are required only to display the version in the about data/component info, refactor -- Configuring done CMake Error at core/app/CMakeLists.txt:251 (add_library): OBJECT library "digikamgui_src" contains: digikamadaptor.moc but may contain only headers and sources that compile. -- Generating done -- Build files have been written to: /home/gilles/Devel/5.x/build I can run make after that... Gilles 2015-07-06 10:15 GMT+02:00 Alexander Potashev <[hidden email]>:
_______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Re: digikamadaptop.moc in object library error on older cmake versions
|
|
In reply to this post by Veaceslav Munteanu-2
Veaceslav, It built cleanly here, but I guess it was by chance. Let's just keep the cmake-3.0 dependency and be happy :) -- _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
| Free forum by Nabble | Edit this page |