digikam fails to compile with external lensfun-devel

[S. Burmeister]

Hey everyone!

When I try to compile digikam with an external lensfun-devel I get the following
although it did work before. Compiling with the internal works.

So is version 0.2.5 too old or is this a bug in digikam?

Sven

/home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp: In constructor ‘Digikam::LibsInfoDlg::LibsInfoDlg(QWidget*)’:
/home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:120:17: error: ‘LF_VERSION_MAJOR’ was not declared in this scope
/home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:121:17: error: ‘LF_VERSION_MINOR’ was not declared in this scope
/home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:122:17: error: ‘LF_VERSION_MICRO’ was not declared in this scope
/home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:123:17: error: ‘LF_VERSION_BUGFIX’ was not declared in this scope
make[2]: *** [core/digikam/CMakeFiles/digikamcore.dir/__/libs/dialogs/libsinfodlg.cpp.o] Fehler 1

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

You use 0.2.5 lensfun version. right ? digiKam include also this
version of library in core...

In fact the file lensfun.h must have LF_VERSION_* definition. Can you
can your file here to see ?

Gilles Caulier

Le 29 mars 2012 15:26, Sven Burmeister <[hidden email]> a écrit :

> Hey everyone!
>
> When I try to compile digikam with an external lensfun-devel I get the following
> although it did work before. Compiling with the internal works.
>
> So is version 0.2.5 too old or is this a bug in digikam?
>
> Sven
>
> /home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp: In constructor ‘Digikam::LibsInfoDlg::LibsInfoDlg(QWidget*)’:
> /home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:120:17: error: ‘LF_VERSION_MAJOR’ was not declared in this scope
> /home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:121:17: error: ‘LF_VERSION_MINOR’ was not declared in this scope
> /home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:122:17: error: ‘LF_VERSION_MICRO’ was not declared in this scope
> /home/kde-branch/kde/src/digikam-software-compilation/core/libs/dialogs/libsinfodlg.cpp:123:17: error: ‘LF_VERSION_BUGFIX’ was not declared in this scope
> make[2]: *** [core/digikam/CMakeFiles/digikamcore.dir/__/libs/dialogs/libsinfodlg.cpp.o] Fehler 1
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

Am Donnerstag, 29. März 2012, 16:37:21 schrieb Gilles Caulier:
> You use 0.2.5 lensfun version. right ? digiKam include also this
> version of library in core...
>
> In fact the file lensfun.h must have LF_VERSION_* definition. Can you
> can your file here to see ?

0.25 does not have those.

You can check here:
http://svn.berlios.de/wsvn/lensfun/tags/0.2.5/include/lensfun/lensfun.h

only trunk has:
http://svn.berlios.de/wsvn/lensfun/trunk/include/lensfun/lensfun.h.in

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

ok. code from digiKam core come from svn trunk, after than 0.2.5 have
been released in 2010 !

so code from digiKam is 0.2.6 not yet released.

don't use 0.2.5. I cannot check version, because there is no version
ID in 0.2.5 package.

It's urgent to have a new release of lensfun now...

Gilles Caulier

Le 29 mars 2012 16:45, Sven Burmeister <[hidden email]> a écrit :

> Am Donnerstag, 29. März 2012, 16:37:21 schrieb Gilles Caulier:
>> You use 0.2.5 lensfun version. right ? digiKam include also this
>> version of library in core...
>>
>> In fact the file lensfun.h must have LF_VERSION_* definition. Can you
>> can your file here to see ?
>
> 0.25 does not have those.
>
> You can check here:
> http://svn.berlios.de/wsvn/lensfun/tags/0.2.5/include/lensfun/lensfun.h
>
> only trunk has:
> http://svn.berlios.de/wsvn/lensfun/trunk/include/lensfun/lensfun.h.in
>
> Sven
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

Am Donnerstag, 29. März 2012, 17:51:07 schrieb Gilles Caulier:
> ok. code from digiKam core come from svn trunk, after than 0.2.5 have
> been released in 2010 !
>
> so code from digiKam is 0.2.6 not yet released.
>
> don't use 0.2.5. I cannot check version, because there is no version
> ID in 0.2.5 package.
>
> It's urgent to have a new release of lensfun now...

Indeed, since most distros do not like to include snapshots of unreleased
software.

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Le 29 mars 2012 17:03, Sven Burmeister <[hidden email]> a écrit :

> Am Donnerstag, 29. März 2012, 17:51:07 schrieb Gilles Caulier:
>> ok. code from digiKam core come from svn trunk, after than 0.2.5 have
>> been released in 2010 !
>>
>> so code from digiKam is 0.2.6 not yet released.
>>
>> don't use 0.2.5. I cannot check version, because there is no version
>> ID in 0.2.5 package.
>>
>> It's urgent to have a new release of lensfun now...
>
> Indeed, since most distros do not like to include snapshots of unreleased
> software.

This is why i include code from trunk into digiKam core. It's include
a lots of fixes since 0.2.5 release

Gilles Caulier
>
> Sven
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

Am Donnerstag, 29. März 2012, 18:12:01 schrieb Gilles Caulier:
> This is why i include code from trunk into digiKam core. It's include
> a lots of fixes since 0.2.5 release

Is it right that if one uses the internal liblensfun digikam only installs
some xml files within the digikam folders? I thought it would install some
libs, yet when building it all I see is xml files.

Sven
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel