digiKam › digikam-devel

[digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

Classic

List

Threaded

7 messages Options

Andi Clemens

[digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

Git commit 3e381acdbb56e736b986a6b63810596cf5064287 by Andi Clemens.
Committed on 25/09/2011 at 10:05.
Pushed by aclemens into branch 'master'.

Added comment about deleting albums. It is not possible to delete an album
directly.

CCMAIL:[hidden email]

M +4 -0 digikam/main/digikamapp.cpp

http://commits.kde.org/digikam/3e381acdbb56e736b986a6b63810596cf5064287

diff --git a/digikam/main/digikamapp.cpp b/digikam/main/digikamapp.cpp
index 0a6033d..8230862 100644
--- a/digikam/main/digikamapp.cpp
+++ b/digikam/main/digikamapp.cpp
@@ -968,6 +968,10 @@ void DigikamApp::setupActions()
// -----------------------------------------------------------

// Pop up dialog to ask user whether to permanently delete
+ // FIXME: This action is never used?? How can someone delete a album directly, without moving it to the trash first?
+ // This is especially important when deleting from a different partiton or from a net source.
+ // Also note that we use the wrong icon for the default album delete action, which should have a thrashcan icon instead
+ // of a red cross, it confuses users.
d->imageDeletePermanentlyAction = new KAction(KIcon("edit-delete"), i18n("Delete Permanently"), this);
d->imageDeletePermanentlyAction->setShortcut(KShortcut(Qt::SHIFT+Qt::Key_Delete));
connect(d->imageDeletePermanentlyAction, SIGNAL(triggered()), d->view, SLOT(slotImageDeletePermanently()));
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Marcel Wiesweg

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

> Git commit 3e381acdbb56e736b986a6b63810596cf5064287 by Andi Clemens.
> Committed on 25/09/2011 at 10:05.
> Pushed by aclemens into branch 'master'.
>
> Added comment about deleting albums. It is not possible to delete an album
> directly.
>
> // Pop up dialog to ask user whether to permanently delete
> + // FIXME: This action is never used?? How can someone delete a album
> directly, without moving it to the trash first? + // This is
> especially important when deleting from a different partiton or from a net
> source. + // Also note that we use the wrong icon for the
> default album delete action, which should have a thrashcan icon instead +
> // of a red cross, it confuses users.

The confirmation dialog has a checkbox for direct deletion.
The user can assign a shortcut if he really wishes (though currently he cannot
know from the action description which one is about images and which one about
albums...) but for security, unrevocable delete is not directly accessible.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Andi Clemens

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

Hmmm I somehow had not the checkbox the last time I tried to delete an
album, I rebuild everything from scratch and... there it is again :-)

Andi

On Sun, 25 Sep 2011 15:25:02 +0200, Marcel Wiesweg <[hidden email]>
wrote:

>
>> Git commit 3e381acdbb56e736b986a6b63810596cf5064287 by Andi Clemens.
>> Committed on 25/09/2011 at 10:05.
>> Pushed by aclemens into branch 'master'.
>>
>> Added comment about deleting albums. It is not possible to delete an
>> album
>> directly.
>>
>> // Pop up dialog to ask user whether to permanently delete
>> + // FIXME: This action is never used?? How can someone delete a
>> album
>> directly, without moving it to the trash first? + // This is
>> especially important when deleting from a different partiton or from a
>> net
>> source. + // Also note that we use the wrong icon for the
>> default album delete action, which should have a thrashcan icon instead
>> +
>> // of a red cross, it confuses users.
>
> The confirmation dialog has a checkbox for direct deletion.
> The user can assign a shortcut if he really wishes (though currently he
> cannot
> know from the action description which one is about images and which one
> about
> albums...) but for security, unrevocable delete is not directly
> accessible.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

--
Using Opera's revolutionary email client: http://www.opera.com/mail/
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Andi Clemens

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

In reply to this post by Marcel Wiesweg

What about handling the delete action like dolphin?
In dolphin, pressing the Shift key dynamically changes from the trashcan
action to the delete action:
Rightclick an item and while the context menu is shown, press shift. The
action will change.

Andi

On Sun, 25 Sep 2011 15:25:02 +0200, Marcel Wiesweg <[hidden email]>
wrote:

Marcel Wiesweg

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

> What about handling the delete action like dolphin?
> In dolphin, pressing the Shift key dynamically changes from the trashcan
> action to the delete action:
> Rightclick an item and while the context menu is shown, press shift. The
> action will change.

Interesting idea. How is it implemented, do we get key presses for Shift?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Andi Clemens

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

See here:
http://quickgit.kde.org/index.php?p=kde-baseapps.git&a=blob&h=617189715d0977db11a46a4ccf77446eee5b6ac8&hb=8229d6e31e280b78d7f46ea8cc856c2898af0df0&f=dolphin/src/dolphincontextmenu.cpp

Line 150 and below seem to handle the keypress events here. We could
implement this for the contextmenuhelper, for the main menu I guess it
wouldn't be possible (and practicable, since no one presses a modifier key
when browsing the main menu).

Andi

On Mon, 26 Sep 2011 21:57:26 +0200, Marcel Wiesweg <[hidden email]>
wrote:

>
>> What about handling the delete action like dolphin?
>> In dolphin, pressing the Shift key dynamically changes from the trashcan
>> action to the delete action:
>> Rightclick an item and while the context menu is shown, press shift. The
>> action will change.
>
> Interesting idea. How is it implemented, do we get key presses for Shift?
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

Marcel Wiesweg

Re: [digikam] digikam/main: Added comment about deleting albums. It is not possible to delete an album

> See here:
> http://quickgit.kde.org/index.php?p=kde-baseapps.git&a=blob&h=617189715d097
> 7db11a46a4ccf77446eee5b6ac8&hb=8229d6e31e280b78d7f46ea8cc856c2898af0df0&f=d
> olphin/src/dolphincontextmenu.cpp
>
> Line 150 and below seem to handle the keypress events here. We could
> implement this for the contextmenuhelper, for the main menu I guess it
> wouldn't be possible (and practicable, since no one presses a modifier key
> when browsing the main menu).

KModifierKeyInfo: Didn't know that one until now. Interesting.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel