digikam build failures on ARM/armel

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

digikam build failures on ARM/armel

Bugzilla from lure@kubuntu.org
Hello,

Ubuntu Jaunty is also being built on armel (planned to be used on ARM-based
netbooks) and we get build failure for digikam. Full build log is here:
http://launchpadlibrarian.net/21038146/buildlog_ubuntu-jaunty-
armel.digikam_2:0.10.0~beta8-0ubuntu1_FAILEDTOBUILD.txt.gz

The root cause seems to be in qreal vs. double changes:
[  5%] Building CXX object
digikam/CMakeFiles/digikamcore.dir/__/libs/dmetadata/geodetictools.o
cd "/build/buildd/digikam-0.10.0~beta8/obj-arm-linux-gnueabi/digikam" &&
/usr/bin/g++   -D_BSD_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -DQT_NO_STL -
DQT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS -
DQT3_SUPPORT -DQT3_SUPPORT_WARNINGS -DMAKE_DIGIKAMCORE_LIB -g -O2 -g -Wall -
O2 -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-
subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-exceptions -fno-
check-new -fno-common -Woverloaded-virtual -fno-threadsafe-statics -
fvisibility=hidden -fvisibility-inlines-hidden -O2 -g -fPIC -
I"/build/buildd/digikam-0.10.0~beta8/obj-arm-linux-gnueabi/digikam" -
I"/build/buildd/digikam-0.10.0~beta8/digikam" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/dimg" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/dimg/loaders" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/dimg/filters" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/whitebalance" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/dmetadata" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/histogram" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/curves" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/levels" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/lprof" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/jpegutils" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/greycstoration" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/threadimageio" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/widgets/common" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/widgets/imageplugins" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/widgets/metadata" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/widgets/iccprofiles" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/imageproperties" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/dialogs" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/database" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/database/sqlite2" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/database/haar" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/slideshow" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/imageeditor/editor"
-I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/imageeditor/canvas"
-I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/imageeditor/tools"
-
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/imageeditor/rawimport"
-I"/build/buildd/digikam-0.10.0~beta8/digikam/../libs/themeengine" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/kipiiface" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/cameragui" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/setup" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/batch" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/lighttable" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/searchwindow" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/fuzzysearch" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/gpssearch" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../utilities/timeline" -
I"/build/buildd/digikam-0.10.0~beta8/digikam/../digikam" -
I"/build/buildd/digikam-0.10.0~beta8/obj-arm-linux-gnueabi/digikam/.." -
I/usr/include/KDE -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns -
I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtHelp -
I/usr/include/qt4/QtAssistant -I/usr/include/qt4/QtDBus -
I/usr/include/qt4/QtTest -I/usr/include/qt4/QtUiTools -
I/usr/include/qt4/QtScript -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtXml -
I/usr/include/qt4/QtSql -I/usr/include/qt4/QtOpenGL -
I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtDesigner -
I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -
I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -
I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -I/usr/include/gphoto2   -
fno-tree-pre -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64      
-fexceptions -o CMakeFiles/digikamcore.dir/__/libs/dmetadata/geodetictools.o -
c "/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp"
/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp: In member
function 'QPointF Digikam::GeodeticCalculator::destinationGeographicPoint()':
/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:179:
error: no matching function for call to
'Digikam::GeodeticCalculator::destinationGeographicPoint(qreal*, qreal*)'
/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:164: note:
candidates are: bool
Digikam::GeodeticCalculator::destinationGeographicPoint(double*, double*)
/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:176: note:                
QPointF Digikam::GeodeticCalculator::destinationGeographicPoint()


We can probably fix this quickly by just casting qreal -> double in all cases
(as it looks like digikam uses mostly double, while Qt code in qreal). The
other option could be to use qreal in digikam code, but I am not sure if this
would have some side effect (loss of precission)...

Regards,
Luka
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: digikam build failures on ARM/armel

Bugzilla from lure@kubuntu.org
On Saturday 10 January 2009 18:10:24 Luka Renko wrote:

> -fexceptions -o
> CMakeFiles/digikamcore.dir/__/libs/dmetadata/geodetictools.o - c
> "/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp"
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp: In
> member function 'QPointF
> Digikam::GeodeticCalculator::destinationGeographicPoint()':
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:179:
> error: no matching function for call to
> 'Digikam::GeodeticCalculator::destinationGeographicPoint(qreal*, qreal*)'
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:164:
> note: candidates are: bool
> Digikam::GeodeticCalculator::destinationGeographicPoint(double*, double*)
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:176:
> note:                 QPointF
> Digikam::GeodeticCalculator::destinationGeographicPoint()
>
>
> We can probably fix this quickly by just casting qreal -> double in all
> cases (as it looks like digikam uses mostly double, while Qt code in
> qreal). The other option could be to use qreal in digikam code, but I am
> not sure if this would have some side effect (loss of precission)...
Ok, it looks like this is fixed with the following change. Can somebody review
this and tell me if this can be committed to SVN?

Regards,
Luka

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

01-kubuntu-fix-armel.patch (636 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: digikam build failures on ARM/armel

Gilles Caulier-4


2009/1/12 Luka Renko <[hidden email]>
On Saturday 10 January 2009 18:10:24 Luka Renko wrote:
> -fexceptions -o
> CMakeFiles/digikamcore.dir/__/libs/dmetadata/geodetictools.o - c
> "/build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp"
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp: In
> member function 'QPointF
> Digikam::GeodeticCalculator::destinationGeographicPoint()':
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:179:
> error: no matching function for call to
> 'Digikam::GeodeticCalculator::destinationGeographicPoint(qreal*, qreal*)'
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:164:
> note: candidates are: bool
> Digikam::GeodeticCalculator::destinationGeographicPoint(double*, double*)
> /build/buildd/digikam-0.10.0~beta8/libs/dmetadata/geodetictools.cpp:176:
> note:                 QPointF
> Digikam::GeodeticCalculator::destinationGeographicPoint()
>
>
> We can probably fix this quickly by just casting qreal -> double in all
> cases (as it looks like digikam uses mostly double, while Qt code in
> qreal). The other option could be to use qreal in digikam code, but I am
> not sure if this would have some side effect (loss of precission)...

Ok, it looks like this is fixed with the following change. Can somebody review
this and tell me if this can be committed to SVN?

Regards,
Luka

It's sound fine for me.

Marcel, your viewpoint ?

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: digikam build failures on ARM/armel

Marcel Wiesweg
In reply to this post by Bugzilla from lure@kubuntu.org

> Ok, it looks like this is fixed with the following change. Can somebody

> review this and tell me if this can be committed to SVN?

Very straightforward patch, of course it's ok for me to commit.

>

> Regards,

> Luka


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel