[digikam] [Bug 382953] New: Default differences between bootstrap and CMakeLists.txt

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382953

            Bug ID: 382953
           Summary: Default differences between bootstrap and
                    CMakeLists.txt
           Product: digikam
           Version: 5.7.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Bundle-Tarball
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

In the bootstrap scripts the default for e.g. opencv is 3 and mediaplayer is
on, while in the CMakeLists.txt these default to 2 and off. Is there a reason
for this or simply an oversight?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382953

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
bootstrap script are mostly dedicated in priority for the bundle.

As it can be customized i don't see any problem, excepted the fact to be
homogenous as you said...

I vote to put the same in bootstrap as cmakelists.txt.

For next 6.0.0, we will certainly drop openCV 2 support.

For QtAV, as it can depend of ffmpeg codecs which can be problematic in special
contry, it disabled by default.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382953

--- Comment #2 from Simon <[hidden email]> ---
Ok so these are all those that are different currently with the current
settings and my suggestion to make them the same:

 | bootstrap | cmake | suggestion
opencv3 | on | off | on
mediaplayer | on | off | off
dbus | linux:on rest:off | on | on
mysqlsupport | on | off | on
internalmysql | on | off | on

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382953

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.7.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/79bf081c5ee77dd518afeb
                   |                            |3dd0b7ceae660d1449

--- Comment #3 from Simon <[hidden email]> ---
Git commit 79bf081c5ee77dd518afeb3dd0b7ceae660d1449 by Simon Frei.
Committed on 31/07/2017 at 19:21.
Pushed by sfrei into branch 'master'.

Synchronize build flags to bootstrap (enable opencv3 & mysql by default)
FIXED-IN: 5.7.0

M  +3    -3    CMakeLists.txt

https://commits.kde.org/digikam/79bf081c5ee77dd518afeb3dd0b7ceae660d1449

--
You are receiving this mail because:
You are the assignee for the bug.