[digikam] [Bug 382677] New: Rating groups by mouse only changes first item.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

            Bug ID: 382677
           Summary: Rating groups by mouse only changes first item.
           Product: digikam
           Version: 5.6.0
          Platform: Appimage
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

If you group items and you have metadata group edit enabled rating a group only
works if you use the shortcuts (ctrl 0-5). If you use the mouse to change the
stars of a group only the first item in the group gets rated.

This is serious imo because you will get metadata inconsistency if you use your
mouse to change a rating.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
           Assignee|[hidden email]       |[hidden email]
     Ever confirmed|0                           |1

--- Comment #1 from Simon <[hidden email]> ---
Created attachment 106845
  --> https://bugs.kde.org/attachment.cgi?id=106845&action=edit
Considers grouping for rating applied via overlay

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Rating groups by mouse only |Rating groups by mouse only
                   |changes first item.[patch]  |changes first item [patch]
          Component|general                     |Labels

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

--- Comment #2 from Simon <[hidden email]> ---
@Gilles, Maik, ...: Good to go? It fixed the bug for me.

Just to try out how it works I also posted this on phabricator:
https://phabricator.kde.org/D6962
You can either ignore it (should be closed automatically once committed) or use
it to comment on the code.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Labels                      |Tags-Rating

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Patch work fine for me, commit it.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382677

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.7.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/0c7e25df54de368a8cd5f3
                   |                            |09380c6bbb1d659d51
         Resolution|---                         |FIXED

--- Comment #4 from Simon <[hidden email]> ---
Git commit 0c7e25df54de368a8cd5f309380c6bbb1d659d51 by Simon Frei.
Committed on 29/07/2017 at 15:07.
Pushed by sfrei into branch 'master'.

grouping: Fix setting rating via overlay

Requires new functionality to check for grouping for specific model indexes
instead of currently selected ones. To that end some refactoring was necessary,
but existing function signatures have not changed.
FIXED-IN: 5.7.0

M  +7    -16   app/items/digikamimageview.cpp
M  +0    -2    app/items/digikamimageview.h
M  +69   -49   app/items/imagecategorizedview.cpp
M  +11   -1    app/items/imagecategorizedview.h

https://commits.kde.org/digikam/0c7e25df54de368a8cd5f309380c6bbb1d659d51

--
You are receiving this mail because:
You are the assignee for the bug.