[digikam] [Bug 378219] New: Optimize includes and polish [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378219

            Bug ID: 378219
           Summary: Optimize includes and polish [patch]
           Product: digikam
           Version: 5.6.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 104783
  --> https://bugs.kde.org/attachment.cgi?id=104783&action=edit
Optimized includes and polish.

While working on a patch for #377719 I corrected unnecessary includes and
sorted them (unsorted leads to duplicates). I also did some small code
polishing. I just touched the parts of the code I was working on and related
stuff - so this is by no means exhaustive, there is probably more of the same.
I would like somebody to check that it compiles as well before committing -
thanks in advance.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378219

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Mario Frank <[hidden email]> ---
Did not have any problems compiling with your patch.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378219

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
Me too...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378219

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/e994827830382723272f0d
                   |                            |721e7d10dcc3be2338
   Version Fixed In|                            |5.6.0

--- Comment #3 from Simon <[hidden email]> ---
Git commit e994827830382723272f0d721e7d10dcc3be2338 by Simon Frei.
Committed on 29/03/2017 at 12:13.
Pushed by sfrei into branch 'master'.

Optimize includes and polish
FIXED-IN: 5.6.0

M  +2    -1    NEWS
M  +2    -2    app/items/imageviewutilities.cpp
M  +19   -17   app/views/digikamview.cpp
M  +2    -3    app/views/mediaplayerview.cpp
M  +2    -2    app/views/stackedview.h
M  +2    -3    app/views/trashview.cpp
M  +3    -5    app/views/trashview.h
M  +23   -23   libs/database/utils/dbsettingswidget.cpp
M  +6    -9    libs/database/utils/dbsettingswidget.h
M  +1    -3    libs/database/utils/dio.cpp
M  +2    -1    libs/database/utils/dio.h
M  +1    -1    libs/database/utils/dio_p.h
M  +0    -1    libs/dtrash/dtrashitemmodel.cpp
M  +3    -3    libs/iojobs/iojob.cpp
M  +1    -2    libs/iojobs/iojob.h
M  +2    -2    libs/iojobs/iojobsmanager.h
M  +3    -21   libs/iojobs/iojobsthread.cpp
M  +3    -10   libs/iojobs/iojobsthread.h
M  +1    -0    utilities/advancedrename/advancedrenameprocessdialog.cpp
M  +2    -8    utilities/advancedrename/advancedrenameprocessdialog.h
M  +3    -3    utilities/advancedrename/advancedrenamewidget.cpp

https://commits.kde.org/digikam/e994827830382723272f0d721e7d10dcc3be2338

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=378219

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability

--
You are receiving this mail because:
You are the assignee for the bug.