[digikam] [Bug 377638] New: Database directory ignoring hidden and unnecessarily in migration-dialogue

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

            Bug ID: 377638
           Summary: Database directory ignoring hidden and unnecessarily
                    in migration-dialogue
           Product: digikam
           Version: 5.5.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: setup
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 104584
  --> https://bugs.kde.org/attachment.cgi?id=104584&action=edit
Put ignored directories in its own tab

Problem:
The new functionality to ignore directories is hidden (as in you need to scroll
down a lot) as the database configuration widget is now very long.
Also this options do not really matter for database migration, but come up
there as well now. This dialogue is already pretty text heavy, this just adds
additional needless complexity.

Solution:
Take ignoring directories out of DatabaseSettingsWidget and add it to
SetupDatabase as a new tab.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Database directory ignoring |Database directory ignoring
                   |hidden and unnecessarily in |hidden and unnecessarily in
                   |migration-dialogue          |migration-dialogue [patch]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
The idea sound fine for me.

I do not see any problem in patch (not tested).

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

--- Comment #2 from Simon <[hidden email]> ---
@Gilles did you get a chance to test? It worked fine for me.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

--- Comment #3 from [hidden email] ---
yes, i will do it...

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

--- Comment #4 from [hidden email] ---
PAtch work fine for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377638

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |5.6.0
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/fe004359a3d73a69c8958a
                   |                            |532e88f8a6c9355f5a

--- Comment #5 from Simon <[hidden email]> ---
Git commit fe004359a3d73a69c8958a532e88f8a6c9355f5a by Simon Frei.
Committed on 19/03/2017 at 13:02.
Pushed by sfrei into branch 'master'.

Move ignoring directories to its own tab in configuration
FIXED-IN: 5.6.0

M  +2    -1    NEWS
M  +0    -72   libs/database/utils/dbsettingswidget.cpp
M  +0    -4    libs/database/utils/dbsettingswidget.h
M  +124  -39   utilities/setup/setupdatabase.cpp
M  +9    -0    utilities/setup/setupdatabase.h

https://commits.kde.org/digikam/fe004359a3d73a69c8958a532e88f8a6c9355f5a

--
You are receiving this mail because:
You are the assignee for the bug.