[digikam] [Bug 377197] New: Customize grouping behaviour

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #39 from Maik Qualmann <[hidden email]> ---
Ok, I also see no code for the kipi-Plugins in the patch, except for the
configuration. Simon, I would suggest setting the default for Kipi plugins to
NO and disable for selection this line. Or hide the line. And apply the patch.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #40 from [hidden email] ---
Simon,

The items selcted from icon view is passed to a plugin through the KIPI
interface. All is located in
core/utilities/kdesupport/kipi/kipiimagecollection.cpp. Look in function
images(), and especially line 188 which pass the selected items to the
interface as a list of URL. You nee to code something to take a care about the
grouped images in the current selection from icon view.

So the patch relevant must be located in DigikamView class.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #41 from Simon <[hidden email]> ---
That was too good to be true. The only change needed should be in line 190 of
kipiimagecollection.cpp:

    return DigikamApp::instance()->view()->selectedUrls();

to

    return
DigikamApp::instance()->view()->selectedUrls(ApplicationSettings::Kipi);

However the problem is, that the kipi plugins (at least dropbox and facebook)
call this function several times, so the dialog pop ups multiple times. That's
a very bad user experience. I had a quick look at it and it seems to construct
the KipiImageCollection several times. I don't know that part at all (and don't
use kipi), so I am not overly motivated to read all this code to debug this.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #42 from [hidden email] ---
>The only change needed should be in line 190 of kipiimagecollection.cpp:
>    return DigikamApp::instance()->view()->selectedUrls();
>to
>    return DigikamApp::instance()->view()->selectedUrls(ApplicationSettings::Kipi);

==> no. the only change is to patch DigikamView::selectedUrls() method to
return all grouped item depending of the application settings.

If you don't want to test with KIPI, i write a new application interface helper
to port batch tools from KIPI to digiKam core (yes, at least in the future only
export to web service tools will be hosted to KIPI. That all).

This new interface template is located in
core/utilities/assistants/common/dinfointerface.cpp. This is nothing to do here
are implementation is done with empty methods. The real implementation for
digiKam database is in core/libs/database/utils/dbinfoiface.cpp.

This implementation is mostly some code backport from kipi interface. I plan to
factorize this one with the Database info interface, later when implementation
will be finalized.

Currently HTMLGallery tool use this interface. When you start this tool, it can
use the image selection from icon view (look the option in intro page). If you
select some grouped items, only the first one of each groups is used instead
all items grouped (depending of grouped icon view option of course).

If you look on dbinfoiface.cpp::line 207, it call DigikamView::selectedUrls(),
which must return the right selection if grouped items are selected and
depending of icon view grouped options.

So, the patch to support grouped items from icon view must be done somewhere in
DigikamView::selectedUrls(). That all. all the rest (kipi included) will work
as expected.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #43 from [hidden email] ---
Ah i forget to said that Digikamview::allUrls() must be patch to return also
the grouped items list depending of digiKam settings.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #44 from [hidden email] ---
Simon,

Look this report :

https://bugs.kde.org/show_bug.cgi?id=286609

Panorama tool do not support grouped items behavior. Look how it's called from
DigikamApp::line 2621. It use also DigikamView::selectedUrls()...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #45 from Simon <[hidden email]> ---
Gilles,

This is all done already. DigikamView::selectedUrls() accepts an (optional)
argument (either bool or ApplicationSettings::OperationType) to include grouped
items or not.

The change I proposed is working. The problem is just that it is called several
times when opening a kipi plugin, so the dialog asking the user whether to
include grouped items or not appears several times. This is a problem of kipi
plugins calling KIPI::Interface::currentSelection() several times on opening,
each time triggering DigikamView::selectedUrls(Applicationsettings::Kipi) and
opening a dialog about grouping.

I will look at HTMLGallery and panorama tools to support grouping for them as
well.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #46 from [hidden email] ---
I do not see why it's called more than one time with KIPI plugins.

I see your screenshot of setup panel. I like the new settings. It's clear.

Just a remark : "kipi plugins" => "plugins" : since there is no more image
editor plugins, only KIPI provide digiKam plugins. So no need to name KIPI...,
just plugins is enough.

I try your patch now...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #47 from [hidden email] ---
Simon, patch 9 must be obsolete no ?

What's about Deduplicate code patch ? It's not integrated in patch 10 ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #48 from Simon <[hidden email]> ---
Yes, the deduplicate patch is integrated in the grouping patch. I just thought
that splitting the change into meaningful pieces makes it more readable (but
that's not really the case with patches, more with commits...) and maybe it
could be merged faster.

I will rename the kipi setting then.

About the panorama tool: That is already working with grouping in the current
patch.
I have a working solution for the html tool (it had the same problem as the
kipi tool with multiple dialogs), but I want to extend it. And I may be able to
fix this problem for the kipi plugins as well. So I will post an updated patch,
hopefully soon.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #49 from [hidden email] ---
The patch V10 cannot not be applied it against git/master. New version is ready
on my computer. I will post it in few minutes...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105330|0                           |1
        is obsolete|                            |
 Attachment #105389|0                           |1
        is obsolete|                            |

--- Comment #50 from [hidden email] ---
Created attachment 105446
  --> https://bugs.kde.org/attachment.cgi?id=105446&action=edit
Customize grouping behavior patch version 11

New version of patch compilable against git/master

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #51 from [hidden email] ---
I tested with patch v11 and HTMLExport and i do not see any difference while
processing items. No time latency or something like that.

My grouped album to test :

https://www.flickr.com/photos/digikam/34596906595/in/dateposted-public/

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #52 from Maik Qualmann <[hidden email]> ---
I have a compiler error here, but will check again, since Gilles has already
tested it already.

Maik

/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void
Digikam::DigikamImageView::deleteSelected(Digikam::ImageViewUtilities::DeleteMode)’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:384:58:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool)’
     ImageInfoList imageInfoList = selectedImageInfos(true);
                                                          ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList
Digikam::ImageCategorizedView::selectedImageInfos() const
     ImageInfoList          selectedImageInfos()             const;
                            ^~~~~~~~~~~~~~~~~~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void
Digikam::DigikamImageView::deleteSelectedDirectly(Digikam::ImageViewUtilities::DeleteMode)’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:394:58:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool)’
     ImageInfoList imageInfoList = selectedImageInfos(true);
                                                          ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList
Digikam::ImageCategorizedView::selectedImageInfos() const
     ImageInfoList          selectedImageInfos()             const;
                            ^~~~~~~~~~~~~~~~~~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:
In member function ‘void Digikam::DigikamImageView::rename()’:
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:431:67:
error: ‘needGroupResolving’ was not declared in this scope
     bool grouping = needGroupResolving(ApplicationSettings::Rename);
                                                                   ^
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:432:46:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedUrls(bool&)’
     QList<QUrl>  urls = selectedUrls(grouping);
                                              ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:81:28:
note: candidate: QList<QUrl> Digikam::ImageCategorizedView::selectedUrls()
const
     QList<QUrl>            selectedUrls()                   const;
                            ^~~~~~~~~~~~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:81:28:
note:   candidate expects 0 arguments, 1 provided
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:444:63:
error: no matching function for call to
‘Digikam::DigikamImageView::selectedImageInfos(bool&)’
         QUrl nextUrl =
nextInOrder(selectedImageInfos(grouping).last(),1).fileUrl();
                                                               ^
In file included from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.h:30:0,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview_p.h:36,
                 from
/home/maik/Devel/digikam-software-compilation/core/app/items/digikamimageview.cpp:28:
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note: candidate: Digikam::ImageInfoList
Digikam::ImageCategorizedView::selectedImageInfos() const
     ImageInfoList          selectedImageInfos()             const;
                            ^~~~~~~~~~~~~~~~~~
/home/maik/Devel/digikam-software-compilation/core/app/items/imagecategorizedview.h:79:28:
note:   candidate expects 0 arguments, 1 provided

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #53 from [hidden email] ---
This error can be generated by a different GC version than one, and of course
by different compilation options passed by KDE::ECM modules. Here we don't
manage anything.

The best way to hack is to check compilation trace with "export VERBOSE=1"

Mine :

[gilles@localhost core]$ gcc --version
gcc (GCC) 5.4.0

[ 85%] Building CXX object
core/app/CMakeFiles/digikamgui_src.dir/items/imagecategorizedview.cpp.o
cd /home/gilles/Devel/5.x/build/core/app && /bin/c++   -DLIBPGF_DISABLE_OPENMP
-DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII
-DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING
-DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER
-DTRANSLATION_DOMAIN=\"digikam\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE
-I/home/gilles/Devel/5.x/build/core/app -I/home/gilles/Devel/5.x/core/app
-I/home/gilles/Devel/5.x/core/app/date
-I/home/gilles/Devel/5.x/core/app/dragdrop
-I/home/gilles/Devel/5.x/core/app/filters
-I/home/gilles/Devel/5.x/core/app/items
-I/home/gilles/Devel/5.x/core/app/items/overlays
-I/home/gilles/Devel/5.x/core/app/main -I/home/gilles/Devel/5.x/core/app/utils
-I/home/gilles/Devel/5.x/core/app/views
-I/home/gilles/Devel/5.x/core/app/views/tableview
-I/home/gilles/Devel/5.x/core/libs/album
-I/home/gilles/Devel/5.x/core/libs/database/collection
-I/home/gilles/Devel/5.x/core/libs/database/coredb
-I/home/gilles/Devel/5.x/core/libs/database/dbjobs
-I/home/gilles/Devel/5.x/core/libs/database/engine
-I/home/gilles/Devel/5.x/core/libs/database/haar
-I/home/gilles/Devel/5.x/core/libs/database/imagehistory
-I/home/gilles/Devel/5.x/core/libs/database/imgqsort
-I/home/gilles/Devel/5.x/core/libs/database/item
-I/home/gilles/Devel/5.x/core/libs/database/server
-I/home/gilles/Devel/5.x/core/libs/database/tags
-I/home/gilles/Devel/5.x/core/libs/database/thumbsdb
-I/home/gilles/Devel/5.x/core/libs/database/utils
-I/home/gilles/Devel/5.x/core/libs/dialogs
-I/home/gilles/Devel/5.x/core/libs/dimg
-I/home/gilles/Devel/5.x/core/libs/dimg/dklcms
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/auto
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/bcg
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/bw
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/cb
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/curves
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/decorate
-I/home/gilles/Devel/5.x/core/libs/dimg/filters
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/film
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/fx
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration/cimg
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/hsl
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/icc
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/lc
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/lens
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/levels
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/nr
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/redeye
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/sharp
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/transform
-I/home/gilles/Devel/5.x/core/libs/dimg/filters/wb
-I/home/gilles/Devel/5.x/core/libs/dimg/imagehistory
-I/home/gilles/Devel/5.x/core/libs/dimg/loaders
-I/home/gilles/Devel/5.x/core/libs/dmetadata
-I/home/gilles/Devel/5.x/core/libs/dngwriter
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/md5
-I/home/gilles/Devel/5.x/core/libs/dngwriter/extra/xmp_sdk/include
-I/home/gilles/Devel/5.x/core/libs/dtrash
-I/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing
-I/home/gilles/Devel/5.x/core/libs/facesengine/alignment-flandmark
-I/home/gilles/Devel/5.x/core/libs/facesengine
-I/home/gilles/Devel/5.x/core/libs/facesengine/detection
-I/home/gilles/Devel/5.x/core/libs/facesengine/facedb
-I/home/gilles/Devel/5.x/core/libs/facesengine/preprocessing-tantriggs
-I/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-lbph
-I/home/gilles/Devel/5.x/core/libs/facesengine/shape-predictor
-I/home/gilles/Devel/5.x/core/libs/fileactionmanager
-I/home/gilles/Devel/5.x/core/libs/filters
-I/home/gilles/Devel/5.x/core/libs/imageproperties
-I/home/gilles/Devel/5.x/core/libs/iojobs
-I/home/gilles/Devel/5.x/core/libs/jpegutils
-I/home/gilles/Devel/5.x/core/libs/kmemoryinfo
-I/home/gilles/Devel/5.x/core/libs/models
-I/home/gilles/Devel/5.x/core/libs/notificationmanager
-I/home/gilles/Devel/5.x/core/libs/pgfutils
-I/home/gilles/Devel/5.x/core/libs/progressmanager
-I/home/gilles/Devel/5.x/core/libs/rawengine
-I/home/gilles/Devel/5.x/core/libs/rawengine/libraw/internal
-I/home/gilles/Devel/5.x/core/libs/rawengine/libraw/libraw
-I/home/gilles/Devel/5.x/core/libs/settings
-I/home/gilles/Devel/5.x/core/libs/tags
-I/home/gilles/Devel/5.x/core/libs/tags/tagsmanager/models
-I/home/gilles/Devel/5.x/core/libs/tags/tagsmanager
-I/home/gilles/Devel/5.x/core/libs/template
-I/home/gilles/Devel/5.x/core/libs/threadimageio
-I/home/gilles/Devel/5.x/core/libs/threads
-I/home/gilles/Devel/5.x/core/libs/versionmanager
-I/home/gilles/Devel/5.x/core/libs/widgets/colors
-I/home/gilles/Devel/5.x/core/libs/widgets/combo
-I/home/gilles/Devel/5.x/core/libs/widgets/common
-I/home/gilles/Devel/5.x/core/libs/widgets/files
-I/home/gilles/Devel/5.x/core/libs/widgets/fonts
-I/home/gilles/Devel/5.x/core/libs/widgets/graphicsview
-I/home/gilles/Devel/5.x/core/libs/widgets/iccprofiles
-I/home/gilles/Devel/5.x/core/libs/widgets/imagehistory
-I/home/gilles/Devel/5.x/core/libs/widgets/itemview
-I/home/gilles/Devel/5.x/core/libs/widgets/mainview
-I/home/gilles/Devel/5.x/core/libs/widgets/metadata
-I/home/gilles/Devel/5.x/core/showfoto/main
-I/home/gilles/Devel/5.x/core/showfoto/setup
-I/home/gilles/Devel/5.x/core/showfoto/thumbbar
-I/home/gilles/Devel/5.x/core/tests/advancedrename
-I/home/gilles/Devel/5.x/core/tests/albummodel
-I/home/gilles/Devel/5.x/core/tests/database
-I/home/gilles/Devel/5.x/core/tests/dimg
-I/home/gilles/Devel/5.x/core/tests/dmetadata
-I/home/gilles/Devel/5.x/core/tests/facesengine
-I/home/gilles/Devel/5.x/core/tests/facesengine/demo
-I/home/gilles/Devel/5.x/core/tests/fileio
-I/home/gilles/Devel/5.x/core/tests/geolocation/editor
-I/home/gilles/Devel/5.x/core/tests/geolocation/geoiface/calibrator
-I/home/gilles/Devel/5.x/core/tests/geolocation/geoiface/demo
-I/home/gilles/Devel/5.x/core/tests/geolocation/geoiface
-I/home/gilles/Devel/5.x/core/tests/iojobs
-I/home/gilles/Devel/5.x/core/tests/modeltest
-I/home/gilles/Devel/5.x/core/tests/multithreading
-I/home/gilles/Devel/5.x/core/tests/timestampupdate
-I/home/gilles/Devel/5.x/core/tests/widgets
-I/home/gilles/Devel/5.x/core/utilities/advancedrename
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/common
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/parser
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/parser/modifiers
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/parser/options
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/parser/options/database
-I/home/gilles/Devel/5.x/core/utilities/advancedrename/parser/options/database/keys
-I/home/gilles/Devel/5.x/core/utilities/assistants/calendar/print
-I/home/gilles/Devel/5.x/core/utilities/assistants/calendar/wizard
-I/home/gilles/Devel/5.x/core/utilities/assistants/common
-I/home/gilles/Devel/5.x/core/utilities/assistants/expoblending/blendingdlg
-I/home/gilles/Devel/5.x/core/utilities/assistants/expoblending/manager
-I/home/gilles/Devel/5.x/core/utilities/assistants/expoblending/wizard
-I/home/gilles/Devel/5.x/core/utilities/assistants/firstrun
-I/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/generator
-I/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/parameters
-I/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/wizard
-I/home/gilles/Devel/5.x/core/utilities/assistants/panorama/manager
-I/home/gilles/Devel/5.x/core/utilities/assistants/panorama/ptoparser
-I/home/gilles/Devel/5.x/core/utilities/assistants/panorama/ptotype
-I/home/gilles/Devel/5.x/core/utilities/assistants/panorama/tasks
-I/home/gilles/Devel/5.x/core/utilities/assistants/panorama/wizard
-I/home/gilles/Devel/5.x/core/utilities/facemanagement
-I/home/gilles/Devel/5.x/core/utilities/fuzzysearch
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/backends
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/bookmark
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/correlator
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/dialog
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/dragdrop
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/items
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/reversegeocoding
-I/home/gilles/Devel/5.x/core/utilities/geolocation/editor/searches
-I/home/gilles/Devel/5.x/core/utilities/geolocation/geoiface
-I/home/gilles/Devel/5.x/core/utilities/geolocation/geoiface/backends
-I/home/gilles/Devel/5.x/core/utilities/geolocation/geomapwrapper
-I/home/gilles/Devel/5.x/core/utilities/geolocation/mapsearches
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/core
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/dialogs
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/editor
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/main
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/printiface
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/rawimport
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/colors
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/decorate
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/enhance
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/enhance/hotpixels
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/filters
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/tools/transform
-I/home/gilles/Devel/5.x/core/utilities/imageeditor/widgets
-I/home/gilles/Devel/5.x/core/utilities/importui/backend
-I/home/gilles/Devel/5.x/core/utilities/importui/dialogs
-I/home/gilles/Devel/5.x/core/utilities/importui/items
-I/home/gilles/Devel/5.x/core/utilities/importui/main
-I/home/gilles/Devel/5.x/core/utilities/importui/models
-I/home/gilles/Devel/5.x/core/utilities/importui/views
-I/home/gilles/Devel/5.x/core/utilities/importui/widgets
-I/home/gilles/Devel/5.x/core/utilities/kdesupport/akonadi
-I/home/gilles/Devel/5.x/core/utilities/kdesupport/kfilemetadata
-I/home/gilles/Devel/5.x/core/utilities/kdesupport/kipi
-I/home/gilles/Devel/5.x/core/utilities/kdesupport/ksane
-I/home/gilles/Devel/5.x/core/utilities/lighttable
-I/home/gilles/Devel/5.x/core/utilities/maintenance
-I/home/gilles/Devel/5.x/core/utilities/metadataedit/dialog
-I/home/gilles/Devel/5.x/core/utilities/metadataedit/exif
-I/home/gilles/Devel/5.x/core/utilities/metadataedit/iptc
-I/home/gilles/Devel/5.x/core/utilities/metadataedit/xmp
-I/home/gilles/Devel/5.x/core/utilities/presentation/audio
-I/home/gilles/Devel/5.x/core/utilities/presentation/common
-I/home/gilles/Devel/5.x/core/utilities/presentation/dialogs
-I/home/gilles/Devel/5.x/core/utilities/presentation/opengl
-I/home/gilles/Devel/5.x/core/utilities/presentation
-I/home/gilles/Devel/5.x/core/utilities/presentation/widgets
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/main
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/manager
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/color
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/convert
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/custom
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/decorate
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/enhance
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/filters
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/metadata
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/tools/transform
-I/home/gilles/Devel/5.x/core/utilities/queuemanager/views
-I/home/gilles/Devel/5.x/core/utilities/searchwindow
-I/home/gilles/Devel/5.x/core/utilities/setup/album
-I/home/gilles/Devel/5.x/core/utilities/setup/camera
-I/home/gilles/Devel/5.x/core/utilities/setup/collections
-I/home/gilles/Devel/5.x/core/utilities/setup/editor
-I/home/gilles/Devel/5.x/core/utilities/setup/metadata
-I/home/gilles/Devel/5.x/core/utilities/setup
-I/home/gilles/Devel/5.x/core/utilities/slideshow
-I/home/gilles/Devel/5.x/core/libs/jpegutils/libjpeg-84
-I/home/gilles/Devel/5.x/build/core/app/utils
-I/home/gilles/Devel/5.x/build/extra/libkipi/src -I"/lib64/qt5/include/QtAV
/lib64/qt5/include/QtAVWidgets" -I/usr/include/opencv -I/usr/lib64/qt5/include
-I/usr/lib64/qt5/include/QtWebKitWidgets -I/usr/lib64/qt5/include/QtWebKit
-I/usr/lib64/qt5/include/QtGui -I/usr/lib64/qt5/include/QtCore
-I/usr/lib64/qt5/./mkspecs/linux-g++ -I/usr/lib64/qt5/include/QtNetwork
-I/usr/lib64/qt5/include/QtWidgets -I/usr/lib64/qt5/include/QtXml
-I/usr/lib64/qt5/include/QtSql -I/usr/include/KF5/KI18n -I/usr/include/KF5
-I/usr/include/KF5/Solid -I/usr/include/KF5/KCoreAddons
-I/usr/include/KF5/KWindowSystem -I/usr/include/KF5/KXmlGui
-I/usr/lib64/qt5/include/QtDBus -I/usr/include/KF5/KConfigCore
-I/usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs
-I/usr/include/KF5/KWidgetsAddons -I/usr/include/KF5/KConfigGui
-I/usr/include/KF5/KAuth -I/usr/include/KF5/KService
-I/usr/include/KF5/KIOWidgets -I/usr/include/KF5/KIOCore
-I/usr/include/KF5/KJobWidgets -I/usr/include/KF5/KCompletion
-I/usr/lib64/qt5/include/QtOpenGL -I/usr/include/gphoto2  -std=c++0x
-fno-operator-names -Wall -Wextra -Wcast-align -Wchar-subscripts
-Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor
-Woverloaded-virtual -Werror=return-type   -std=c++0x -fno-operator-names -Wall
-Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long
-Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual
-Werror=return-type   -std=c++0x -fno-operator-names -Wall -Wextra -Wcast-align
-Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef
-Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -fexceptions -g
-fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -o
CMakeFiles/digikamgui_src.dir/items/imagecategorizedview.cpp.o -c
/home/gilles/Devel/5.x/core/app/items/imagecategorizedview.cpp

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #54 from Maik Qualmann <[hidden email]> ---
Gilles,

The patch can not compile, the imagecategorizedview.h is not patched.

maik@linux-tpgn:~ gcc --version
gcc (SUSE Linux) 6.3.1 20170202 [gcc-6-branch revision 245119]

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105446|0                           |1
        is obsolete|                            |

--- Comment #55 from [hidden email] ---
Created attachment 105453
  --> https://bugs.kde.org/attachment.cgi?id=105453&action=edit
Customize grouping behavior patch version 12

This one must compile fine...

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #56 from Simon <[hidden email]> ---
Created attachment 105454
  --> https://bugs.kde.org/attachment.cgi?id=105454&action=edit
Customize grouping behavior patch version 12

These changes somehow went missing patch 11, 12 should compile again (doesn't
contain anything new of notice yet).

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105453|0                           |1
        is obsolete|                            |
 Attachment #105454|0                           |1
        is obsolete|                            |

--- Comment #57 from Simon <[hidden email]> ---
Created attachment 105488
  --> https://bugs.kde.org/attachment.cgi?id=105488&action=edit
Customize grouping behavior patch version 13

So I did not follow through with my earlier statement and did patch
kipi-plugins. I reduced the number of ImageCollection instances created and
removed redundant calls to loadImagesFromCurrentSelection(). Before these were
merely inefficient, with this new grouping dialog these calls were disruptive.
Now everything runs smoothly (I hope I caught all plugins, I must admit I
didn't actually try all of them).

The html gallery does work with grouping as well now (part of "Tools"). I also
added the grouping functionality when the album selector is used for
consistency.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=377197

--- Comment #58 from Simon <[hidden email]> ---
Created attachment 105489
  --> https://bugs.kde.org/attachment.cgi?id=105489&action=edit
Adjust kipi-plugins for grouping

--
You are receiving this mail because:
You are the assignee for the bug.