[digikam] [Bug 376423] New: Inconsistent ENTER key in thumbnails view

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

            Bug ID: 376423
           Summary: Inconsistent ENTER key in thumbnails view
           Product: digikam
           Version: 5.4.0
          Platform: MS Windows
                OS: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Thumbnails
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

The action of the ENTER key is inconsistent in the thumbnails view.

With an image selected in the thumbnails view, hitting the ENTER key sometimes
opens the preview view and sometimes does nothing.

To reproduce, double-click an image in the thumbnails view to open the preview
window. Exit the preview window by pressing the ESCAPE key. At this point, you
can move the selection to different images using the UP/DOWN/LEFT/RIGHT arrow
keys. Pressing ENTER will open the selected image in preview. This is the
desired operation (in my opinion).

If, instead of using the arrow keys, you move the selection to another image by
clicking on it with the mouse, the ENTER key will NOT open the preview. This
also seems to be the default mode when the thumbnail view is first opened.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
I think this problem have been fixed in next release.

Take a look to 5.5.0 pre version available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

--- Comment #2 from Bill Goodman <[hidden email]> ---
(In reply to caulier.gilles from comment #1)
> I think this problem have been fixed in next release.
>
> Take a look to 5.5.0 pre version available here :
>
> https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM
>
> Gilles Caulier

I installed the version above on Windows 7. The issue is still there. ENTER has
no effect after the selection is changed with a mouse click.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|5.4.0                       |5.5.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
I can confirm the behavior from the Enter key on Linux. Actually, the F3 key is
to call the preview. There is really no code that prompts the Enter key for the
preview. I look at it.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

--- Comment #4 from Bill Goodman <[hidden email]> ---
There is a configuration setting (Views>Icons>Thumbnail click action) which
selects either preview or image editor. This seems to be for a "double-click"
action in spite of the name saying "click".

It seems natural to me for the ENTER key to do the same action that
double-click does in this context.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

--- Comment #5 from [hidden email] ---
Maik,

If i remember, the Enter key must be catch by Captions/Tags right sidebar.
There is an event handler about keys.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

--- Comment #6 from Maik Qualmann <[hidden email]> ---
The cause I have found, it comes from the item activation. We save the last
mouse event and check the click area. This is bad with the Enter key. I am
looking for a clean solution...

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376423

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.5.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/aa084a182beef888ae6015
                   |                            |06550c89b2d7a74610

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Git commit aa084a182beef888ae601506550c89b2d7a74610 by Maik Qualmann.
Committed on 15/02/2017 at 21:31.
Pushed by mqualmann into branch 'master'.

fix inconsistent item activation with Enter key after mouse actions
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +2    -1    libs/widgets/itemview/itemviewcategorized.cpp

https://commits.kde.org/digikam/aa084a182beef888ae601506550c89b2d7a74610

--
You are receiving this mail because:
You are the assignee for the bug.