[digikam] [Bug 376074] New: Display-bookmarked-positions-on-the-map button doesn't work.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

            Bug ID: 376074
           Summary: Display-bookmarked-positions-on-the-map button doesn't
                    work.
           Product: digikam
           Version: 5.5.0
          Platform: Appimage
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Geolocation-Editor
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

In the Geolocation Editor the Display-bookmarked-positions-on-the-map button
doesn't work.

I created some bookmarks in Marble, opened digiKam, called the Geolocation
Editor, moved the map to the region where I created the bookmarks and clicked
that button but nothing happens.

Did I get something wrong, is it a bug or is the function simply not
implemented yet?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Maik Qualmann <[hidden email]> ---
There are several problems. DigiKam actually has its own bookmark management
which works for the Marble map and Google map. However, the function to edit
the bookmarks requires a complete KDE in the background with DBus support.
Works here for example without an AppImage under openSUSE with no problems. On
the other hand, Marble has his own bookmark management. This allows you to set
bookmarks via the context menu in digiKam and are also displayed in Marble. But
we do not show these Marble bookmarks. We could switch to the Marble bookmarks,
but we have no bookmarks in the Google map. I vote for implementing the
bookmark management without KBookmarks.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
yes, me too. KBookmark is again another run time puzzle for a simple function
to provide, which is not very well portable.

Note : Perhaps Marble bookmark can be/have been improved recently. I know that
Marble team work hard to provide a real framework with better cmake support.
AppImage bundle use an older version of Marble currently. It's perhaps time to
check the new implementation.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #3 from Wolfgang Scheffner <[hidden email]> ---
Maik,

>On the other hand, Marble has his own bookmark management.
>This allows you to set bookmarks via the context menu in digiKam
>and are also displayed in Marble.

I tested this, created a bookmark in digiKam and then took a look into Marble.
Indeed!!! The bookmark was there - but all my others were gone!!!!
Wonderful function! Seems first thing to do for me is to put a warning in the
doc.

>I vote for implementing the bookmark management without KBookmarks.
and Gilles:
>yes, me too

Well, at least Marble has a bookmark management and digiKam not. And without
that the whole thing is useless IMHO.

>It's perhaps time to check the new implementation.

Very good idea I would think under this circumstances. Could save us a lot of
work if they did something good. At least the bookmark management is not too
bad.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from [hidden email] ---
*** Bug 374710 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

tuxflo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from tuxflo <[hidden email]> ---
Any updates on that? Is it possible to install the KDE dependencies to get the
old editable bookmarkmenu back, and if yes which packages do we have to
install?
Or is it possible to edit the file where the bookmarks are saved manually?

Right now, the "Edit Bookmarks" dropdown entry just does NOTHING.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #6 from Wolfgang Scheffner <[hidden email]> ---
Gilles,
did you already check the new implementation or even put it into the AppImage
bundle?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #7 from [hidden email] ---
Hi Wolfgang,

I currently try to use new Marble version with digiKam, with native Linux
Environnent and with AppImage bundle. There are some technical problems.

Typically, the bundle use an old version of Marble, released one year ago.
Using last implementation, introduce linking problem and serious crashes. I
think the port to pure KF5 framework of Marble is not yet complete or badly
done. I hope this situation will improved soon, as i see some message about in
kde core mailing list.

After that, the goal is to drop KBookmark support in digiKam and to use Marble
bookmark instead. I don't yet checked the Marble API and i hope that all will
be suitable as we need for digiKam. Else, another feedback need to be done with
Marble team to adjust public API.

Voilà the current situation of my investigations.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #8 from Maik Qualmann <[hidden email]> ---
The old bookmark administration works here under openSUSE without problems. But
it requires a working KF5 desktop.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #9 from tuxflo <[hidden email]> ---
Which version of marble/kbookmarks do you have installed?
I'm running KDE Neon, so KF5 desktop is avalible here.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

--- Comment #10 from [hidden email] ---
Git commit 112215b78a7cc9679a050c470444543b9db3a60b by Gilles Caulier.
Committed on 15/05/2017 at 15:29.
Pushed by cgilles into branch 'master'.

add new GPS bookmarks manager for Geolocation Editor
remove KF5::Bookmarks dependency which do not wrok with AppImage, MacOS bundle
and Windows installer,
due to run-time dependencies and DBus requirements.
Implementation is not yet finalized and need to be polished before 5.6.0
release, especially to be able to import older
GPS bookmarks generated by DK < 5.6.0
Related: bug 376687, bug 376391, bug 374710, bug 376407

M  +0    -3    CMakeLists.txt
M  +0    -4    app/CMakeLists.txt
M  +8    -18   utilities/geolocation/editor/CMakeLists.txt
A  +273  -0    utilities/geolocation/editor/bookmark/bookmarknode.cpp    
[License: GPL (v2+)]
A  +114  -0    utilities/geolocation/editor/bookmark/bookmarknode.h    
[License: GPL (v2+)]
A  +325  -0    utilities/geolocation/editor/bookmark/bookmarksdlg.cpp    
[License: GPL (v2+)]
A  +132  -0    utilities/geolocation/editor/bookmark/bookmarksdlg.h    
[License: GPL (v2+)]
A  +301  -0    utilities/geolocation/editor/bookmark/bookmarksmenu.cpp    
[License: GPL (v2+)]
A  +137  -0    utilities/geolocation/editor/bookmark/bookmarksmenu.h    
[License: GPL (v2+)]
A  +726  -0    utilities/geolocation/editor/bookmark/bookmarksmngr.cpp    
[License: GPL (v2+)]
A  +236  -0    utilities/geolocation/editor/bookmark/bookmarksmngr.h    
[License: GPL (v2+)]
M  +37   -25   utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.cpp
M  +17   -11   utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.h
M  +63   -52   utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp
M  +20   -18   utilities/geolocation/editor/bookmark/gpsbookmarkowner.h
M  +7    -40   utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +14   -31   utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp
M  +3    -9    utilities/geolocation/editor/items/gpsimagelistcontextmenu.h
M  +6    -25   utilities/geolocation/editor/searches/searchwidget.cpp
M  +1    -7    utilities/geolocation/editor/searches/searchwidget.h

https://commits.kde.org/digikam/112215b78a7cc9679a050c470444543b9db3a60b

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376074

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.6.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/95b5cec4970939d5068ca1
                   |                            |3ce3e3198fc929cc5b

--- Comment #11 from [hidden email] ---
Git commit 95b5cec4970939d5068ca13ce3e3198fc929cc5b by Gilles Caulier.
Committed on 17/05/2017 at 10:04.
Pushed by cgilles into branch 'master'.

remove menu and toolbar bookmarks management from GPS bookmarks manager.
Now a first version suitable is available. More improvements will come later.
Import form older GPS bookmarks generated bu KF5::bookmarks run fine as well.
Related: bug 376687, bug 376391, bug 374710, bug 376407
FIXED-IN: 5.6.0

M  +11   -5    utilities/geolocation/editor/bookmark/bookmarksdlg.cpp
M  +2    -2    utilities/geolocation/editor/bookmark/bookmarksmenu.cpp
M  +6    -123  utilities/geolocation/editor/bookmark/bookmarksmngr.cpp
M  +0    -2    utilities/geolocation/editor/bookmark/bookmarksmngr.h
M  +1    -1    utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp
M  +23   -19   utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp

https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b

--
You are receiving this mail because:
You are the assignee for the bug.

[saim1234]

woww