[digikam] [Bug 375770] New: Creating tag from left panel causes error

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

            Bug ID: 375770
           Summary: Creating tag from left panel causes error
           Product: digikam
           Version: 5.4.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

When using the left panel 'Enter tag here.' field to create a non-existing tag
on multiple selected images, the following error dialog box happens:

|Tag creation Error
|An error occurred during tag creation:
|Tag Path               Error
|Earth2                 Tag name already exists

And then the following apply dialog box:

|Apply changes?
|You have edited the metadata of XX images:
|-caption
|-tags
|Do you want to apply your changes?
|Always apply changes without confirmation

The second error (Apply changes) happens when one or more images are selected.
The first (Tag creation Error) and second (Apply changes) errors both happen
when more than one image is selected.

It seems when multiple images are selected during tag creation, the tag is
trying to be created for each individual file instead of created for the first
and selected for the rest.

It seems there may be two separate issues here, the 'Tag creation Error' issue
and the 'Apply changes' issue.  If selecting a pre-existing tag does not cause
the apply changes dialog box, then creating a new tag should not cause the
apply changes dialog box either.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

--- Comment #1 from J-o-h-n- <[hidden email]> ---
This happens on both Windows 10 x64 and Ubuntu-Gnome 16.04 x64.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Git commit e23e4693169bf406e950e66d2377dee84a3ae866 by Maik Qualmann.
Committed on 31/01/2017 at 18:53.
Pushed by mqualmann into branch 'master'.

fix double signal from the AddTagsLineEdit

M  +10   -2    libs/tags/addtagslineedit.cpp

https://commits.kde.org/digikam/e23e4693169bf406e950e66d2377dee84a3ae866

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
I think you mean the right sidebar and not the left one? I could only see a
double error box when an existing tag was created from the completer. The other
problems I can not reproduce, possibly they are related to the double signal.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/e23e4693169bf406e950e6
                   |                            |6d2377dee84a3ae866
   Version Fixed In|                            |5.5.0
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Tested again with the AppImage, yes the bug is now fixed. I close this bug now.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

--- Comment #5 from J-o-h-n- <[hidden email]> ---
Sorry, I missed this one.  Yes, I did mean the right-panel, not the left.

When creating a new tag this way, is it intentional to force apply tags at the
same time?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

--- Comment #6 from Maik Qualmann <[hidden email]> ---
> When creating a new tag this way, is it intentional to force apply tags at
> the same time?

I think yes, I check the behavior but again with digikam-4.x.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375770

Wolfgang Scheffner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Wolfgang Scheffner <[hidden email]> ---
Whether tags should be force applied is debatable but since both ways have
their advantages I would vote for leaving it the way it is.
Note that the appearance of the confirmation dialog depends on your settings in
Configure digiKam/Miscellaneous/"Do not confirm when applying changes in the
right sidebar" (Wording could be better perhaps, at least I have to think twice
;-)).

--
You are receiving this mail because:
You are the assignee for the bug.