[digikam] [Bug 374671] New: Breeze Icons missing dark icons

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

            Bug ID: 374671
           Summary: Breeze Icons missing dark icons
           Product: digikam
           Version: 5.4.0
          Platform: Mac OS X Disk Images
                OS: OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 103246
  --> https://bugs.kde.org/attachment.cgi?id=103246&action=edit
icons

I am trying out the 5.4.0 beta on Mac OS X.  I want to use the "ShadeOfGray" or
"GrayCard" theme.  I went to the Miscellaneous Settings and tried to change the
Icon Theme, but there is no options for a "dark" icon set.  The only two
options are "Breeze" and "Use Icon Theme From System". Without the dark icons,
the icons are invisible with these gray themes.

An example is shown in the attachment.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #1 from Geoff King <[hidden email]> ---
Created attachment 103247
  --> https://bugs.kde.org/attachment.cgi?id=103247&action=edit
icons2

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
I identified that only standard breeze icon path is bundled in rcc file, not
breeze-dark. The code relevant is at this line :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/macports/icon-rcc/CMakeLists.txt#n24

This is true for AppImage, MXE and Macports.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #3 from [hidden email] ---
Git commit a1fea8affc57df5008407b7e2c494d3e0be2b6c4 by Gilles Caulier.
Committed on 15/01/2017 at 15:25.
Pushed by cgilles into branch 'master'.

manage breeze and breeze-dark icon themes from ressource files.
Related: bug 374313

M  +39   -8    libs/widgets/mainview/dxmlguiwindow.cpp

https://commits.kde.org/digikam/a1fea8affc57df5008407b7e2c494d3e0be2b6c4

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #4 from [hidden email] ---
Git commit a5664d2515aef4cabbe5b85e79c9304d384886e4 by Gilles Caulier.
Committed on 15/01/2017 at 15:27.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in AppImage bundles
Related: bug 374313

M  +1    -0    project/bundles/appimage/04-build-appimage.sh
M  +13   -5    project/bundles/appimage/icon-rcc/CMakeLists.txt

https://commits.kde.org/digikam-software-compilation/a5664d2515aef4cabbe5b85e79c9304d384886e4

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #5 from [hidden email] ---
Git commit bfc94680177ebc360fa11fe3e67dc5fa713562e8 by Gilles Caulier.
Committed on 15/01/2017 at 16:41.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in MacOS bundles
Related: bug 374313

M  +1    -0    project/bundles/macports/04-build-installer.sh
M  +13   -5    project/bundles/macports/icon-rcc/CMakeLists.txt
M  +1    -1    project/bundles/macports/installer/digikam.pkgproj

https://commits.kde.org/digikam-software-compilation/bfc94680177ebc360fa11fe3e67dc5fa713562e8

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam-software-compilation/6
                   |                            |a762e3d50f6cbb45c7db65ce5e0
                   |                            |f814b155da6a
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from [hidden email] ---
Git commit 6a762e3d50f6cbb45c7db65ce5e0f814b155da6a by Gilles Caulier.
Committed on 15/01/2017 at 18:09.
Pushed by cgilles into branch 'master'.

package breeze and breeze-drask icons set as ressource files
Store files in MacOS bundles
Related: bug 374313

M  +1    -0    project/bundles/mxe/04-build-installer.sh
M  +14   -6    project/bundles/mxe/icon-rcc/CMakeLists.txt

https://commits.kde.org/digikam-software-compilation/6a762e3d50f6cbb45c7db65ce5e0f814b155da6a

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.5.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #7 from [hidden email] ---
Geoff,

A new 5.5.0-pre release MacOS package is now available for testing at usual
place :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #8 from Geoff King <[hidden email]> ---
Created attachment 103433
  --> https://bugs.kde.org/attachment.cgi?id=103433&action=edit
update screenshot

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

--- Comment #9 from Geoff King <[hidden email]> ---
Hello,
I tried the 5.5.0-pre release MacOS package and the icons look great throughout
the main interface. Thank You.  

However, One thing to note is that icons in the menus are now light in color
compared to the text (but still visible).  Can these be made darker like other
text in the menu?  See the screenshot.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374671

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Bundle-MacOS

--
You are receiving this mail because:
You are the assignee for the bug.