[digikam] [Bug 374071] New: Tags checkbox tristate incorrect when deselecting tagged images (off-by-one)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374071

            Bug ID: 374071
           Summary: Tags checkbox tristate incorrect when deselecting
                    tagged images (off-by-one)
           Product: digikam
           Version: 5.4.0
          Platform: Other
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

This happens since 5.4.0 (maybe 5.3.0?).

1. Open an album where there are *some* images with tags and some without.
2. Select all images (Ctl-A)
3. Open Tag Editor (right panel). The matching tags checkboxes will be grey
(tristate).
4. Manually deselect all images matching the half-checked tag (Ctrl+Mouse)

Result: The tag is still in tristate (grey box).

Expected result: The tag should be unchecked since I deselected all tagged
images.

5. Deselect one more image which does not have the tag.

Result: The tag is unchecked.
Expected Result: This should have happened after step 4 already.

6. Reselect the non-tagged image.

Result: The tag is still unchecked.

There seems to be an off-by-one error somewhere in a counter which decides
whether to "half-check" the tag list. Can you find it?

Thank you!

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374071

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.4.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/63c1c20420330860cef136
                   |                            |97aa826b06179a4910
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Maik Qualmann <[hidden email]> ---
Git commit 63c1c20420330860cef13697aa826b06179a4910 by Maik Qualmann.
Committed on 24/12/2016 at 11:54.
Pushed by mqualmann into branch 'master'.

fix introduced bug in digiKam-5.4.0 in the ImageCategorizedView
FIXED-IN: 5.4.0

M  +2    -1    NEWS
M  +4    -2    app/items/imagecategorizedview.cpp

https://commits.kde.org/digikam/63c1c20420330860cef13697aa826b06179a4910

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374071

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Simon <[hidden email]> ---
Created attachment 102975
  --> https://bugs.kde.org/attachment.cgi?id=102975&action=edit
Same change for tableview.cpp

Even though this check should not be necessary in tableview (should always be
true after my recent patch), it is probably just more consistent and safe to
introduce your change there as well. Also the fact that this check is needed
for imagecategorizedview might suggest an underlying issue with column
mismatches in the given indexes. I will have a quick look at this after
Christmas.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374071

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Git commit 125dce3cbdc6214196fe179d92fc84e43b5736fa by Maik Qualmann.
Committed on 24/12/2016 at 14:26.
Pushed by mqualmann into branch 'master'.

apply patch #102975 from Simon to add not current item if is deselected

M  +4    -2    app/views/tableview/tableview.cpp

https://commits.kde.org/digikam/125dce3cbdc6214196fe179d92fc84e43b5736fa

--
You are receiving this mail because:
You are the assignee for the bug.