[digikam] [Bug 369345] New: In tagging apply to all versions fails

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

            Bug ID: 369345
           Summary: In tagging apply to all versions fails
           Product: digikam
           Version: 5.1.0
          Platform: Debian testing
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]

The title says it all: Clicking on the button "Apply to all versions" after
changing tags does not do anything. In the console the following error shows
up:

QObject::connect: Cannot connect (null)::progressItemCompleted(ProgressItem*)
to Digikam::FileActionProgressItemContainer::signalWrittingDone()

This is the same whether the marked item is a grouped item or a single picture.

Reproducible: Always

Steps to Reproduce:
1. Change tags.
2. Clich "Apply to all versions"

Actual Results:  
Nothing happens (except console output).

Expected Results:  
Tags are applied to the marked item and if appropriate to all other items in
the group.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|5.1.0                       |5.2.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

--- Comment #1 from Simon <[hidden email]> ---
I can still reproduce this with the current master (afebcb2).
Can anyone else reproduce this error?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.3.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/0486a5c9643a69bcd3f8933
                   |                            |6347ec54a0259353e
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Git commit 0486a5c9643a69bcd3f89336347ec54a0259353e by Maik Qualmann.
Committed on 11/10/2016 at 20:52.
Pushed by mqualmann into branch 'master'.

if there are no versioned images, apply metadata only to the selected image
FIXED-IN: 5.3.0

M  +2    -1    NEWS
M  +2    -1    libs/fileactionmanager/fileactionimageinfolist.cpp
M  +7    -1    libs/imageproperties/imagedescedittab.cpp

http://commits.kde.org/digikam/0486a5c9643a69bcd3f89336347ec54a0259353e

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Note: "Apply to all versions" is not for grouped images, only for versioned
images.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[Simon Frei]

Hi Maik,

Thanks for fixing this.
So there is currently no way to tag, flag, ... grouped images?
This is kind of a big deal, as grouping camera jpgs and raw images is an
essential feature for me, but tags only applying to the first image in
the stack makes it almost useless, as you cannot filter images "in the
background" (they have no tags). Intuitively I would have expected that
tags/... are applied to all grouped images when they are grouped or
collapsed in tree view and only to the single selected image when
"ungrouped". Is this behaviour or an additional button like "apply to
entire group" a possibility?

On 11/10/16 22:59, Maik Qualmann via KDE Bugzilla wrote:

> https://bugs.kde.org/show_bug.cgi?id=369345
>
> Maik Qualmann <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[hidden email]
>
> --- Comment #3 from Maik Qualmann <[hidden email]> ---
> Note: "Apply to all versions" is not for grouped images, only for versioned
> images.
>
> Maik
>

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369345

--- Comment #4 from Simon <[hidden email]> ---
Hi Maik,

Thanks for fixing this.
So there is currently no way to tag, flag, ... grouped images?
This is kind of a big deal, as grouping camera jpgs and raw images is an
essential feature for me, but tags only applying to the first image in
the stack makes it almost useless, as you cannot filter images "in the
background" (they have no tags). Intuitively I would have expected that
tags/... are applied to all grouped images when they are grouped or
collapsed in tree view and only to the single selected image when
"ungrouped". Is this behaviour or an additional button like "apply to
entire group" a possibility?

On 11/10/16 22:59, Maik Qualmann via KDE Bugzilla wrote:

> https://bugs.kde.org/show_bug.cgi?id=369345
>
> Maik Qualmann <[hidden email]> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |[hidden email]
>
> --- Comment #3 from Maik Qualmann <[hidden email]> ---
> Note: "Apply to all versions" is not for grouped images, only for versioned
> images.
>
> Maik
>

--
You are receiving this mail because:
You are the assignee for the bug.