[digikam] [Bug 368575] New: Untranslatable strings in BQM-File Renaming (Date & Time dialog)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368575

            Bug ID: 368575
           Summary: Untranslatable strings in BQM-File Renaming (Date &
                    Time dialog)
           Product: digikam
           Version: 5.1.0
          Platform: Archlinux Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: BatchQueueManager-Renaming
          Assignee: [hidden email]
          Reporter: [hidden email]

See screenshot. The highlighted strings are untranslatable:

example:

Standard
ISO
Text
UnixTimeStamp
Custom

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368575

--- Comment #1 from André Marcelo Alvarenga <[hidden email]> ---
Created attachment 101028
  --> https://bugs.kde.org/attachment.cgi?id=101028&action=edit
Screenshot

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368575

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
The text come from .UI files from Advanced Renamed tool used by BQM.

The file are parsed by Messagess.sh script for string extraction :

[gilles@localhost core]$ pwd
/home/gilles/Devel/5.x/core

[gilles@localhost core]$ cat Messages.sh
#! /bin/sh
$EXTRACTRC `find . -name \*.rc -o -name \*.ui | grep -v '/tests/'` >> rc.cpp ||
exit 11
$XGETTEXT `find . -name \*.h -o -name \*.cpp | grep -v '/tests/'` `find app
-name \*.h.cmake.in` -o $podir/digikam.pot
rm -f rc.cpp
gilles@localhost core]$ find . -name \*.rc -o -name \*.ui
...
./utilities/advancedrename/parser/modifiers/rangemodifierdialogwidget.ui
./utilities/advancedrename/parser/modifiers/replacemodifierdialogwidget.ui
./utilities/advancedrename/parser/modifiers/fillmodifierdialogwidget.ui
./utilities/advancedrename/parser/options/dateoptiondialogwidget.ui
...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368575

Burkhard Lueck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #3 from Burkhard Lueck <[hidden email]> ---
Untranslated in recent master build from sources in locale de + x-test

dateoption.cpp:240:    QString result = QString::fromUtf8("example:
%1").arg(formattedDateTime(QDateTime::currentDateTime()));
"example: %1" not extracted

dateoption.cpp:252:    addToken(QLatin1String("[date:||key||]"),    i18n("Date
and time (||key|| = Standard|ISO|UnixTimeStamp|Text)"));
This does apparently not work with xgettext

dateoption.cpp:61:    m_map.insert(Custom,      
DateFormatDescriptor(QLatin1String("Custom"),         QVariant()));
"Custom" not extracted

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=368575

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.2.0
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/83becf3c1cc64dd619ef74c
                   |                            |b0094bb8ad6752891
         Resolution|---                         |FIXED

--- Comment #4 from [hidden email] ---
Git commit 83becf3c1cc64dd619ef74cb0094bb8ad6752891 by Gilles Caulier.
Committed on 12/09/2016 at 15:34.
Pushed by cgilles into branch 'master'.

fix not i18n strings
FIXED-IN: 5.2.0

M  +2    -1    NEWS
M  +8    -8    utilities/advancedrename/parser/options/dateoption.cpp
M  +10   -7    utilities/advancedrename/parser/options/dateoption.h

http://commits.kde.org/digikam/83becf3c1cc64dd619ef74cb0094bb8ad6752891

--
You are receiving this mail because:
You are the assignee for the bug.