[digikam] [Bug 366769] New: Rename aborts after first rename of many

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

            Bug ID: 366769
           Summary: Rename aborts after first rename of many
           Product: digikam
           Version: 5.1.0
          Platform: Mac OS X Disk Images
                OS: OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: AdvancedRename
          Assignee: [hidden email]
          Reporter: [hidden email]

Renaming video files fails after the first of many files to be renamed.  This
affects my MP4 video files.  It does not affect jpg files.
This appears similar to bug 357617

Reproducible: Always

Steps to Reproduce:
1.  Select several video files (in my case MP4 from GoPro)
2. F2 to start rename dialog.  
3. Change the name and start the rename.

Actual Results:  
The first file is renamed, but the others are not.  a Renaming Images dialog
box comes up and says Please wait... Processing.  The only option is to Abort.  

Expected Results:  
All the files would be renamed. Instead 1 of 10 files were renamed.

This appears similar to bug 357617

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

--- Comment #1 from Geoff King <[hidden email]> ---
I just tried it with some MOV files and some of those changed the name two at a
time.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
What do you use as rename scheme to complete the operation ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Git commit bb07b39065c7ba8d5b2763097ebdba05baa54a6b by Maik Qualmann.
Committed on 16/08/2016 at 06:10.
Pushed by mqualmann into branch 'master'.

filter out multiple signals from ThumbnailLoadThread
Related: bug 357617
FIXED-IN: 5.2.0

M  +2    -1    NEWS
M  +5    -12   utilities/advancedrename/advancedrenameprocessdialog.cpp

http://commits.kde.org/digikam/bb07b39065c7ba8d5b2763097ebdba05baa54a6b

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

--- Comment #4 from Maik Qualmann <[hidden email]> ---
Git commit 24e1d9e0a67ff6179a6dbf26f9a4ca2589ed8445 by Maik Qualmann.
Committed on 16/08/2016 at 19:28.
Pushed by mqualmann into branch 'master'.

fix possible deadlocks from video thumbnailer

M  +7    -7    libs/threadimageio/videothumbnailer.cpp
M  +3    -6    libs/threadimageio/videothumbnailer.h
M  +18   -16   libs/threadimageio/videothumbnailer_p.cpp
M  +1    -0    libs/threadimageio/videothumbnailer_p.h
M  +35   -27   libs/threadimageio/videothumbnailerjob.cpp
M  +2    -5    libs/threadimageio/videothumbnailerjob.h

http://commits.kde.org/digikam/24e1d9e0a67ff6179a6dbf26f9a4ca2589ed8445

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Gilles,

can you test with the current git/master version on Mac OS X the renaming of
mixed video and image files? Video monitoring is not available under Mac OS X.
I think there should be no problems more.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Git commit 28939a4dca842c0feaa802ee15e07ba6a5ce52f9 by Maik Qualmann.
Committed on 16/08/2016 at 20:16.
Pushed by mqualmann into branch 'master'.

Revert "fix possible deadlocks from video thumbnailer"

M  +7    -7    libs/threadimageio/videothumbnailer.cpp
M  +6    -3    libs/threadimageio/videothumbnailer.h
M  +16   -18   libs/threadimageio/videothumbnailer_p.cpp
M  +0    -1    libs/threadimageio/videothumbnailer_p.h
M  +27   -35   libs/threadimageio/videothumbnailerjob.cpp
M  +5    -2    libs/threadimageio/videothumbnailerjob.h

http://commits.kde.org/digikam/28939a4dca842c0feaa802ee15e07ba6a5ce52f9

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Git commit 7745925f7c54bac7dab6b19be67fe5d3b0828c18 by Maik Qualmann.
Committed on 17/08/2016 at 20:47.
Pushed by mqualmann into branch 'master'.

fix possible deadlocks from video thumbnailer #2

M  +7    -2    libs/threadimageio/videothumbnailerjob.cpp

http://commits.kde.org/digikam/7745925f7c54bac7dab6b19be67fe5d3b0828c18

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

Geoff King <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #8 from Geoff King <[hidden email]> ---
Looks to be fixed now on 5.2.0 for Mac.  Thanks and please close.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366769

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.3.0

--
You are receiving this mail because:
You are the assignee for the bug.