[digikam] [Bug 366621] New: Crash when performing Transformation resize operation

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366621

--- Comment #19 from Maik Qualmann <[hidden email]> ---
Git commit 65fa04ca097d4ff695690886a9f2be459b4279a9 by Maik Qualmann.
Committed on 12/08/2016 at 19:29.
Pushed by mqualmann into branch 'master'.

fix crash by big memory allocation for DImg on 64bit

M  +4    -4    libs/dimg/dimg.cpp
M  +1    -1    libs/dimg/dimg.h
M  +1    -1    libs/dimg/loaders/dimgloader.cpp

http://commits.kde.org/digikam/65fa04ca097d4ff695690886a9f2be459b4279a9

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366621

--- Comment #20 from [hidden email] ---
Maik,
Coverity scan report a problem with your last patch. See below :

** CID 1369583:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/home/gilles/Devel/5.x/core/libs/dimg/loaders/dimgloader.cpp: 166 in
Digikam::DImgLoader::checkAllocation(long long)()


________________________________________________________________________________________________________
*** CID 1369583:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
/home/gilles/Devel/5.x/core/libs/dimg/loaders/dimgloader.cpp: 166 in
Digikam::DImgLoader::checkAllocation(long long)()
160         m_image->m_priv->width  = 0;
161         m_image->m_priv->height = 0;
162     }
163
164     qint64 DImgLoader::checkAllocation(qint64 fullSize)
165     {
>>>     CID 1369583:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "(quint64)fullSize > 18446744073709551615ULL /* std::numeric_limits<unsigned long>::max() */" is always false regardless of the values of its operands. This occurs as the logical operand of if.
166         if ((quint64)fullSize > std::numeric_limits<size_t>::max())
167         {
168             qCWarning(DIGIKAM_DIMG_LOG) << "Cannot allocate buffer of size"
<< fullSize;
169             return 0;
170         }
171

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366621

--- Comment #21 from Maik Qualmann <[hidden email]> ---
Git commit 8c2a48759c3b7ef16e14458d423ef7041481e501 by Maik Qualmann.
Committed on 17/08/2016 at 17:56.
Pushed by mqualmann into branch 'master'.

fix CR #1369583

M  +1    -1    libs/dimg/loaders/dimgloader.cpp

http://commits.kde.org/digikam/8c2a48759c3b7ef16e14458d423ef7041481e501

--
You are receiving this mail because:
You are the assignee for the bug.